From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0044.outbound.protection.outlook.com [104.47.36.44]) by dpdk.org (Postfix) with ESMTP id B8AD82BD4 for ; Tue, 30 Aug 2016 06:38:23 +0200 (CEST) Received: from BN6PR03CA0037.namprd03.prod.outlook.com (10.175.124.23) by CY1PR0301MB2011.namprd03.prod.outlook.com (10.164.2.17) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Tue, 30 Aug 2016 04:38:20 +0000 Received: from BN1AFFO11FD051.protection.gbl (2a01:111:f400:7c10::151) by BN6PR03CA0037.outlook.office365.com (2603:10b6:404:10c::23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9 via Frontend Transport; Tue, 30 Aug 2016 04:38:19 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD051.mail.protection.outlook.com (10.58.53.66) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Tue, 30 Aug 2016 04:38:20 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u7U4cHft019799; Mon, 29 Aug 2016 21:38:17 -0700 To: Ferruh Yigit , References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-18-git-send-email-shreyansh.jain@nxp.com> <57C46970.7020101@intel.com> CC: , , , From: Shreyansh Jain Message-ID: <653509b8-5fc3-296f-ae73-cf1a33894387@nxp.com> Date: Tue, 30 Aug 2016 10:08:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57C46970.7020101@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131170055005774429; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(24454002)(377454003)(189002)(199003)(36756003)(86362001)(8666005)(92566002)(47776003)(586003)(2950100001)(65806001)(81166006)(65956001)(19580395003)(7846002)(33646002)(81156014)(230700001)(105606002)(356003)(305945005)(8936002)(64126003)(77096005)(189998001)(19580405001)(50466002)(4326007)(31686004)(54356999)(76176999)(5660300001)(31696002)(2906002)(50986999)(626004)(93886004)(85426001)(87936001)(106466001)(4001350100001)(83506001)(97736004)(68736007)(8676002)(65826007)(104016004)(5001770100001)(23746002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB2011; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD051; 1:OgfxWTPJfITVZJpR5ftYGJCoAjOuXmh0AKR8i9jKu7tTmNsUxQki577tSFdAinp928/bWmh0FWQdmjc4Ir0bpm7KE45YO+Vt6uAJKHyV22DwQIYAqwhYO4QZKN5Sko3xZcdnb5HBwR1n+7y44DxYEtq13QdiF2p1ViuiIi7v4PANMNzyHD3JyW2MhAnIjmugyrs8ARV8mSlaF+0+xXIS6x7iU0FLFVjf9Hjwj4cnFDCjRR26EY/b9VLkmF6z4CQM3d/e5m78DErkTr4O7GLpK1bl0bhTuAbjE/Ug41WXEDN068a8yrK4Ramv6GbFpE0TViSvIvb6YxMzbv901dtZOeoh7oN7LDIoJOgW99aPp8H8J4DwdJK4YqOhhHQCvq+XO7wRb6GZnRGbNfLR4MbPY2kYTNQ5B71gHJ1ygq9tbrU1ztuhSjDXnuwQle25a8p6k1xUC0bqT7YXIjQzUm47J4qYs1PAvTlsoEbqyY/IY2fgbmTh3S4M7cw7/M6rF1ReU4GvK+zg0JFtP3bx8MbsRd/abffeWYdYIrt3i4rBClVDWfIYQuMaV51x7pK8DaIE89aTvfn8nUVX6rHA4ZfzK6/fJFrq+vlrVDQo9RTU0QClYM2yiDT8t0M1hUiWqcVQ45TG3eGnuUKR6UIO0dzGmw== X-MS-Office365-Filtering-Correlation-Id: 7b190a6f-dcfb-47b5-a25d-08d3d08f7840 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2011; 2:0K9RhYtdWie8Y3AYwS9A744hGa/mvyuP6xVRD3mt94oPTMp1qzE3lpjsiZLEVtHCP5fiOLjqmg94v8xIadl56Tiy6yWSrYpOQjehOZqGdqmVAjE6h0XoQQmz1pglWVdmA4VHQ7yd94QHOBnHJf4RvvRJ65oyTi0FfsVZH1S+ZkJrxRRgCxY15BD4bRbMSVYo; 3:MNU4Gw+Of+XQjurKFwwtBTZgIH3ul75aNtkHcxg13SKrP02wuYw/dHe3zuyMDGql7s9ztPY6gJwd5ITP2/jJwUJA/SnO6CaAg2ORcvOfravquRi+XvxR4K/CxhMhEjGhaKzXD0X2OcJQRNacg4CeWzyd6UbPLcpsdtp1cmoeavJ5fRHQcW3ROgwKxF3U087s+SnYshQfXaj2rd+st5OUZXA9hs+oJ77VBmd1cSoy0BQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB2011; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2011; 25:hMsJmcUODU9RVszxJZbznusaGAZX04jPeAf+LjPeKTA4J/YrVjiSbCFsFHcTKcywpnWFo/Ysn8JAQmAFO9yvaY0aG5ZM2o3cgCDLuSmFFZYwuRpukYbs59eeZDCxHw13rnfy5GgbXZpj7hJil8D4Coje4VKvZcBTbd4FJgThDEA8oGS8CEO7j8LYuVV3VATBjToP46drL4OcftOtwhsd9oXKFAqqKa8sxN4KSUdD+h7Ifp1qn+UhNeBGKy+4S2VQ2+3CESiYnKdqq1ce4P5pyqaz4fXxCEiI8EB+dIpdNS6juvMSiEAd9lbzH2kGI0+vKF0WHG9u6/hQzGtaiSimt3aV8DT2ru6J1v5cPlwYRgA9pd4D4XZ+qfS48O/L1n7VWmrMp3y3Ouk0IfGd/i8bglxhtXo8gubZy/tHrCwJ5bAOmeRjJesx+BjS+/1rJ81rUZ58Rg4P+5feflfUKhO2PNlKwS3AxVzSDBxLep6l0VfNd9w861lwAEu1pJGL9TVEmoQ4CeQdpFGTy/d19EDJIGqTGPmCjaWh5yUCTJpc3G/hT5oox/FZte4XaAd6TuVvWrTw5C9ttiNPKFw5FlSOAa9GSg5Y9GXNXXb7/bz+gZrNj7tuzPcFBm2Ezt8bdqmm028UBXTp6r8a5mOOo3C/9xgftsxR99DfNYPT/QwkOd8Xne0Y2wZkCvO4YISe7d7BFLgH4QhPrRcmEAd0/K0x952DGfnsHc08dcLCLboiXBkj/YzvvtEJrvTJJNH5MXWX X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2011; 31:M68DAOTYCdiI4d5OeHX019q3Oj9WPYwZ2fqGKmMB5Q3aK9PUFwgop9UFzfCfPKv6KcZgSkBGvhgIAzY9WSVtGuQBCQBz/oWg2lkDmmlpSMzz+44sLwk8uF27BmCIdQMEY4PMCUHBJSObpHaDX2qxsk8KgbNYJnU+clagrYLxfDmgTT5y9n4NPTRpke95M3BCYiZS3UetrUMaBKFSIvPeFvDTLfsunMzWwxemBoEdm/s=; 4:LRlPRHh+c2WHr7yaF6fPSiKtHOfCOF0fhW6WFeaaFtOoKcWE8+jynJQjj8wFkGiB8XrkVcEoD6/7TX3tNWuAD/LpogioZyS11NdF2fI5qbId8Nb7cMdlr578MC3uCWVdP1S8uJyuzGyDrgbLmLMkGBOmQgj2kpLvwaYU9nE/wpv+teuMcH3IcqapV2GhbFcJCGKDMSe5Xmox1iD+LkMOpocnHsIdG390LhkYdwcV4yMojrRARbyyKKjM05/5vw7VSKyp2GVpUMwEuBhYhaOYbJT/r9RWNDtLhIlkgFL84VsRijPTWZ+khm/28LgNha7TD5bo4S9I6SRpHE0ov22cmnCHbdRogNp+O0nLfClwcz4w2QDDbYFPZVPtulrZAFkmVorXp+IiDD+8kAmEITfshznCqeGVKLk2pDe40Bbn2VCxrp37Y8H0zvGRvHOI+0qCneHdyhljcXUDJvNg1EZXuqIW1cjKyfKx54NwMMVLzbOlnr149HT0lCH5UNeh29CA/pjiI/WKVbjIG9fF7qqB3UirnfrSKn1I3E5oU60jdCY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13017025)(8121501046)(5005006)(13015025)(13024025)(13023025)(13018025)(3002001)(10201501046)(6055026); SRVR:CY1PR0301MB2011; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB2011; X-Forefront-PRVS: 0050CEFE70 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY1PR0301MB2011; 23:P1oWU+Yde+ksjEqSvTPwE+SPuz/PVXc/ciC?= =?Windows-1252?Q?rf1rKan+PoCwxY+05PHpVU7SOPc8QqVg/K0TbzHG6A4Sbs5zPjpPmvOL?= =?Windows-1252?Q?a3e37wpHRC4OCDIFwkC9UzpGRJV/C+IbW6y1nzfHUazxeaVPcUcHwxV5?= =?Windows-1252?Q?F1/z//NmEIXzz016dNCh2h5AoJFFEcsr5VLruzwoEWPHeaOyzcOolGrK?= =?Windows-1252?Q?2f+aiAcSzy/ZOXLhID9X0zz/Dm+cdEsts9CRJEh9idWBVf35yQGqqsuz?= =?Windows-1252?Q?B7ThRdW+rcjOgt853KYNyASoRfrQEw4T8Q8fdvYZ4CMICYYmz5FmOb5+?= =?Windows-1252?Q?OoErXj4CydEHwtwxkuTf8yJOTK5Mzip2ql0bl2TtL+aNWn7Nv1LrZZqO?= =?Windows-1252?Q?7zSKrPwxzPSvxnhAHLgfZIvxcDJ/7/wuZh/SaMw+sCKgbUbSgVg8XUfd?= =?Windows-1252?Q?uenqXFy9rfMsXl7gBUo+bYEE2n5QgFNydqdip4NRgOmmZKz3vDb+QMON?= =?Windows-1252?Q?fpRQQfBRTv/6wW+ipi558RiWGGfoY5KhOb6BzovdRrVbd+y7i/4RnVVp?= =?Windows-1252?Q?s2blRR/lFTdS9RwQRpMLRNQjmVRid+y4f9f7DNdwbOWUUISW3DYYSBq+?= =?Windows-1252?Q?Pl5ufHsyVqbqoPoQfJiYE0EBObWxniw3Yo82x+JV/WbZa2byv2AZ+GrW?= =?Windows-1252?Q?pJ329pfT20dOax2E5n5mVwrcHiVLPHG06fohWdNCwXCllh8Q+6YI7c59?= =?Windows-1252?Q?CF0KVTy/yp8HIunIW7UNZW9W1cY6SmZwdExB7ieTO19MLt0Mn1+KkABm?= =?Windows-1252?Q?m34/6lFyrdl5sro51UujB68m5MT5vuwLIvvrlYhDEE10G1+lhjwXG3tP?= =?Windows-1252?Q?4B16T7PbiFBIq5n6kt2bc5yTLlYKK0XCPzUg8mMV+1oiLLq2/Z44nfcY?= =?Windows-1252?Q?Ho4YdQzoRHn2RY+iJfgi41NQPBlFuH8nqmfboYQeVXDRrV9MKbvRg5yc?= =?Windows-1252?Q?Jm3vqeAhqU7+DLxGd2UPYK8DkYpm8NXFZAlJhQJAYdmdZvz0dgXzvmLd?= =?Windows-1252?Q?hRYSie3mTo3aNNgCVohVWLbXpjTc9ajOnjH2JTgws5kV14hfGS1YGz8I?= =?Windows-1252?Q?e9ynh/5i/FoF/8vc7cJx51XnvZTx2PGIkLBdfGOkfclGBYVpwL/C8tdw?= =?Windows-1252?Q?EOUr5oisgtprRgvFCuq4M7qCqBv39QTebPf2zQkuarwFUnS/reI+Fa1n?= =?Windows-1252?Q?58rbo0fxNzA/vea1efrbGER5mA95zG6kyn5aR+3Rz5noZlJCXkA/+61k?= =?Windows-1252?Q?UyF5xa2H3HyzHmwIIGdiqj+LyG7A16NLe5IYcxz9y0OdU569IeScAT2O?= =?Windows-1252?Q?dKp28FBy95mPtXs1IqoUL7kBcEIh0+NLDsuil74xpb8jB312SxDX5sZy?= =?Windows-1252?Q?t5V3Cb0EUGzbWlnqVT6/mE6D2A/0O6J4uHV1+yE1sb/x4Ua6968s3OHx?= =?Windows-1252?Q?PAvjUpDU=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2011; 6:JlA0koOjGk1Osc5wPHy9njcTYtHOGv2szcFgXx3liodWjMwwBdaIts5Z3gV5wjUQ0XvTnAnJxwC9xyw3orjAEQUILuZivPdSWhfsMI57tHVafLb4+6HSyicLwhc+Xodgl6aQ+7guF0TcTIhWt2TTC2ABgHNwuKP1jyfX31gNn5LsNM2pjBnJNh1mfa3oiiotSiaDHbyCYAwy0UvlJINRolP1X64hWENVCzn/wU+NC4n5n/68NReh3XF8YXdfDjRyPQdlGQes4AgXG9GD5tZl5Dq6DaqUukkfv3nadh2y5u0=; 5:RP8Vv6bN+AFUB7lS2sBnhz9ofC695WAv8ciTAqj/Hhf/JKK4BHgSOUF1NohKqZyKR7/8WFEBKmlHhZe7xESke7ZZrWweyjBFPu+8QK5miXu24vrLhIdEiXzWKl2xEtFt6Gp+UhXyGCVTnW+VGlF38qBbxZx4UYWUAz/lxluuzko=; 24:CMjd7L+nJokKjgQnA5Zo53w+lETzNt6AGRzu4TZCAy2ajbCN4PP0rrUq1PPF5nFG6aQr9vcozDghH3dAMvLHXVb3KQiVxRvv7pmiFn3HmhI=; 7:F1/ZtWkGyfXNk2b7MGAUkbJheg0ZljHPyDXyM8vOEN4sUPxbmwkyx/iShaKHyGslNS9502kUhR+45AbRWeq2xlHkMr6eEsmAM0m5qi5XhEruX52A5dGRvbRGziV871wN5r7YkW8Ow2CtUn1a/v56ZkA9/ADRCDczjHAm8iZvqUtL0BEjtGqdSljsZwrHW7uUnr0+b1hJDZ9kvSm56mUCgNLLs2cLhbzRE8+F+VrqSjehvXco92LIY6oVudIp0LI3 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2016 04:38:20.3434 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2011 Subject: Re: [dpdk-dev] [PATCH v8 17/25] drivers: convert PMD_VDEV drivers to use rte_vdev_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 04:38:24 -0000 On Monday 29 August 2016 10:27 PM, Ferruh Yigit wrote: > On 8/26/2016 2:56 PM, Shreyansh Jain wrote: >> All PMD_VDEV drivers can now use rte_vdev_driver instead of the >> rte_driver (which is embedded in the rte_vdev_driver). >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> --- > > .... > >> diff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c >> index 6b15381..fa00e52 100644 >> --- a/drivers/net/xenvirt/rte_eth_xenvirt.c >> +++ b/drivers/net/xenvirt/rte_eth_xenvirt.c >> @@ -759,12 +759,14 @@ rte_pmd_xenvirt_devuninit(const char *name) >> return 0; >> } > > xenvirt missing header file rte_vdev.h: > > CC rte_eth_xenvirt.o > ..../drivers/net/xenvirt/rte_eth_xenvirt.c:762:31: error: variable has > incomplete type 'struct rte_vdev_driver' > static struct rte_vdev_driver pmd_xenvirt_drv = { Thanks for highlighting. I will fix this. > > >> >> -static struct rte_driver pmd_xenvirt_drv = { >> - .type = PMD_VDEV, >> - .init = rte_pmd_xenvirt_devinit, >> - .uninit = rte_pmd_xenvirt_devuninit, >> +static struct rte_vdev_driver pmd_xenvirt_drv = { >> + .driver = { >> + .type = PMD_VDEV, >> + .init = rte_pmd_xenvirt_devinit, >> + .uninit = rte_pmd_xenvirt_devuninit >> + }, >> }; >> >> -PMD_REGISTER_DRIVER(pmd_xenvirt_drv, eth_xenvirt); >> +DRIVER_REGISTER_VDEV(eth_xenvirt, pmd_xenvirt_drv); >> DRIVER_REGISTER_PARAM_STRING(eth_xenvirt, >> "mac="); >> > > - Shreyansh