From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"Dabilpuram, Nithin" <Nithin.Dabilpuram@cavium.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
"Czekaj, Maciej" <Maciej.Czekaj@cavium.com>,
"Nilla, Subrahmanyam" <Subrahmanyam.Nilla@cavium.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/thunderx: fix Tx desc corruption in scatter-gather mode
Date: Fri, 9 Nov 2018 20:25:52 +0000 [thread overview]
Message-ID: <653b50e5-fd7c-3f15-1528-21422ad767d1@intel.com> (raw)
In-Reply-To: <20181109082000.GA4934@jerin>
On 11/9/2018 8:20 AM, Jerin Jacob wrote:
<...>
>> From: Subrahmanyam Nilla <snilla@caviumnetworks.com>
>>
>> For performance reasons, word1 of send_hdr_s
>> sub descriptor was not cleared assuming it is always
>> having default value of zero since it comes from fixed
>> offsets of SQ buffer.
>> This is causing issues in case of SG mode because,
>> the size of send command might change and hence the word1
>> of send_hdr_s is not always at fixed offsets of the SQ buffer
>> and hence not having default value of zero.
>>
>> This fixes the issue by clearing the word1 in case of SG mode
>> for every packet.
>>
>> Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Subrahmanyam Nilla <snilla@caviumnetworks.com>
>> Signed-off-by: Nithin Dabilpuram <ndabilpuram@caviumnetworks.com>
>> ---
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2018-11-09 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 5:50 [dpdk-dev] " Nithin Dabilpuram
2018-11-09 8:20 ` Jerin Jacob
2018-11-09 20:25 ` Ferruh Yigit [this message]
2018-11-12 7:21 ` Verma, Shally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653b50e5-fd7c-3f15-1528-21422ad767d1@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=Maciej.Czekaj@cavium.com \
--cc=Nithin.Dabilpuram@cavium.com \
--cc=Subrahmanyam.Nilla@cavium.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).