From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A13D45CB7; Fri, 8 Nov 2024 22:56:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E93934067C; Fri, 8 Nov 2024 22:56:19 +0100 (CET) Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) by mails.dpdk.org (Postfix) with ESMTP id 3AC8240263 for ; Fri, 8 Nov 2024 22:56:18 +0100 (CET) Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id AC0C6138029E; Fri, 8 Nov 2024 16:56:17 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Fri, 08 Nov 2024 16:56:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731102977; x=1731189377; bh=JXvzVSkwBjHoUAvBKPjI6YeX62NsHSh8DAGSdEeURdU=; b= zXBw1jw2xffrBiImqy1jj9JXe7ZMJcfjzykNO0ZlW3WNfvkYbLYdx3D02C44xtYV NWUsMUCvOVMmCrXiVDl007UNapp+N7F4GS3ZCqIBGAUMwPcXvdyZXnm7BCnbypMu 1/KieHS9vi7d6ChwI8BfkudzsNi+GhqAJEO/IroGNr6tLIP8cqR5na5EFrwzc1Fv NH8SKTXfcKl6cC361PAmK3xgZy6fFHgocKyA0RAutZyquZ0Y+ZUgMkoHqiC8uihw x0a+kmPBCPE5re2GHY+eGNchdzd9UxK9adiPFNF709ukw4quKIZyq/lc+df0LVxa 6rB4MFWz3QbycMhuRSpHdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731102977; x= 1731189377; bh=JXvzVSkwBjHoUAvBKPjI6YeX62NsHSh8DAGSdEeURdU=; b=l +lXDveSDKUSN0gSKZeAe1ynKgpIrmZc/TYRdkl0yhM+4iPGFN9+GG1EHrvY8JInk o7GS+Q07nZXrEQvwZyeaC3Gow4wH27H/9fz8AWTcZvgCJjGQiK2v4Qm09QE0xkF2 078EOiQ/OTUq/KbWG727YyR1A7cff3W4dE3/Gwo8sWbeccsvbUjS+tizImOb2TF/ S4OuQbn4USPTCM5xxhm3HagugRhb3mcthgpUUySPjBxY7K96HVUkz32S1l1BErap WklpYZ+WWJrj9g8sQX2UxAT40892UqKiXGD896HN1ZBcCcDiFzVtE4ysZuT4D3V1 2CyKWLawAMKF92r9+8i7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdeigdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeduvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepkhhonh hsthgrnhhtihhnrdgrnhgrnhihvghvsehhuhgrfigvihdrtghomhdprhgtphhtthhopegu vghvseguphgukhdrohhrghdprhgtphhtthhopehhohhnnhgrphhprgdrnhgrghgrrhgrhh grlhhlihesrghrmhdrtghomhdprhgtphhtthhopehjvghrihhnjhesmhgrrhhvvghllhdr tghomhdprhgtphhtthhopehhvghmrghnthdrrghgrhgrfigrlhesnhigphdrtghomhdprh gtphhtthhopegsrhhutggvrdhrihgthhgrrhgushhonhesihhnthgvlhdrtghomhdprhgt phhtthhopegurhgtsehlihhnuhigrdhvnhgvthdrihgsmhdrtghomhdprhgtphhtthhope hruhhifhgvnhhgrdifrghnghesrghrmhdrtghomhdprhgtphhtthhopehmsgesshhmrghr thhshhgrrhgvshihshhtvghmshdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Nov 2024 16:56:14 -0500 (EST) From: Thomas Monjalon To: Konstantin Ananyev Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, jerinj@marvell.com, hemant.agrawal@nxp.com, bruce.richardson@intel.com, drc@linux.vnet.ibm.com, ruifeng.wang@arm.com, mb@smartsharesystems.com, eimear.morrissey@huawei.com, stephen@networkplumber.org, David Marchand Subject: Re: [PATCH v8 0/7] Stage-Ordered API and other extensions for ring library Date: Fri, 08 Nov 2024 22:56:12 +0100 Message-ID: <6543745.5fSG56mABF@thomas> In-Reply-To: <20241107182429.60406-1-konstantin.ananyev@huawei.com> References: <20241030212304.104180-1-konstantin.ananyev@huawei.com> <20241107182429.60406-1-konstantin.ananyev@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Konstantin Ananyev (6): > test/ring: fix failure with custom number of lcores > ring: common functions for 'move head' ops > ring: make copying functions generic > ring/soring: introduce Staged Ordered Ring > app/test: add unit tests for soring API > test: add stress test suite This looks too risky to change something in the ring library at this stage of the release cycle. Sorry we got too many issues with other features merged recently to allow more big changes in 24.11. For next version, please could you fixe those typos in comments? avaialble -> available calcuated -> calculated direclty -> directly elemnts -> elements errorneous -> erroneous paramer -> parameter relase -> release strctures -> structures Instead of "RTE soring", please write "DPDK soring", because RTE is nothing more than a namespace prefix. One more thing: Warning in app/test/test_soring_stress_impl.h: Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx Thanks