From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D2D4A04DB; Fri, 16 Oct 2020 23:39:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 030C95A55; Fri, 16 Oct 2020 23:39:03 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8F9DB5A54 for ; Fri, 16 Oct 2020 23:38:59 +0200 (CEST) IronPort-SDR: v/O4iGwL+I0GeJSXBRESHb2y3/k/HSmwcQiBPpq7Ldi8nMe/HsmHUbJUY+NaI4cyXak3fqlVxg 10mykghuuLxA== X-IronPort-AV: E=McAfee;i="6000,8403,9776"; a="166773670" X-IronPort-AV: E=Sophos;i="5.77,384,1596524400"; d="scan'208";a="166773670" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 14:38:58 -0700 IronPort-SDR: SRHD9KNATu0T/KuFHctGQRmWnI+TC08Rpjw1cKnDpLGXJ7N7hgcpzb834RlQd5ptxxI7CXj8wo vp1J5Y1l6aPg== X-IronPort-AV: E=Sophos;i="5.77,384,1596524400"; d="scan'208";a="531878510" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.66]) ([10.252.19.66]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 14:38:56 -0700 To: Thomas Monjalon Cc: Andrew Rybchenko , dev@dpdk.org, "Min Hu (Connor)" , "Wei Hu (Xavier" References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <20201014022649.2165524-1-ferruh.yigit@intel.com> <0d8f6cf8-66e0-8754-f700-aa7dfbff9aba@intel.com> <5239286.r6oyNDfoyL@thomas> From: Ferruh Yigit Message-ID: <65486070-8e02-9348-47fa-d6ed1ab5878d@intel.com> Date: Fri, 16 Oct 2020 22:38:55 +0100 MIME-Version: 1.0 In-Reply-To: <5239286.r6oyNDfoyL@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/2020 3:32 PM, Thomas Monjalon wrote: > 16/10/2020 14:16, Ferruh Yigit: >> On 10/14/2020 3:26 AM, Ferruh Yigit wrote: >>> Queue stats are stored in 'struct rte_eth_stats' as array and array size >>> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >>> >>> As a result of technical board discussion, decided to remove the queue >>> statistics from 'struct rte_eth_stats' in the long term. >>> >>> Instead PMDs should represent the queue statistics via xstats, this >>> gives more flexibility on the number of the queues supported. >>> >>> Currently queue stats in the xstats are filled by ethdev layer, using >>> some basic stats, when queue stats removed from basic stats the >>> responsibility to fill the relevant xstats will be pushed to the PMDs. >>> >>> During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' >>> device flag is created. Initially all PMDs using xstats set this flag. >>> The PMDs implemented queue stats in the xstats should clear the flag. >>> >>> When all PMDs switch to the xstats for the queue stats, queue stats >>> related fields from 'struct rte_eth_stats' will be removed, as well as >>> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. >>> Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be >>> removed. >>> >>> Signed-off-by: Ferruh Yigit >> >> Hi Thomas, Andrew, >> >> What do you think having the patch for this release? > > Acked-by: Thomas Monjalon > Series applied to dpdk-next-net/main, thanks.