From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D86FFA0093; Mon, 15 Jun 2020 08:46:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9FD465F69; Mon, 15 Jun 2020 08:46:37 +0200 (CEST) Received: from dal3relay237.mxroute.com (dal3relay237.mxroute.com [64.40.27.237]) by dpdk.org (Postfix) with ESMTP id 7BC485B3C for ; Mon, 15 Jun 2020 08:46:36 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay237.mxroute.com (ZoneMTA) with ESMTPSA id 172b6bacdb80007667.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 15 Jun 2020 06:46:35 +0000 X-Zone-Loop: 85861b51cf8f16581724e4e8452aa3790180ad92ce42 X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 190123EDA9; Mon, 15 Jun 2020 06:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pMxxirrLM1+rBqqIomd0UWyeU+7nT7QFliJNRc5BByY=; b=ZnhMU4vrgEb8+UrDfD/vpOphym L9eTGH9RtaGJFIj2nmNbwgCEp1KZnkj+JvxmRb99JCqpjG4F71szDl/zaghSA61G+QEHViwj1ptdE KSg5TiI9x745uEzx4DV0OobUy/dSEPivUOnXaJGoDw/NrJUKXw4r1+YAhI3itb42rOa2HjcZlUiQN lcqbeh9xNAj5K2ps7bk8dpNjGsq3jux7fcOG4ZRglsN2/tvxFWwD5Q/W6AYX3e9kLj85JKA1kYs0c 3jL8FHNiQXSgRwGgOwEYlUciVMLw6FR4OSzyVjBRVIL4mFmMGoJFIz7xnJk3JMcLPcC5uWs7kFZSh QU0JwC2A==; To: David Marchand , dev@dpdk.org Cc: Neil Horman , Cunming Liang , Konstantin Ananyev , Olivier Matz References: <20200610144506.30505-1-david.marchand@redhat.com> <20200610144506.30505-3-david.marchand@redhat.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <656bb91c-317f-3d70-f089-ebd8957f2710@ashroe.eu> Date: Mon, 15 Jun 2020 07:46:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200610144506.30505-3-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH 2/7] eal: fix multiple definition of per lcore thread id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/06/2020 15:45, David Marchand wrote: > Because of the inline accessor + static declaration in rte_gettid(), > we end up with multiple symbols for RTE_PER_LCORE(_thread_id). > Each compilation unit will pay a cost when accessing this information > for the first time. > > $ nm build/app/dpdk-testpmd | grep per_lcore__thread_id > 0000000000000054 d per_lcore__thread_id.5037 > 0000000000000040 d per_lcore__thread_id.5103 > 0000000000000048 d per_lcore__thread_id.5259 > 000000000000004c d per_lcore__thread_id.5259 > 0000000000000044 d per_lcore__thread_id.5933 > 0000000000000058 d per_lcore__thread_id.6261 > 0000000000000050 d per_lcore__thread_id.7378 > 000000000000005c d per_lcore__thread_id.7496 > 000000000000000c d per_lcore__thread_id.8016 > 0000000000000010 d per_lcore__thread_id.8431 > > Make it global as part of the DPDK_21 stable ABI. > > Fixes: ef76436c6834 ("eal: get unique thread id") > > Signed-off-by: David Marchand > --- > lib/librte_eal/common/eal_common_thread.c | 1 + > lib/librte_eal/include/rte_eal.h | 3 ++- > lib/librte_eal/rte_eal_version.map | 7 +++++++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c > index 25200e5a99..f04d880880 100644 > --- a/lib/librte_eal/common/eal_common_thread.c > +++ b/lib/librte_eal/common/eal_common_thread.c > @@ -24,6 +24,7 @@ > #include "eal_thread.h" > > RTE_DEFINE_PER_LCORE(unsigned int, _lcore_id) = LCORE_ID_ANY; > +RTE_DEFINE_PER_LCORE(int, _thread_id) = -1; > static RTE_DEFINE_PER_LCORE(unsigned int, _socket_id) = > (unsigned int)SOCKET_ID_ANY; > static RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset); > diff --git a/lib/librte_eal/include/rte_eal.h b/lib/librte_eal/include/rte_eal.h > index 2f9ed298de..2edf8c6556 100644 > --- a/lib/librte_eal/include/rte_eal.h > +++ b/lib/librte_eal/include/rte_eal.h > @@ -447,6 +447,8 @@ enum rte_intr_mode rte_eal_vfio_intr_mode(void); > */ > int rte_sys_gettid(void); > > +RTE_DECLARE_PER_LCORE(int, _thread_id); > + > /** > * Get system unique thread id. > * > @@ -456,7 +458,6 @@ int rte_sys_gettid(void); > */ > static inline int rte_gettid(void) > { > - static RTE_DEFINE_PER_LCORE(int, _thread_id) = -1; > if (RTE_PER_LCORE(_thread_id) == -1) > RTE_PER_LCORE(_thread_id) = rte_sys_gettid(); > return RTE_PER_LCORE(_thread_id); > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index d8038749a4..fdfc3f1a88 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -221,6 +221,13 @@ DPDK_20.0 { > local: *; > }; > > +DPDK_21 { > + global: > + > + per_lcore__thread_id; > + > +} DPDK_20.0; > + > EXPERIMENTAL { > global: Acked-by: Ray Kinsella