From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E455A20F for ; Tue, 20 Oct 2015 01:35:37 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 19 Oct 2015 16:35:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,704,1437462000"; d="scan'208";a="814776157" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 19 Oct 2015 16:35:38 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Oct 2015 16:35:36 -0700 Received: from fmsmsx107.amr.corp.intel.com ([169.254.6.163]) by FMSMSX155.amr.corp.intel.com ([169.254.5.158]) with mapi id 14.03.0248.002; Mon, 19 Oct 2015 16:35:36 -0700 From: "Arevalo, Mario Alfredo C" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [PATCH v4 1/7] mk: Add rule for installing headers Thread-Index: AQHQ/6tFa5uAWlfgO0+3Qm5dngg6tJ5vB9oAgASEs4M= Date: Mon, 19 Oct 2015 23:35:35 +0000 Message-ID: <6594B51DBE477C48AAE23675314E6C460F1B7213@fmsmsx107.amr.corp.intel.com> References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1444076406-30141-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1444076406-30141-2-git-send-email-mario.alfredo.c.arevalo@intel.com>, <56215002.50603@6wind.com> In-Reply-To: <56215002.50603@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.19.9.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/7] mk: Add rule for installing headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2015 23:35:38 -0000 Hi Olivier, thank you for your feedback , more comments below :) =0A= =0A= Thanks.=0A= Mario.=0A= ________________________________________=0A= From: Olivier MATZ [olivier.matz@6wind.com]=0A= Sent: Friday, October 16, 2015 12:29 PM=0A= To: Arevalo, Mario Alfredo C; dev@dpdk.org=0A= Cc: Panu Matilainen=0A= Subject: Re: [PATCH v4 1/7] mk: Add rule for installing headers=0A= =0A= Hi Mario,=0A= =0A= Thank you for this patch series, and thank you Panu for the=0A= good comments on this series.=0A= =0A= Please see some comments below.=0A= =0A= On 10/05/2015 10:20 PM, Mario Carrillo wrote:=0A= > Add hierarchy-file support to the DPDK headers.=0A= >=0A= > When invoking "make install-headers" headers will=0A= > be installed in: $(DESTDIR)/$(INCLUDE_DIR)=0A= > where INCLUDE_DIR=3D/usr/include/dpdk by default.=0A= >=0A= > You can override INCLUDE_DIR var.=0A= > This hierarchy is based on:=0A= > http://www.freedesktop.org/software/systemd/man/file-hierarchy.html=0A= >=0A= > Signed-off-by: Mario Carrillo =0A= > ---=0A= > mk/rte.sdkinstall.mk | 18 +++++++++++++++++-=0A= > mk/rte.sdkroot.mk | 4 ++--=0A= > 2 files changed, 19 insertions(+), 3 deletions(-)=0A= >=0A= > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk=0A= > index 86c98a5..f016171 100644=0A= > --- a/mk/rte.sdkinstall.mk=0A= > +++ b/mk/rte.sdkinstall.mk=0A= > @@ -41,6 +41,10 @@ endif=0A= > # x86_64-native-*-gcc=0A= > ifndef T=0A= > T=3D*=0A= > +ifneq (,$(wildcard $(BUILD_DIR)/build/.config))=0A= =0A= What about using $(RTE_OUTPUT) here instead of $(BUILD_DIR)/build ?=0A= =0A= With you patch, the following commands work:=0A= =0A= make config T=3Dx86_64-native-linuxapp-gcc=0A= make -j32=0A= make install-headers DESTDIR=3Dinstall=0A= =0A= Replacing all the occurences of $(BUILD_DIR)/build by $(RTE_OUTPUT)=0A= would also make the following commands work:=0A= =0A= make config T=3Dx86_64-native-linuxapp-gcc O=3Dbuild2=0A= make -j32 O=3Dbuild2=0A= make install-headers O=3Dbuild2 DESTDIR=3Dinstall2=0A= =0A= Note: the default value of RTE_OUTPUT is set to $(RTE_SRCDIR)/build=0A= in mk/rte.sdkroot.mk=0A= =0A= We also need to to replace other occurences of $(BUILD_DIR), please=0A= see my comment on patch 2/7.=0A= =0A= =0A= [Mario]: Yes, you right, I can replace it :) =0A= =0A= > +INCLUDE_DIR ?=3D /usr/include/dpdk=0A= > +HSLINKS :=3D $(wildcard $(RTE_OUTPUT)/include/*)=0A= > +endif=0A= > endif=0A= >=0A= > #=0A= > @@ -72,7 +76,19 @@ install: $(INSTALL_TARGETS)=0A= > echo "Using local configuration"; \=0A= > fi=0A= > $(Q)$(MAKE) all O=3D$(BUILD_DIR)/$*=0A= > -=0A= > +#=0A= > +# install headers in /usr/include/dpdk by default=0A= > +# INCLUDE_DIR can be overridden.=0A= > +#=0A= > +.PHONY: install-headers=0A= > +install-headers:=0A= > + @echo =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Instal= ling headers;=0A= > + @[ -d $(DESTDIR)/$(INCLUDE_DIR) ] || mkdir -p $(DESTDIR)/$(INCLUDE_= DIR)=0A= =0A= I think it's useless to do the [ -d $(DESTDIR)/$(INCLUDE_DIR) ] as the=0A= 'mkdir -p' will do it as well.=0A= =0A= But maybe it could be useful to check:=0A= [ "$${HSLINKS}" !=3D "" ]=0A= This would solve the issue described by Panu about the directories=0A= created even if they are empty.=0A= =0A= [Mario]: Sounds good, that can solve the problem. =0A= =0A= > + @for HSLINK in ${HSLINKS}; do \=0A= =0A= Not sure to understand what is the meaning of HSLINK?=0A= HS =3D headers?=0A= =0A= [Mario]: HSLINKS=3D headers links, in dpdk installation, it creates links t= o headers, however for installation I would like=0A= to get the headers paths and copy them to installation path, not create lin= ks :) .=0A= =0A= Regards,=0A= Olivier=0A=