From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3D895567E for ; Thu, 3 Dec 2015 16:53:31 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 03 Dec 2015 07:52:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,378,1444719600"; d="scan'208";a="833571166" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 03 Dec 2015 07:52:09 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 3 Dec 2015 07:52:08 -0800 Received: from fmsmsx107.amr.corp.intel.com ([169.254.6.71]) by fmsmsx116.amr.corp.intel.com ([169.254.2.133]) with mapi id 14.03.0248.002; Thu, 3 Dec 2015 07:52:07 -0800 From: "Arevalo, Mario Alfredo C" To: Thomas Monjalon , Panu Matilainen Thread-Topic: [PATCH v2 00/12] standard make install Thread-Index: AQHRLYgBGKIEx8rGyEqiIcQtgk91jp65x3wAgAACOAD//5+VCw== Date: Thu, 3 Dec 2015 15:52:06 +0000 Message-ID: <6594B51DBE477C48AAE23675314E6C460F785185@fmsmsx107.amr.corp.intel.com> References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com> <1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com> <56604306.4080203@redhat.com>,<1688604.3zH5RcAOuN@xps13> In-Reply-To: <1688604.3zH5RcAOuN@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.19.9.46] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 00/12] standard make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 15:53:31 -0000 Hi Thomas,=0A= =0A= In general looks good :), I'm going to test this serie and sounds good the = feedback from other developers, maybe I'm going to send a version number 9 = in order to get a good way together :)=0A= =0A= Thanks :)=0A= Mario.=0A= ________________________________________=0A= From: Thomas Monjalon [thomas.monjalon@6wind.com]=0A= Sent: Thursday, December 03, 2015 5:34 AM=0A= To: Panu Matilainen; Arevalo, Mario Alfredo C=0A= Cc: dev@dpdk.org; olivier.matz@6wind.com; Richardson, Bruce=0A= Subject: Re: [PATCH v2 00/12] standard make install=0A= =0A= 2015-12-03 15:26, Panu Matilainen:=0A= > On 12/03/2015 07:01 AM, Thomas Monjalon wrote:=0A= > > Following the recent discussions, this is a proposal to have a standard= =0A= > > installation process while keeping compatibility with most of the old= =0A= > > behaviours.=0A= > >=0A= > > v2 changes:=0A= > > - fix default build dir=0A= > > - RTE_TARGET subdir in $(sdkdir).=0A= > > - better kerneldir defaults=0A= > > - fix dpdk_nic_bind symlink=0A= > > - always install doc if generated=0A= > > - doc=0A= > > - pkg/dpdk.spec=0A= > >=0A= >=0A= > Except for the minor nit about examples location (one could bikeshed on= =0A= > things like these forever), seems fine to me and quick-n-dirty=0A= > conversion of my own spec didn't reveal any nasty surprises.=0A= >=0A= > It also appears more comprehensive and integrated with other workflows=0A= > than the competing patches so FWIW, you have my ACK :)=0A= =0A= Thank you.=0A= I'm going to send a v3.=0A= Mario, what is your opinion about this series?=0A=