From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DF8E811F5 for ; Tue, 8 Dec 2015 00:22:43 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 07 Dec 2015 15:22:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,397,1444719600"; d="scan'208";a="868702830" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 07 Dec 2015 15:22:42 -0800 Received: from fmsmsx107.amr.corp.intel.com ([169.254.6.71]) by FMSMSX105.amr.corp.intel.com ([169.254.4.23]) with mapi id 14.03.0248.002; Mon, 7 Dec 2015 15:22:42 -0800 From: "Arevalo, Mario Alfredo C" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [PATCH v3 06/13] mk: split install rule Thread-Index: AQHRLdEg3Re3/1zs2UC4noiwYtLkz57AL6LJ Date: Mon, 7 Dec 2015 23:22:41 +0000 Message-ID: <6594B51DBE477C48AAE23675314E6C460F7860B2@fmsmsx107.amr.corp.intel.com> References: <1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com> <1449150340-21984-1-git-send-email-thomas.monjalon@6wind.com>, <1449150340-21984-7-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1449150340-21984-7-git-send-email-thomas.monjalon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.19.9.46] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 06/13] mk: split install rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 23:22:44 -0000 Hi Thomas,=0A= =0A= I'm testing this set of patches that has been applied, and I haven't notice= d before=0A= that you exclude some binaries in "install-runtime" (test, testpipeline, te= stacl etc...), I would like=0A= to ask you the reason about this :)=0A= =0A= Thanks.=0A= Mario. =0A= ________________________________________=0A= From: Thomas Monjalon [thomas.monjalon@6wind.com]=0A= Sent: Thursday, December 03, 2015 5:45 AM=0A= To: dev@dpdk.org=0A= Cc: olivier.matz@6wind.com; Arevalo, Mario Alfredo C; Richardson, Bruce; Pa= nu Matilainen=0A= Subject: [PATCH v3 06/13] mk: split install rule=0A= =0A= Provides new sub-rules to install runtime and sdk separately.=0A= =0A= The build directory must be changed from BUILD_DIR to O in install=0A= rules to avoid a bad recursive effect (O being BUILD_DIR being O + T).=0A= =0A= Suggested-by: Mario Carrillo =0A= Signed-off-by: Thomas Monjalon =0A= Acked-by: Panu Matilainen =0A= ---=0A= mk/rte.sdkinstall.mk | 18 ++++++++++++------=0A= mk/rte.sdkroot.mk | 2 ++=0A= 2 files changed, 14 insertions(+), 6 deletions(-)=0A= =0A= diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk=0A= index dc57baf..ec093d3 100644=0A= --- a/mk/rte.sdkinstall.mk=0A= +++ b/mk/rte.sdkinstall.mk=0A= @@ -93,25 +93,31 @@ ifeq ($(DESTDIR)$(if $T,,+),)=0A= @echo Installation cannot run with T defined and DESTDIR undefined= =0A= else=0A= @echo =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Instal= ling $(DESTDIR)$(prefix)/=0A= + $(Q)$(MAKE) O=3D$(RTE_OUTPUT) T=3D install-runtime=0A= + $(Q)$(MAKE) O=3D$(RTE_OUTPUT) T=3D install-sdk=0A= + @echo Installation in $(DESTDIR)$(prefix)/ complete=0A= +endif=0A= +=0A= +install-runtime:=0A= $(Q)$(call rte_mkdir, $(DESTDIR)$(libdir))=0A= - $(Q)cp -a $(RTE_OUTPUT)/lib/* $(DESTDIR)$(libdir)=0A= + $(Q)cp -a $O/lib/* $(DESTDIR)$(libdir)=0A= $(Q)$(call rte_mkdir, $(DESTDIR)$(bindir))=0A= - $(Q)tar -cf - -C $(RTE_OUTPUT) app --exclude 'app/*.map' \=0A= + $(Q)tar -cf - -C $O app --exclude 'app/*.map' \=0A= --exclude 'app/cmdline*' --exclude app/test \=0A= --exclude app/testacl --exclude app/testpipeline | \=0A= tar -xf - -C $(DESTDIR)$(bindir) --strip-components=3D1 \= =0A= --keep-newer-files --warning=3Dno-ignore-newer=0A= $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir))=0A= $(Q)cp -a $(RTE_SDK)/tools $(DESTDIR)$(datadir)=0A= +=0A= +install-sdk:=0A= $(Q)$(call rte_mkdir, $(DESTDIR)$(includedir))=0A= - $(Q)tar -chf - -C $(RTE_OUTPUT) include | \=0A= + $(Q)tar -chf - -C $O include | \=0A= tar -xf - -C $(DESTDIR)$(includedir) --strip-components=3D= 1 \=0A= --keep-newer-files --warning=3Dno-ignore-newer=0A= $(Q)$(call rte_mkdir, $(DESTDIR)$(sdkdir= ))=0A= $(Q)cp -a $(RTE_SDK)/{mk,scripts} $(DESTDIR)$(sdkdir= )=0A= $(Q)$(call rte_mkdir, $(DESTDIR)$(target= dir))=0A= - $(Q)cp -a $(RTE_OUTPUT)/.config $(DESTDIR)$(target= dir)=0A= + $(Q)cp -a $O/.config $(DESTDIR)$(target= dir)=0A= $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(target= dir)/include)=0A= $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(target= dir)/lib)=0A= - @echo Installation in $(DESTDIR)$(prefix)/ complete=0A= -endif=0A= diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk=0A= index 533afe9..2424dce 100644=0A= --- a/mk/rte.sdkroot.mk=0A= +++ b/mk/rte.sdkroot.mk=0A= @@ -97,6 +97,8 @@ test fast_test ring_test mempool_test perf_test coverage:= =0A= install:=0A= $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkinstall.mk pre_install=0A= $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkinstall.mk $@=0A= +install-%:=0A= + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkinstall.mk $@=0A= =0A= .PHONY: doc help=0A= doc: doc-all=0A= --=0A= 2.5.2=0A= =0A=