From: "Su, Simei" <simei.su@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix segmentation fault with a wrong package
Date: Tue, 12 Nov 2019 04:40:07 +0000 [thread overview]
Message-ID: <65F28F834D25B54B9EC1999B623071B30C4828BB@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191111090621.GE5870@intel.com>
Hi, xiaolong
> -----Original Message-----
> From: Ye, Xiaolong <xiaolong.ye@intel.com>
> Sent: Monday, November 11, 2019 5:06 PM
> To: Su, Simei <simei.su@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH v3] net/ice: fix segmentation fault with a wrong package
>
> Hi, simei
>
> On 11/07, Simei Su wrote:
> >This patch fixes core dump issue when entering safe mode with a wrong
> >ice.pkg. In safe mode, rte_flow is not supported and it won't
> >initialize any flow engine.
> >
> >Fixes: 7615a6895009 ("net/ice: rework for generic flow enabling")
> >
> >Signed-off-by: Simei Su <simei.su@intel.com>
> >---
> > drivers/net/ice/ice_ethdev.c | 13 ++++++++-----
> > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
> >diff --git a/drivers/net/ice/ice_ethdev.c
> >b/drivers/net/ice/ice_ethdev.c index d81eb5e..2a28d8e 100644
> >--- a/drivers/net/ice/ice_ethdev.c
> >+++ b/drivers/net/ice/ice_ethdev.c
> >@@ -2164,10 +2164,12 @@ static int ice_parse_devargs(struct rte_eth_dev
> *dev)
> > /* get base queue pairs index in the device */
> > ice_base_queue_get(pf);
> >
> >- ret = ice_flow_init(ad);
> >- if (ret) {
> >- PMD_INIT_LOG(ERR, "Failed to initialize flow");
> >- return ret;
> >+ if (!ad->is_safe_mode) {
> >+ ret = ice_flow_init(ad);
> >+ if (ret) {
> >+ PMD_INIT_LOG(ERR, "Failed to initialize flow");
> >+ return ret;
> >+ }
>
> Do we need to print out some message indicates that now ice is in safe mode?
>
We already have print info when ice is in safe mode. Thanks!
Br
Simei
> Thanks,
> Xiaolong
>
> > }
> >
> > ret = ice_reset_fxp_resource(hw);
> >@@ -2311,7 +2313,8 @@ static int ice_parse_devargs(struct rte_eth_dev
> >*dev)
> >
> > ice_dev_stop(dev);
> >
> >- ice_flow_uninit(ad);
> >+ if (!ad->is_safe_mode)
> >+ ice_flow_uninit(ad);
> >
> > /* release all queue resource */
> > ice_free_queues(dev);
> >--
> >1.8.3.1
> >
next prev parent reply other threads:[~2019-11-12 4:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 7:08 [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init Simei Su
2019-11-06 8:26 ` [dpdk-dev] [PATCH v2] " Simei Su
2019-11-06 16:10 ` Stillwell Jr, Paul M
2019-11-07 1:06 ` Su, Simei
2019-11-07 5:47 ` [dpdk-dev] [PATCH v3] net/ice: fix segmentation fault with a wrong package Simei Su
2019-11-07 6:14 ` Zhang, Qi Z
2019-11-11 9:06 ` Ye Xiaolong
2019-11-12 4:40 ` Su, Simei [this message]
2019-11-13 2:07 ` Ye Xiaolong
2019-11-06 16:03 ` [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init Stillwell Jr, Paul M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65F28F834D25B54B9EC1999B623071B30C4828BB@SHSMSX104.ccr.corp.intel.com \
--to=simei.su@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).