From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EB0FA04B7; Tue, 12 Nov 2019 05:40:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 261B9271; Tue, 12 Nov 2019 05:40:14 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 642ABA3 for ; Tue, 12 Nov 2019 05:40:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 20:40:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,295,1569308400"; d="scan'208";a="213953322" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 11 Nov 2019 20:40:10 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 20:40:10 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 20:40:10 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0439.000; Tue, 12 Nov 2019 12:40:08 +0800 From: "Su, Simei" To: "Ye, Xiaolong" CC: "Zhang, Qi Z" , "Yang, Qiming" , "dev@dpdk.org" Thread-Topic: [PATCH v3] net/ice: fix segmentation fault with a wrong package Thread-Index: AQHVlS7XcY43icoD+ky8vZFHR+r+Q6eFLheAgAHMv0A= Date: Tue, 12 Nov 2019 04:40:07 +0000 Message-ID: <65F28F834D25B54B9EC1999B623071B30C4828BB@SHSMSX104.ccr.corp.intel.com> References: <1573028777-185130-1-git-send-email-simei.su@intel.com> <1573105623-231389-1-git-send-email-simei.su@intel.com> <20191111090621.GE5870@intel.com> In-Reply-To: <20191111090621.GE5870@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDIzZDI1ZGYtMDM5MC00MjA2LWIwNDItMzAxMjM4NTQ1OGNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNXdFOVF3WGxPZXJtRGNUNHhvMGRGbkM0U1dKblBGazZDTVo0SkV4Ymx3cEwwUloyS3ljakNSNFByek11cDY3YSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix segmentation fault with a wrong package X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, xiaolong > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, November 11, 2019 5:06 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org > Subject: Re: [PATCH v3] net/ice: fix segmentation fault with a wrong pack= age >=20 > Hi, simei >=20 > On 11/07, Simei Su wrote: > >This patch fixes core dump issue when entering safe mode with a wrong > >ice.pkg. In safe mode, rte_flow is not supported and it won't > >initialize any flow engine. > > > >Fixes: 7615a6895009 ("net/ice: rework for generic flow enabling") > > > >Signed-off-by: Simei Su > >--- > > drivers/net/ice/ice_ethdev.c | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > >diff --git a/drivers/net/ice/ice_ethdev.c > >b/drivers/net/ice/ice_ethdev.c index d81eb5e..2a28d8e 100644 > >--- a/drivers/net/ice/ice_ethdev.c > >+++ b/drivers/net/ice/ice_ethdev.c > >@@ -2164,10 +2164,12 @@ static int ice_parse_devargs(struct rte_eth_dev > *dev) > > /* get base queue pairs index in the device */ > > ice_base_queue_get(pf); > > > >- ret =3D ice_flow_init(ad); > >- if (ret) { > >- PMD_INIT_LOG(ERR, "Failed to initialize flow"); > >- return ret; > >+ if (!ad->is_safe_mode) { > >+ ret =3D ice_flow_init(ad); > >+ if (ret) { > >+ PMD_INIT_LOG(ERR, "Failed to initialize flow"); > >+ return ret; > >+ } >=20 > Do we need to print out some message indicates that now ice is in safe mo= de? >=20 We already have print info when ice is in safe mode. Thanks! Br Simei > Thanks, > Xiaolong >=20 > > } > > > > ret =3D ice_reset_fxp_resource(hw); > >@@ -2311,7 +2313,8 @@ static int ice_parse_devargs(struct rte_eth_dev > >*dev) > > > > ice_dev_stop(dev); > > > >- ice_flow_uninit(ad); > >+ if (!ad->is_safe_mode) > >+ ice_flow_uninit(ad); > > > > /* release all queue resource */ > > ice_free_queues(dev); > >-- > >1.8.3.1 > >