Re: [PATCH] vdpa/mlx5: fix return value check of mkey create

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 11/12/21 15:42, Bing Zhao wrote:
> The return value of "mlx5_os_wrapped_mkey_create" is checked in the
> caller. A zero means success without any error.
> 
> The typo in the if-condition should be fixed in case there is a
> misjudgment.
> 
> Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR creation")
> 
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>   drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> index e65e4faa47..43a2b98255 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> @@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv *priv, uint64_t log_base,
>   					      (void *)(uintptr_t)log_base,
>   					      log_size, &priv->lm_mr);
>   
> -	if (!ret) {
> +	if (ret) {
>   		DRV_LOG(ERR, "Failed to allocate wrapped MR for lm.");
>   		return -1;
>   	}
> 

Applied to dpdk-next-virtio/main with Fixes tag fixed.

Thanks,
Maxime