From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80867A04DD; Wed, 28 Oct 2020 13:33:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAE9ACA62; Wed, 28 Oct 2020 13:33:28 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by dpdk.org (Postfix) with ESMTP id 1A0FDCA16 for ; Wed, 28 Oct 2020 13:33:27 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8D90F7F518; Wed, 28 Oct 2020 15:33:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8D90F7F518 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1603888405; bh=WuawkdhsEP1D12JI/7sWOFxw2x/QQpvpnqPe9s0NTwo=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=w4f/QiAqJ3qJCCzoAydNip31h01/ZibgbgLCGpdbSagKjrEwiOHBky+Y7DPw7tER4 n7kZ95b4U7OscbZErEk/hCZ4wPcJyhCwGNFd1ELze9q+Dhbink8nCk4MnNn6bTaR5f IQ+30wW1Sm+S4NH496qslAq99PrhoNiWi1rdVBb0= To: Raslan Darawsheh , Gregory Etelson , "dev@dpdk.org" , "ferruh.yigit@intel.com" Cc: Matan Azrad , Eli Britstein , Oz Shlomo , Shahaf Shuler , Slava Ovsiienko References: <20200625160348.26220-1-getelson@mellanox.com> <20201027161226.24041-1-getelson@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <65c4c19f-bd0a-77f5-2b29-eafbf993706c@oktetlabs.ru> Date: Wed, 28 Oct 2020 15:33:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: tunnel offload code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/20 8:16 PM, Raslan Darawsheh wrote: > Hi, > >> -----Original Message----- >> From: Gregory Etelson >> Sent: Tuesday, October 27, 2020 6:12 PM >> To: dev@dpdk.org >> Cc: Gregory Etelson ; Matan Azrad >> ; Raslan Darawsheh ; Eli Britstein >> ; Oz Shlomo ; Shahaf Shuler >> ; Slava Ovsiienko >> Subject: [PATCH] net/mlx5: tunnel offload code cleanup >> >> Remove unused reference to rte_hash structure from PMD tunnel offload >> code. >> > Added missing fixes line: > Fixes: dc67aa65c698 ("net/mlx5: implement tunnel offload API") > >> Signed-off-by: Gregory Etelson >> --- >> drivers/net/mlx5/mlx5.h | 1 - >> drivers/net/mlx5/mlx5_flow.c | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h >> index 09026288fc..88bbd316f0 100644 >> --- a/drivers/net/mlx5/mlx5.h >> +++ b/drivers/net/mlx5/mlx5.h >> @@ -648,7 +648,6 @@ struct mlx5_dev_ctx_shared { >> /* UAR same-page access control required in 32bit implementations. >> */ >> #endif >> struct mlx5_hlist *flow_tbls; >> - struct rte_hash *flow_tbl_map; /* app group-to-flow table map */ >> struct mlx5_flow_tunnel_hub *tunnel_hub; >> /* Direct Rules tables for FDB, NIC TX+RX */ >> void *esw_drop_action; /* Pointer to DR E-Switch drop action. */ >> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c >> index 02e19e83ae..082d886c74 100644 >> --- a/drivers/net/mlx5/mlx5_flow.c >> +++ b/drivers/net/mlx5/mlx5_flow.c >> @@ -19,7 +19,6 @@ >> #include >> #include >> #include >> -#include >> >> #include >> #include >> -- >> 2.28.0 > > Patch applied to next-net-mlx, > @ferruh.yigit@intel.com, > Can you kindly squash it into relevant commit in next-net ? Done, squashed it into relevant commit in next-net/main, thanks.