From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1EEB929CA for ; Thu, 7 Dec 2017 22:02:21 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 13:02:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,374,1508828400"; d="scan'208";a="10005365" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.165]) ([10.241.225.165]) by FMSMGA003.fm.intel.com with ESMTP; 07 Dec 2017 13:02:20 -0800 To: Jasvinder Singh , dev@dpdk.org Cc: cristian.dumitrescu@intel.com References: <20171130200843.98621-1-jasvinder.singh@intel.com> From: Ferruh Yigit Message-ID: <65d69e3e-dfee-1c25-23d9-a8265e59e7ea@intel.com> Date: Thu, 7 Dec 2017 13:02:19 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171130200843.98621-1-jasvinder.singh@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 21:02:22 -0000 On 11/30/2017 12:08 PM, Jasvinder Singh wrote: > This patchset extends the softnic device by implementing > the software fallback for flow classification as defined > using Flow APIs. When feature is enabled, softnic classifies > and executes actions on the received packets based on flow > rules specified using rte_flow.h. > > The motivation behind this feature is to implement metering > and policing function in softnic which requires each flow to > be classified at the preceding stage of the packet processing > pipeline. Another aspect is to support classification of the > greater number of flows (For e.g. 64K) which is not feasible > in some hardware due to resource limitation such as memory, etc. > > This feature, inherently, uses the abstraction provided by dpdk > librte_table library to create hash table for classification, > and allows users to validate, add and delete flow rules. Current > version does not implement all functions and will be completed > in the next version. > > Jasvinder Singh (2): > net/softnic: add flow classification support > net/softnic: add flow classification ops Hi Jasvinder, I was about to ask adding documentation for "software fallback for flow classification" but it seems there is no documentation at all for softnic, it seems we missed it, and softnic is a complex PMD which requires some documentation I believe. Can you please add documentation including new flow classification fallback info? And I am getting some build errors [1][2]. Thanks, ferruh [1] .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c:558:3: error: implicit conversion from enumeration type 'enum rte_tm_error_type' to different enumeration type 'enum rte_flow_error_type' [-Werror,-Wenum-conversion] RTE_TM_ERROR_TYPE_UNSPECIFIED, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c:577:3: error: implicit conversion from enumeration type 'enum rte_tm_error_type' to different enumeration type 'enum rte_flow_error_type' [-Werror,-Wenum-conversion] RTE_TM_ERROR_TYPE_UNSPECIFIED, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c:596:3: error: implicit conversion from enumeration type 'enum rte_tm_error_type' to different enumeration type 'enum rte_flow_error_type' [-Werror,-Wenum-conversion] RTE_TM_ERROR_TYPE_UNSPECIFIED, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [2] .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c: In function ‘pmd_flow_create’: .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c:584:2: error: argument 1 null where non-null expected [-Werror=nonnull] memcpy((void *)f->pattern, (const void *)pattern, sizeof(*f->pattern)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~