From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id AE01A1CB59 for ; Sat, 7 Apr 2018 11:24:01 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 4AD41A8006C; Sat, 7 Apr 2018 09:24:00 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 7 Apr 2018 10:23:55 +0100 To: Adrien Mazarguil , Thomas Monjalon , Ferruh Yigit , References: <20180404150312.12304-1-adrien.mazarguil@6wind.com> <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180406131736.19145-5-adrien.mazarguil@6wind.com> From: Andrew Rybchenko Message-ID: <65f2e0f3-14e4-bbf1-d64d-f7596517ef6b@solarflare.com> Date: Sat, 7 Apr 2018 12:23:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180406131736.19145-5-adrien.mazarguil@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23768.003 X-TM-AS-Result: No--11.326100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523093041-zlQg5Sj036Ul Subject: Re: [dpdk-dev] [PATCH v2 04/15] ethdev: remove DUP action from flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Apr 2018 09:24:01 -0000 On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > Upcoming changes in relation to the handling of actions list will make the > DUP action redundant as specifying several QUEUE actions will achieve the > same behavior. Besides, no PMD implements this action. > > By removing an entry from enum rte_flow_action_type, this patch breaks ABI > compatibility for the following public functions: > > - rte_flow_copy() > - rte_flow_create() > - rte_flow_query() > - rte_flow_validate() > > Signed-off-by: Adrien Mazarguil > --- > app/test-pmd/cmdline_flow.c | 23 ----------------------- > app/test-pmd/config.c | 1 - > doc/guides/prog_guide/rte_flow.rst | 23 ----------------------- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 -------- > lib/librte_ether/rte_ethdev_version.map | 2 +- > lib/librte_ether/rte_flow.c | 1 - > lib/librte_ether/rte_flow.h | 24 ------------------------ > 7 files changed, 1 insertion(+), 81 deletions(-) Acked-by: Andrew Rybchenko