From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan
Date: Tue, 10 Oct 2017 14:49:21 +0530 [thread overview]
Message-ID: <65f378cb-2229-36d5-418a-1fedf9435cb0@nxp.com> (raw)
In-Reply-To: <2102754.igz1rhL23C@xps>
On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote:
> 10/10/2017 09:01, Shreyansh Jain:
>> Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations")
>> Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup")
>
> These lines should appear after the explanation.
Ok. That I missed - I will fix and send updated patch.
>
>> Cc: shreyansh.jain@nxp.com
>>
>> With the IOVA auto detection changes, bus scan is performed before
>> memory initialization. DPAA bus scan must not use rte_malloc in
>> its path.
>
> If the scan has been broken by IOVA detection, you should reference
> IOVA in Fixes line, not DPAA.
I was of two minds before sending this patch with above Fixes lines:
This change is because of IOVA but at the time IOVA patch was
introduced, this bus was not part of master. So, ideally, in the
net-next itself the integration should have been with fixed code - but,
I ended up verifying base patches without IOVA patches (some earlier
snapshot of net-next).
Anyways, I will send another patch with IOVA as fix line.
next prev parent reply other threads:[~2017-10-10 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 7:01 Shreyansh Jain
2017-10-10 7:39 ` Thomas Monjalon
2017-10-10 9:19 ` Shreyansh Jain [this message]
2017-10-10 14:05 ` santosh
2017-10-10 16:17 ` Thomas Monjalon
2017-10-10 16:55 ` santosh
2017-10-11 5:17 ` Shreyansh Jain
2017-10-11 5:23 ` santosh
2017-10-10 9:34 ` [dpdk-dev] [PATCH v2] " Shreyansh Jain
2017-10-10 13:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65f378cb-2229-36d5-418a-1fedf9435cb0@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).