From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "Breen, Eoin" <eoin.breen@intel.com>,
dev@dpdk.org, "Jain, Deepak K" <deepak.k.jain@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"Griffin, John" <john.griffin@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc/guides: add info on how to enable QAT
Date: Tue, 30 Aug 2016 16:50:25 +0200 [thread overview]
Message-ID: <6602025.TFsYvFOpoj@xps13> (raw)
In-Reply-To: <1B14A3D5-1244-4B28-94B9-FDB53E9C5052@intel.com>
2016-08-30 13:57, Wiles, Keith:
> > 2016-08-30 14:26, Eoin Breen:
> >> --- a/doc/guides/cryptodevs/qat.rst
> >> +++ b/doc/guides/cryptodevs/qat.rst
> >> @@ -78,6 +78,11 @@ Installation
> >> To use the DPDK QAT PMD an SRIOV-enabled QAT kernel driver is required. The
> >> VF devices exposed by this driver will be used by QAT PMD.
> >>
> >> +To enable QAT in DPDK you must change the ./config/common_base file. Change the
> >> +line 'CONFIG_RTE_LIBRTE_PMD_QAT=n' to 'CONFIG_RTE_LIBRTE_PMD_QAT=y' to do this.
> >
> > No, the recommended way is to change the value in the generated config
> > file (.config).
>
> The way I have been changing the default configuration options is to copy the config/defconfig_XYZ file like defconfig_x86_64-native-linuxapp-gcc to a new name say defconfig-x86_64-qat-linuxapp-gcc. Then edit that file and add the CONFIG_RTE_LIBRTE_PMD_QAT=y to the bottom of the file. Then ‘make install T=x86_64-qat-linuxapp-gcc -j’.
>
> Is this not a better way to build a new configuration for a specific reason?
Yes you can also build your own defconfig.
I think it is better to stick to simply change the generated file between
"make config" and "make" for the documentation.
next prev parent reply other threads:[~2016-08-30 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 13:26 Eoin Breen
2016-08-30 13:46 ` Thomas Monjalon
2016-08-30 13:57 ` Wiles, Keith
2016-08-30 14:50 ` Thomas Monjalon [this message]
2016-09-12 14:18 ` Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6602025.TFsYvFOpoj@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=eoin.breen@intel.com \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
--cc=john.mcnamara@intel.com \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).