From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Harman Kalra <hkalra@marvell.com>
Cc: dev@dpdk.org, David Hunt <david.hunt@intel.com>,
liang.j.ma@intel.com, reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH 3/3] l3fwd-power: add interrupt-only mode
Date: Fri, 29 May 2020 15:19:45 +0100 [thread overview]
Message-ID: <660267ae-00a0-bb55-fbc3-9ac1473957ea@intel.com> (raw)
In-Reply-To: <20200529131955.GA83122@outlook.office365.com>
On 29-May-20 2:19 PM, Harman Kalra wrote:
>> if (ret < 0)
>> rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
>>
>> - if (app_mode != APP_MODE_TELEMETRY && init_power_library())
>> + if (app_mode == APP_MODE_DEFAULT)
>> + app_mode = APP_MODE_LEGACY;
>> +
>> + /* only legacy and empty poll mode rely on power library */
>> + if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&
>> + init_power_library())
>> rte_exit(EXIT_FAILURE, "init_power_library failed\n");
>>
> Hi,
>
> Rather than just exiting from here can we have a else condition to
> automatically enter into the "interrupt only" mode.
> Please correct me if I am missing something.
Hi,
Thanks for your review. I don't think silently proceeding is a good
idea. If the user wants interrupt-only mode, they should request it.
Silently falling back to interrupt-only mode will create an illusion of
successful initialization and set the wrong expectation for how the
application will behave.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2020-05-29 14:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 9:13 [dpdk-dev] [PATCH 0/3] Add interrupt-only mode to l3fwd-power Anatoly Burakov
2020-05-28 9:13 ` [dpdk-dev] [PATCH 1/3] l3fwd-power: disable interrupts by default Anatoly Burakov
2020-05-28 9:13 ` [dpdk-dev] [PATCH 2/3] l3fwd-power: only allow supported power library envs Anatoly Burakov
2020-05-28 9:13 ` [dpdk-dev] [PATCH 3/3] l3fwd-power: add interrupt-only mode Anatoly Burakov
2020-05-29 13:19 ` Harman Kalra
2020-05-29 14:19 ` Burakov, Anatoly [this message]
2020-05-30 10:02 ` [dpdk-dev] [EXT] " Harman Kalra
2020-06-01 12:50 ` Burakov, Anatoly
2020-06-02 10:23 ` Harman Kalra
2020-06-02 12:16 ` Harman Kalra
2020-06-15 11:31 ` Burakov, Anatoly
2020-06-15 11:43 ` Jerin Jacob
2020-06-15 15:05 ` Burakov, Anatoly
2020-06-15 15:21 ` Jerin Jacob
2020-06-15 15:45 ` Burakov, Anatoly
2020-06-15 16:29 ` Jerin Jacob
2020-06-16 9:31 ` Burakov, Anatoly
2020-06-16 17:09 ` Jerin Jacob
2020-06-08 1:24 ` [dpdk-dev] [PATCH 0/3] Add interrupt-only mode to l3fwd-power Wang, Yinan
2020-06-18 17:18 ` [dpdk-dev] [PATCH v2 0/7] " Anatoly Burakov
2020-06-19 10:53 ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2020-07-11 11:35 ` Thomas Monjalon
2020-06-19 10:53 ` [dpdk-dev] [PATCH v3 1/7] l3fwd-power: disable interrupts by default Anatoly Burakov
2020-06-19 10:53 ` [dpdk-dev] [PATCH v3 2/7] l3fwd-power: only allow supported power library envs Anatoly Burakov
2020-06-19 10:53 ` [dpdk-dev] [PATCH v3 3/7] l3fwd-power: code style and flow fixes Anatoly Burakov
2020-06-19 10:53 ` [dpdk-dev] [PATCH v3 4/7] l3fwd-power: add support for requesting legacy mode Anatoly Burakov
2020-06-19 10:53 ` [dpdk-dev] [PATCH v3 5/7] l3fwd-power: add interrupt-only mode Anatoly Burakov
2020-06-19 10:53 ` [dpdk-dev] [PATCH v3 6/7] power: add API to probe support for a specific env Anatoly Burakov
2020-06-19 10:53 ` [dpdk-dev] [PATCH v3 7/7] l3fwd-power: add auto-selection of default mode Anatoly Burakov
2020-07-11 10:07 ` Thomas Monjalon
2020-06-18 17:18 ` [dpdk-dev] [PATCH v2 1/7] l3fwd-power: disable interrupts by default Anatoly Burakov
2020-06-18 17:18 ` [dpdk-dev] [PATCH v2 2/7] l3fwd-power: only allow supported power library envs Anatoly Burakov
2020-06-18 17:18 ` [dpdk-dev] [PATCH v2 3/7] l3fwd-power: code style and flow fixes Anatoly Burakov
2020-06-18 17:18 ` [dpdk-dev] [PATCH v2 4/7] l3fwd-power: add support for requesting legacy mode Anatoly Burakov
2020-06-18 17:18 ` [dpdk-dev] [PATCH v2 5/7] l3fwd-power: add interrupt-only mode Anatoly Burakov
2020-06-18 17:18 ` [dpdk-dev] [PATCH v2 6/7] power: add API to probe support for a specific env Anatoly Burakov
2020-06-18 17:18 ` [dpdk-dev] [PATCH v2 7/7] l3fwd-power: add auto-selection of default mode Anatoly Burakov
2020-06-19 7:37 ` [dpdk-dev] [EXT] " Harman Kalra
2020-06-19 9:56 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=660267ae-00a0-bb55-fbc3-9ac1473957ea@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=liang.j.ma@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).