From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6936BA0350; Fri, 29 May 2020 16:19:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F18A01DBD5; Fri, 29 May 2020 16:19:50 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9FB281DBD4 for ; Fri, 29 May 2020 16:19:49 +0200 (CEST) IronPort-SDR: QsVQzkdSABiy6zWAQc+VanNCdoXJtL3/VefHkUACHi+TkonNYlMxqkB1YgAh+9RFonGe5U7a1+ 82fFRcF+ufJQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2020 07:19:48 -0700 IronPort-SDR: TCA8o4IiVKjdunR0026lqrTsaBBnBURypnbp8gsg7i/eDX1+PdmX8OHieuX1i3HQkrP/oTdV25 vlKFdV7WBmPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,448,1583222400"; d="scan'208";a="285543929" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.230.89]) ([10.213.230.89]) by orsmga002.jf.intel.com with ESMTP; 29 May 2020 07:19:46 -0700 To: Harman Kalra Cc: dev@dpdk.org, David Hunt , liang.j.ma@intel.com, reshma.pattan@intel.com References: <20200529131955.GA83122@outlook.office365.com> From: "Burakov, Anatoly" Message-ID: <660267ae-00a0-bb55-fbc3-9ac1473957ea@intel.com> Date: Fri, 29 May 2020 15:19:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200529131955.GA83122@outlook.office365.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/3] l3fwd-power: add interrupt-only mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29-May-20 2:19 PM, Harman Kalra wrote: >> if (ret < 0) >> rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n"); >> >> - if (app_mode != APP_MODE_TELEMETRY && init_power_library()) >> + if (app_mode == APP_MODE_DEFAULT) >> + app_mode = APP_MODE_LEGACY; >> + >> + /* only legacy and empty poll mode rely on power library */ >> + if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) && >> + init_power_library()) >> rte_exit(EXIT_FAILURE, "init_power_library failed\n"); >> > Hi, > > Rather than just exiting from here can we have a else condition to > automatically enter into the "interrupt only" mode. > Please correct me if I am missing something. Hi, Thanks for your review. I don't think silently proceeding is a good idea. If the user wants interrupt-only mode, they should request it. Silently falling back to interrupt-only mode will create an illusion of successful initialization and set the wrong expectation for how the application will behave. -- Thanks, Anatoly