From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59DD742C02; Thu, 1 Jun 2023 12:24:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27665406B3; Thu, 1 Jun 2023 12:24:37 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2065.outbound.protection.outlook.com [40.107.220.65]) by mails.dpdk.org (Postfix) with ESMTP id 97711406A2 for ; Thu, 1 Jun 2023 12:24:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oy5H+64TA58M1BKOQQymzv1UQ2QU+CVTr8TY1S1/jo/QZJIuKneYrLeGpN5G+HXc9KxfwmoAJhZ5MBT2fecpOObHTaYEKqa7hTR2dOsVRdageoww7rf/yYDiVZTW2FRghiQ1SRq6sFIFz/m/Yv06e+Fj7CQIQdd0xMVMLL3YugfBExvx2Da+1LhMqHzuQk6mWykC72w2mmRjnHDVQ6w/oIXK6xiFA2Ko1hp/zc0HwSTv1/PrYlJ2Y+4OIDeZmjqBJy+3ztnsS+nrkg9qgIuruDBKMwJVLCY8j64L+HA0+FHGyqNAtgu1CdB4DEzEKXHVe1HkUTvj369adyBJchtouA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ITqsLKfFqPDRW0t59MnpaTh7+WrGL2h5fnf8AfGVnyE=; b=MED09ju+L3kloclVQYxCfNXwuO8GJ8fam4BmTXoWjV1IFP1eavaO4t+GL81XDU6P2tuJYA6f1wnp9pQK1wSEJZBjV7DU3+2wio0Jn6l9KJOZkM5cAeseQ/QiEZywjPPX3TWM6QhWuyPs2DHi0IBAzYBmS/E5UeDyoXAh6ax9stYoIslNwuWZgrRqiRgr8Tk3L9grAeUcVwZaTrb6Dz6Fnu6yNq/D1t95LmG8Mg0yVnW3/rtAqyzBXrUbzUKKICa6AhJiwXskkl5y1xJ2gigJnMVxCqhSo+VrVtQdoA/xTzvUnNe+8zmJVyuWawoG31yfoAMcijjH+VsV+PtEuW4RPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ITqsLKfFqPDRW0t59MnpaTh7+WrGL2h5fnf8AfGVnyE=; b=VDv0fTXCh6qKYxtOk7P8XuC93cTfPJTpqQ91sKEBZfdsZ+qmyFTSnjL7qhNFT/D7JfEVaAPsTCSVlbrUapr/hJT1s0vtswhh0YKMm+PrxUNKAe/xY6PMdbuGJsXbPHOPjrsp8c18MohSJMZf/YaNYMTQ1gkvSStjZi0Y8w+04oE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6551.namprd12.prod.outlook.com (2603:10b6:930:41::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Thu, 1 Jun 2023 10:24:33 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6433.022; Thu, 1 Jun 2023 10:24:33 +0000 Message-ID: <660baf37-53e9-6274-1cef-9beea3f69f8c@amd.com> Date: Thu, 1 Jun 2023 11:24:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility Content-Language: en-US From: Ferruh Yigit To: Rushil Gupta , qi.z.zhang@intel.com Cc: junfeng.guo@intel.com, dev@dpdk.org References: <20230601031513.453016-1-rushilg@google.com> <20230601044950.465926-1-rushilg@google.com> <859b86f2-888f-b60b-b10e-d83d3a37fe7e@amd.com> In-Reply-To: <859b86f2-888f-b60b-b10e-d83d3a37fe7e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0405.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::33) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6551:EE_ X-MS-Office365-Filtering-Correlation-Id: 681ee8f7-d4b4-469a-8e76-08db628a640b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3YeYVk85vRt6MsCIL5nqBA7yhIIPMiwCnaeIxhNXJN5sIR0bzqjg1A5B9GbsrTIZ7ARcUyUiWQp5BsVfQFCZFzQ7z76ch6UcG4UGA0qbb/T8TwxrxWAi5ZapJrpIbqDcJG8kFU/PDiO+mw5O8UI+ZV+opFcvnaJnJlZZMPRQNLF0O9lyT6hMOwqZR+GVr1bB2hAAYcADA2pfgwxuIbBqUZOY8UsQY3oNn4pQlSi4ch+N+O0thS/qq3C+0QZeJd9O5CFJvPFNgPk2SXo9g85s4ZO3WTYPQD4dmpRpk2mm6B2AcUr5DKdcb7SoOvIu/4pXSS5YFFPWWe6y/nifW9qBdbgoa/h/CFA/R9p7gxv1gAf8Va8HazorBi1pWvzM4Qzz4N2xh7En1xn8fjpMYH8OsIe5fKHN+TCBIttphlBKu9UxtpkGowYjZYJ6hMWCp33T3wNjbY6VgkV2/sdq7e03qXKsmyxuLLpQHQy8ZzUSdX3MVM15YKAMdysbVj+aSdImRJkZrKkDZq8VNyJZawaFUV8vozjAaTDUgqKiZCoxXwPB4SWW/Q6umGE8BkwN5b/X44CyAU6fJsOESw/qdP9064xXfw6Ho7vBikc4RwXvKDaqPZeJAJkTsAr3nC5NmqBP25oIw7tR4xFTLWX6IAoz4w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199021)(478600001)(8936002)(44832011)(8676002)(5660300002)(36756003)(2906002)(86362001)(15650500001)(31696002)(66476007)(66946007)(4326008)(66556008)(316002)(41300700001)(38100700002)(2616005)(186003)(6512007)(53546011)(26005)(6506007)(6486002)(6666004)(31686004)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nyt5YUNsdlJoS3Y3RHQ3TGF2aVNqdFRjRE1JMThWanFLZ0tSOG9HNEx1SVhw?= =?utf-8?B?TmdodEgzTkxSaXE5czZJV0dPeFd3NWZhT0lpTEU0NlpMUENvb2IrWlYrbUF2?= =?utf-8?B?b2xoY21VTUN2K3d1QXFIaDJCZm12dTVtc3U5eENmOFAycmFMRGcreU1HYjUz?= =?utf-8?B?RzJPZ2tJZnJHa2IyLzdCU1lid0xSNU9VR3hTRjJ2WjQ4OVdnVUU1aE5nS1NI?= =?utf-8?B?RDRWdUpoQjVnZ1VXb1BaUkg5aGc3ZzR6dC9pMjhYL3RkU3FTWjNtZTlWbDNN?= =?utf-8?B?c2pKUDNzN1FMOEl3RW44UWpiUVk3ODJzcnhXN3p3eEVnWVFsK2YwYVh3R2lv?= =?utf-8?B?aS9uR0F6ZEI5a0NVTkZaUWFnNmlRd0RqbnVDYlRZM0g4UjB3U2diVXRwb241?= =?utf-8?B?bkNJREkxSEIvOWQwcy9oSDFBckFtSitjRW95TGlQYVpCeTVTdlREMGpxM21P?= =?utf-8?B?bGIxNUtranhUNnc4ekgvNUVQbnFodk54bkdZOHowMGRtRDRxZ3BqNldGTkUw?= =?utf-8?B?ZnFiOUQ2c252Z0I3cVdXa0E4ZU9ZaWFERVVNOTlaa3hraUNzTUlvL2ZEeVR3?= =?utf-8?B?NTRlc2ViTko5ampRMTdUYlJmMnI3MU5pWWF1TzlpQkkyeHplUUhJd1hsNjVs?= =?utf-8?B?VGZxSlh0NDhoVVdsbEtoSDQ4dHVTWGQwZG8rV24xWVZCaURPZy9KVkkwbEh0?= =?utf-8?B?L0dmbUt1bjhIdzk2ZTl6ZGxHOWUvUlNDeEZGRVRCUFpta1BkT0N6V1hIQTgx?= =?utf-8?B?dTB4WWRHR3B4Vm1nT09xNU1BSVhqTWdqNXdRQnQwT3lOZjNLQmg2QThaSi80?= =?utf-8?B?OEF2eGR2WjA5alBKTTBXMkhtWElOK0ZVYjNPb0NwTHFSckVOUVZIbWlhKzk2?= =?utf-8?B?SFFuaWx4RUZ5c2xLU2VDYlBUWFJjZFNKM0kxOXZCSGlGUkdUaXdIK0dCZGVS?= =?utf-8?B?Wmo3RTlUdUNPaHNRV2dSUm5COWg2Q21nYkV6VjlWS2UrOUErb01XK1MySHZ2?= =?utf-8?B?cHA4YlVoUFFoZERSYnhQcXR5Rmg0OXBzTk1Ib1k3Mi9nSksxMFcvOXcraVEy?= =?utf-8?B?YXVsdUQxRUtVQjNSUWx6YTZOamdvUW9jY1FPRWZaN0h3SVhmWTFqNHBKUUpT?= =?utf-8?B?Ymlld0xPTVFzS3BidGpuMTNSK3dzNm1Ja2gzZ3FkbXFKV2U2RFlhWUI0THdO?= =?utf-8?B?SncxSFBNS29wSks0MUFnZ0FPa1JtTk1EVmhKdWkyWk9INE9HYkJOcjExUVBr?= =?utf-8?B?a1grSTlKN3EwQlI3YWxYQk00c29HZVg2RDVWUUtnM0hpVHlWYVlncVRrQjgy?= =?utf-8?B?aXhadHo0TkV5TWQ1V01VajhSYWpOSG4wdnBvY21aN2lhcVh2MDJtc3F1K1BO?= =?utf-8?B?SkdiN1RCM0UyeVYyUnE2N1RTV0kvNEQrNmF2cThlSE9nTVgxM1JRaDJYazJx?= =?utf-8?B?QXcvTVQyQkZKNkYySHZ0R0thd2tmb0ovdW1COGd4a0NHQk9zR3o2WGF5a3FK?= =?utf-8?B?RlNVR2F3MUdXQnhUSkVYZDJubjBVQ1g5a0pwRXhVTStkeU9zdkVlL2NRSVBB?= =?utf-8?B?cjU0OURVQXVTNXd1VVErWDRpU1N1bmd4UWU2Ty9xbEVkWlV3aUdUS0xyajVw?= =?utf-8?B?WFFaVjZvcHZmcjRGb0Rvd0R1SmxIcWNpZnlxL3oyZTc5NC9IOGltWDg1eTlV?= =?utf-8?B?dUtPR2pMUzJFM3Evalp1U1JkNXNZRVFIQUZ1aFdCenE4YTZMY2srRTR5bURq?= =?utf-8?B?WlZrTTh5aytqMGd6YXZONlBVUFVnaWxIanluNmFSdnBPT3lhSUpuZjRWMDho?= =?utf-8?B?ZEZyYW9kL0V4dUhhU1BkYk5jSitPbzZjZWw2dHFkN0pPYXo1TXVGeWp0YWxQ?= =?utf-8?B?R01icUhUQlEzdzZXaHZqWTd2UWxaT1E2T0JxYmVtdS9aVUxYYlh0bEd4MmZ2?= =?utf-8?B?UVhZNnkzc3NNK0tmMWJNOVZJNTBZU0UxS2dpUjVEcHU2MExwZFdwMGZtNm93?= =?utf-8?B?NXhRTThyU043SGpLdjQvOVZhK3NURnRSY3dPcmVWTXZKdEN1MzczZDh2YzlV?= =?utf-8?B?c1hLT2JYT1UrNFU0NWpld2dBZzkxcTBicGZhSmNIa25WMUkwUEVEeTlPUzlF?= =?utf-8?Q?tWl8Y5zy/ZLSyyLx4LWV6Ye1N?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 681ee8f7-d4b4-469a-8e76-08db628a640b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 10:24:32.8878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ub5jXNLDSPAO6zqCICeYvhU/XgUsDXJYz3Y2x7XJiGf7l1mgQhNMi+5tNu3c9u8w X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6551 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/1/2023 9:26 AM, Ferruh Yigit wrote: > On 6/1/2023 5:49 AM, Rushil Gupta wrote: >> gVNIC requires physical address to be passed in the adminq command. >> This was initially rightly pointed by ferruh.yigit@. >> Fixed by passing 'driver_info_mem->iova'. >> >> Signed-off-by: Rushil Gupta >> --- >> drivers/net/gve/gve_ethdev.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c >> index 2c1e73d07a..aa75abe102 100644 >> --- a/drivers/net/gve/gve_ethdev.c >> +++ b/drivers/net/gve/gve_ethdev.c >> @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *priv) >> (char *)driver_info->os_version_str2); >> >> err = gve_adminq_verify_driver_compatibility(priv, >> - sizeof(struct gve_driver_info), (dma_addr_t)driver_info); >> + sizeof(struct gve_driver_info), >> + (dma_addr_t)driver_info_mem->iova); >> > > Yep, this was my point, let me squashed onto original patch in next-net. > > Squashed into relevant commit in next-net, thanks. Can you please verify latest code in next-net?