From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f169.google.com (mail-wj0-f169.google.com [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id B84F1FB9B for ; Tue, 20 Dec 2016 16:12:00 +0100 (CET) Received: by mail-wj0-f169.google.com with SMTP id xy5so178315396wjc.0 for ; Tue, 20 Dec 2016 07:12:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=qjWKmpHasyRbGkelIedF3Zx74xIlG7CYTRKnO1Viark=; b=JUHMbPoQCbZ8P5A7L2QW2KcZrpNBeMokZMgi7Y0l5tQsOg+krGbGyNNOmBu5K82BNG YXCYcXGBT6YrIqFMjeioVgWmT0ueL2hwcNAVwdM1PcQM3cc1rSnLal7exFxZGBkT+Ang fqIde3PtLrCSvDV7rvaVLmmpgdqIYxhlPuQMfxb8lrwC6gag/HItPpZUFzt8VMQkp7Qj hatlT/JxyKTUnjoF1GIzyay+JnYCGI9OKoqypxXI306DC60Bjj1E3rRSoaBWOI13jLWu xcWXoosngiS3QhTjFgnvhC5KHDIpmoX4Wd9NbzaBatnzFCk0Vi6nSdZFc8TgFQmD6Wk0 iI/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=qjWKmpHasyRbGkelIedF3Zx74xIlG7CYTRKnO1Viark=; b=YW3MvcI5JfjImtksbpxGaWK/cuEki/5T2WvN3S9otp2i0XrF1vXKdZR5cGwsrjn1pS RntXV+zVL+KI9WiNvS6N/xqaqvIuPLk+mSijIhwNhXOgTSI+JGgnxfnoVYeTUdcn7rQV cRt4HzXplk/a9HdoJsK+ueo/rJZOrXdccovTp/0VIXZoP167iTbBMMEdC1R0RnwiHtCn +3lz/16XMjq3xDlBcanbOEbbrD2MSdAaBL/uRGGv6WT09u52XpayYcEBhMczvj6Kg1qU US+7dkN1VjnZSPchDb+cuuU2BeruEqTucX4d+P/a4tzMyeFBA65eViFtwO7iTHXmnJaw 5//A== X-Gm-Message-State: AIkVDXLcktafRJLwf09yVUi7BfviHfpFFkpIYH4BML1da5exe8yO+qvHiozaB3O266lqrjuq X-Received: by 10.194.58.52 with SMTP id n20mr18448512wjq.110.1482246720151; Tue, 20 Dec 2016 07:12:00 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w18sm22608819wme.9.2016.12.20.07.11.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Dec 2016 07:11:59 -0800 (PST) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Tue, 20 Dec 2016 16:11:58 +0100 Message-ID: <6618631.VEimddGDOM@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1480474049-3828-1-git-send-email-remy.horton@intel.com> References: <1480474049-3828-1-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] examples/ethtool: fix segfault querying non-PCI devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 15:12:00 -0000 2016-11-30 10:47, Remy Horton: > Doing a device information query on a non-PCI device such as > vhost was resulting in the dereferencing of a NULL pointer > (the absent PCI data), causing a segmentation fault. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") > > Signed-off-by: Remy Horton [...] > --- a/doc/guides/rel_notes/release_17_02.rst > +++ b/doc/guides/rel_notes/release_17_02.rst > @@ -70,6 +70,9 @@ Libraries > Examples > ~~~~~~~~ > > + * **examples/ethtool Fixed crash with non-PCI devices.** > + Querying a non-PCI device was dereferencing non-existent PCI data > + resulting in a segmentation fault. indentation fixed here Applied, thanks