From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30065.outbound.protection.outlook.com [40.107.3.65]) by dpdk.org (Postfix) with ESMTP id 1900B2BC9; Thu, 9 Aug 2018 19:38:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mnK6kbG0oFtO4TSTesc3if6XlFSgHkVEuv0lynjlJIE=; b=x2eqXz9GXHGaE6RHGaPW7VcHxCAdS6jhHec7HR4m2IMwaDgOIp3eBkmBJhjTFczGR+RfX85BR4ctMFxTaDlRNG3RMCEzBd+I+3ZInh+l3LqnFQ8lroQPUAiNFm+JfM8G9+k9JS1lb+o679NXdl5E1k6dlHVW/fa8G7ZRWHJ6BTk= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4012.eurprd05.prod.outlook.com (52.134.72.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Thu, 9 Aug 2018 17:38:08 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::112:180c:634a:c61c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::112:180c:634a:c61c%2]) with mapi id 15.20.1017.019; Thu, 9 Aug 2018 17:38:08 +0000 From: Yongseok Koh To: Bruce Richardson CC: Thomas Monjalon , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] mk: fix permissions when using make install Thread-Index: AQHUL/T0ck/nR7DWDEixvkrxaQJKDqS3r42A Date: Thu, 9 Aug 2018 17:38:08 +0000 Message-ID: <661CFF7D-1DA5-48E0-B18F-6A5B8EDE04C1@mellanox.com> References: <20180809152235.45376-1-bruce.richardson@intel.com> In-Reply-To: <20180809152235.45376-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4012; 6:XhST7sD0uh6hzMaiIorrGFbWPUrQE63+/Xf/UW9s5X4mOiuczI48F5ebE/NedfV7XKLmwH7l3DYNcdB2iQQ95rLAnKCZAzUVB5Sk4GrWxDnHuLhpdVZMo6Aksi1EKhdyMEnRIcoXotYi6CYwA86fI9ze3HKi0lhO4IxDLBMXM2dpFduOeQUHgV5Uh/EJB9Jp8CX3CZ5DvNL2uEhQbY+6f4PXRTnyjTEakDR/oPYyIgxi3cxZ9pfMgWiUH7kgS/zM1HPhzMFXHgnsmY12FKkm3X1E7k6N1cFaeMFUzvuYTN3K5FEW/IyYWCH2JoNlbUobvsL72vm9CK4HnJ8E0sb7hnhtUGqYP+cgZr0u+OSLMRGZGsdrViBf+hhoRx97dSp8EZQwye3Fm6KX3UiFHXSjDgmbv/yIP/QoAx7AJoQIxE49krH19JbKc7PwwX+9e5zxifXr9IhUsu4x/MaQE9Mgjg==; 5:pYFb8iz8wC2Gnd020zi/cmaDXz7waG4k7Wi+9QYiFFUyKI5GXUGf3CZMCGBr41fmAt3veOw5Ico4LdZI9qAB6cvsE4S9TlKvwmj3dA3ZXwSqieBQ76GsZguPXRwO+NYa+3DG9Pwle7Ibu7CZxJ0hyHjuOjDJSt6ilpRtJTyi7os=; 7:2K/0Oa1KQx2z/rkP3HiQ3638hVu6/LPJ3ONILZJvFvMv1mvNGN7YetIS6wYxn+Z7xN6MfpQ9h6iHpjI31vtEo7Z0SMX9CRXLlwticljkj5cPuwINDb7WJFkOpoyKNreQfi7TI61ZF04shWGv+9eShGKrxQeDdUYoEugNAJ28oBC22yvMCuRO3I6KeNYVE8R5x7PUF41xADmC8c82WRyyjVu8CsHZ4d58xaVuXXfRNbs3Id+20T6H3Q+XvJ8xarO8 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: ba8654bd-33d8-4993-1481-08d5fe1edef0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4012; x-ms-traffictypediagnostic: DB3PR0502MB4012: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB4012; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4012; x-forefront-prvs: 0759F7A50A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(376002)(396003)(136003)(189003)(199004)(446003)(8936002)(2906002)(33656002)(4326008)(5250100002)(476003)(2616005)(486006)(11346002)(86362001)(575784001)(68736007)(6246003)(256004)(478600001)(25786009)(3846002)(6116002)(14454004)(82746002)(26005)(7736002)(8676002)(81156014)(81166006)(76176011)(97736004)(106356001)(54906003)(6436002)(66066001)(229853002)(6486002)(83716003)(305945005)(99286004)(316002)(5660300001)(53936002)(36756003)(6512007)(53546011)(6506007)(186003)(102836004)(105586002)(2900100001)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4012; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: BosivirrgZDaIhCYXVuIIEiA/PhOxZ5LcueKeOww1qZcQahtL1tw0rSzaPpBRC4JfEA3lLcKHCGDbYkrvLt6QVh2O6pxuIyZ8kPDJQNAp1ZlfJd+Ld5hA2YmCVkGqlSZHqDLXfaydtQ7xrGFA1Sbmsf9ZUvf6/QHuqAl7IBDFeqknfA9MLj/wUbG2eIfC71wTrK4tB/QH0+hcTf58Wvs1S4BQyAPOeD0Y4OzAKm4rt7rKCAdc7AHrzqvetXal7TTD4zuR7HNxKjMvdt36wbmdEdH15aCygvXNbzk+pqjZyqJl4pvPdp2/AvOxTgFPiVR0f2PlJ7oTzr4cpTaC9nvrewG9t8eEWg1ggeJLp0wNE0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba8654bd-33d8-4993-1481-08d5fe1edef0 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2018 17:38:08.4252 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4012 Subject: Re: [dpdk-dev] [PATCH] mk: fix permissions when using make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 17:38:14 -0000 > On Aug 9, 2018, at 8:22 AM, Bruce Richardson = wrote: >=20 > When using make install, the permissions of the resulting file should be > those of the user using make install, not those of the user who ran the > build. This would not be the case when a user explicitly runs: >=20 > "make && sudo make install" >=20 > Fix this by changing "cp -a", which preserves all attributes, to > "cp -dR --preserve=3Dtimestamp", and by adding the flags > "--no-same-owner --no-same-permissions" to the calls to tar. >=20 > Fixes: 1fa0fd9d6b42 ("mk: allow to specify DESTDIR in build rule") > Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree") > Fixes: 576de42b83e5 ("doc: render and install man pages") >=20 > CC: stable@dpdk.org > Signed-off-by: Bruce Richardson > --- Applied to stable/17.11. Thanks, Yongseok