From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C526A4590C; Thu, 5 Sep 2024 11:51:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A738B40264; Thu, 5 Sep 2024 11:51:40 +0200 (CEST) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by mails.dpdk.org (Postfix) with ESMTP id 7B63F4025C for ; Thu, 5 Sep 2024 11:51:38 +0200 (CEST) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5c26311c6f0so685318a12.3 for ; Thu, 05 Sep 2024 02:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1725529898; x=1726134698; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=azZh3Gcsv3q/TKET0z9QG/sEvr2P96JSW9VTwdDHCl4=; b=RIxnPXK0h4lM0VD/OjN5WMk2Jp0GLGH4nbC+ve4N92TR43KztPXZKVS5mD8hZvFHMx zofv++qDI2dFESQQTNGC0xMt3nvKb1TFq2u2dDp8Epv5cPkexYuo4v32+0uaU2RR/X5D Zy6E3P6oN5jCvH28pzsEJ+hSiQdnIu40SZp02oOXEDzu1FRFFZbJZqfjDtMXH9aSOfA4 CsbBbSG0+Jid86haonsXxmW4cgQ+ZAwwmp6xMFST/hLzD5F6e46PMbvuwQUrxE9hrS03 HZofvSRDp6yrL6qBArlI3mmnoncJckLA3vikMWFliKNidbdBzAKdIZvAqdGruPwyIozO Bu5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725529898; x=1726134698; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=azZh3Gcsv3q/TKET0z9QG/sEvr2P96JSW9VTwdDHCl4=; b=HurHDt/x1xOk5H8mB1O1+bka8SJpcvpVnABxhk04RsXGP4bCzlMD6geIGgH6ZETj+C b2iRMVBEjaUgfK5qlQc4aIBpOa+61O4eaokQXQWfljIMNEMEz7mAcqWnGa+HeEHqlSiL MqViHiINx8kFy11n7EpdieeqQ3cAz6xddmb1p/573bn0SZT6SO5V4m67dCDrNhNjeOMs 7oqjh6dlM0I4BIJoCePEZB4gIYYOZ1EWuVK10GysKmEs8IgUUGsOIekFhn1oo50RSPrc /VaPaKsrJ2Bfvj0cJgXkUHD2nXucQP41xLbQ5NmNOtCvFWcRvU4W4nCWNDwrAEnh35VN Pldw== X-Forwarded-Encrypted: i=1; AJvYcCUE/KiBMo4gE9pbS91xs6jEmsep5nrKcFKkkCvDE5ofU87QMEkZl9x3QK4Zt0P02K0Dzrw=@dpdk.org X-Gm-Message-State: AOJu0YwyLRoSP/74JyyXBhzAQNB5mJdHzsyKDcYuV8hNSpIKgMVvNaeS Jb2mCeGElayqttV4PeQjvvxJMVFmKxZFQToXFZvPZpgj3wttvPtGrQ+7PeSjGYc= X-Google-Smtp-Source: AGHT+IEKf9Z2U6r1yhvJBjTWazbxzTh5AAI0L48OeuKJ3xpIkUR5ibeUG6mt2+Bq/KSUHeWXdgOKjw== X-Received: by 2002:a17:907:d92:b0:a86:843e:b3e3 with SMTP id a640c23a62f3a-a8a3f24375bmr455858066b.33.1725529897859; Thu, 05 Sep 2024 02:51:37 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a6236d61csm112230366b.125.2024.09.05.02.51.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 02:51:37 -0700 (PDT) Message-ID: <661f3821-a6d4-407a-be7d-cdcf2e7b95b7@pantheon.tech> Date: Thu, 5 Sep 2024 11:51:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/12] dst: add basic capability support To: Dean Marx Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-7-juraj.linkes@pantheon.tech> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3. 9. 2024 18:03, Dean Marx wrote: > On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš > wrote: > > A test case or suite may require certain capabilities to be present in > the tested environment. Add the basic infrastructure for checking the > support status of capabilities: > * The Capability ABC defining the common capability API > * Extension of the TestProtocol with required capabilities (each test >   suite or case stores the capabilities it requires) > * Integration with the runner which calls the new APIs to get which >   capabilities are supported. > > Signed-off-by: Juraj Linkeš > > > Looks all good to me, it was interesting to see how you've used abstract > methods in the Capability class. The only thing I noticed was it seems > like you wrote "dst" instead of "dts" in the commit message, otherwise: > Oh, right, thanks for the catch. > Reviewed-by: Dean Marx >