From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 27E525A3E for ; Thu, 9 Jul 2015 02:52:33 +0200 (CEST) Received: by wiwl6 with SMTP id l6so3919395wiw.0 for ; Wed, 08 Jul 2015 17:52:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=d8/U2Hk0cvCROMNQUCs9x1lgHt9JYInoK5IeFKedqbw=; b=StlHlD3gpvJ6wyPkSw1ZWNQgku3dOwJAj47cmqucyAe+Y+1ByGMi9LzoRGbQz3tjbW vAfvZCIkH2wjIePAWkrgvE5l74kY4iGyXzXqLdux+4ZfaEr4c39W2wCt3MFhkq24v74i ICvdZTJk7m1/NWlA1AJ/UE3l/0uEUurd3Wgio1Tlg3cfbK+idIQ4dNzjFkuqwaG2LC5o uR21F+A6rNV6o/iLDMyyzyxgsEc8XMlEQBzXABTkZDeAqx128sH9fm8xc5gkcPdnH7+t caqCEnNN2ATqMN1AGp2S5Wwvzxn6dWHd+GcoRowuauQu63A9qo+aXuJyzy/8LBjg3iso mB9w== X-Gm-Message-State: ALoCoQnpgXk+HmWftv+Luw8+PnU5EfxYltp5jODxZ/DRKqnSRm99jY3EUwFPhdaimVz3W0I6mXbd X-Received: by 10.180.91.107 with SMTP id cd11mr73909252wib.51.1436403152948; Wed, 08 Jul 2015 17:52:32 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id e7sm5427829wib.22.2015.07.08.17.52.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2015 17:52:31 -0700 (PDT) From: Thomas Monjalon To: Zhigang Lu Date: Thu, 09 Jul 2015 02:51:27 +0200 Message-ID: <6620352.tGbjSFjKPr@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1436172698-21749-7-git-send-email-zlu@ezchip.com> References: <1436172698-21749-1-git-send-email-zlu@ezchip.com> <1436172698-21749-7-git-send-email-zlu@ezchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 06/12] memzone: refactor rte_memzone_reserve() variants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 00:52:33 -0000 2015-07-06 16:51, Zhigang Lu: > The definitions of rte_memzone_reserve_aligned() and > rte_memzone_reserve_bounded() were identical with the exception of the > bound argument passed into rte_memzone_reserve_thread_safe(). > > This patch removes this replication of code by unifying it into > rte_memzone_reserve_thread_safe(), which is then called by all three > variants of rte_memzone_reserve(). Ideally, some functions should be merged to avoid some #ifdef RTE_LIBRTE_XEN_DOM0.