From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EF5EA04B1; Thu, 24 Sep 2020 12:07:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D49341DDB8; Thu, 24 Sep 2020 12:07:15 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 1481B1DDB1 for ; Thu, 24 Sep 2020 12:07:14 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 43B0658015D; Thu, 24 Sep 2020 06:07:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 24 Sep 2020 06:07:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Hb4p1gUpSPzNi7sELw2GHtfbuIz4p0aYsLUVgXJmeC0=; b=mVU8aFiBKiHCBi7T RqF7YerTBpE6pYALWPMQFTiv93QQnHwrBLiYZG34GUnQYiEDnovC+IKkBSAM8TpF gJy5sF42xx0k1DfEzARIuoNc/nHVXJ8Ro93hMPtayUNbURHqIJFVdnPlg0KNYhfD Ykh1Z313R5Caq2a178IJZTMdutgBb7VyDJJa9HHIpqQ98e3vUBqs6EHOIkf4wywx u+wR8MDzbi7ATMmv0FFi1Si+AflUZb5cv8m0rfFxS4FXlYq5kjmK0zCzlM6IWMcl 3vZZR/WdCY8RCunV4GxtdILdblJfswQvuPOKYBZu+GfKZwIYY8/xSNihEBxrpaH/ 3wIQrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Hb4p1gUpSPzNi7sELw2GHtfbuIz4p0aYsLUVgXJme C0=; b=hjfF1juIHNeAW6Mq9cblosrbvK6+hiJnhilR9BNOS3rA0j/c+eOMuAAJZ P/2XGTAPXHrK+rlfXnmXDEiRy6/P9zYFwV/xlabU4muN01IvCVcity/r3nzCa2YU 3hNsWiAJZjGwNL0aBicF0+5z13d5aAhtvkvo/ykfqXSoNZpNaf6ipGzAyoCTaX5K HEGOwuGYn4qSJ5jfBCfrIyAV8O4l9kkRYdZhxu48InbRwZReib581obG1GtXI3Cn LHioGXmAp/I074ADF+I90WPac9a9b4caLutsQC9NjT1bCa1152OLBE/AB52gf6o7 9Ss5vrJjPhZbBpHVnWklhQn2xUiyA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2C028306467E; Thu, 24 Sep 2020 06:07:05 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Stephen Hemminger , Ferruh Yigit , dev@dpdk.org, arybchenko@solarflare.com, "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wei Zhao , Jeff Guo , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang Date: Thu, 24 Sep 2020 12:07:03 +0200 Message-ID: <6624369.qqrmt2J4GO@thomas> In-Reply-To: <20200924091246.GA382@bricha3-MOBL.ger.corp.intel.com> References: <20200913220711.3768597-1-thomas@monjalon.net> <4950952.GUjYEhNGMI@thomas> <20200924091246.GA382@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/09/2020 11:12, Bruce Richardson: > On Thu, Sep 24, 2020 at 12:35:58AM +0200, Thomas Monjalon wrote: > > 24/09/2020 00:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 23:52:07 +0200 > > > Thomas Monjalon wrote: > > > > > > > > > > > Yes it is a step in the right direction. > > > > > > > > Changing the API means adding some error checks in every apps. > > > > > > > > The reason for not doing is that I did not commit for this task, > > > > > > > > and I am not the author of the deprecation notice. > > > > > > > > We can discuss how to follow up once this series is merged. > > > > > > > > > > > > > > Not sure what application can really do if dev_close fails other than call rte_exit()? > > > > > > > > > > > > At least, it can show a message to the user. > > > > > > > > > > Agree, but no code checks return from close() system call now. > > > > > At least testpmd should be updated; the examples are fine. > > > > > > > > How do you explicitly silence the static code analyzers? > > > > Do you recommend adding (void) in front of the call to close()? > > > > > > Coverity usually gives something like, "return value of foo() is not checked > > > but checked 10 other places" > > > > Yes so it should be silenced with (void) or ret = > > > Does coverity still give the warning if the majority of cases don't > actually check the return value? No idea