From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F395FA0577; Wed, 15 Apr 2020 05:11:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 06F021D41A; Wed, 15 Apr 2020 05:11:15 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id AB06A1D415 for ; Wed, 15 Apr 2020 05:11:12 +0200 (CEST) IronPort-SDR: BaPSXfroIfaYcMZn8k64+Qf2Kfn3gDnW6bU1D4LCyW1fR8PjFiQsoQ0z8Z53TNEwIkzBgFiP+M rQwzescYbrAA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 20:11:11 -0700 IronPort-SDR: +bCReYUN2Dm4xLwpg6AY5JRVN94ZFP166gmCbrzOfwfCr3hxILn4ZFkQ1vwYrV7ze6iPPw7uma daGXnp9BjBvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,385,1580803200"; d="scan'208";a="277475780" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.150]) ([10.67.68.150]) by fmsmga004.fm.intel.com with ESMTP; 14 Apr 2020 20:11:09 -0700 To: "Zhang, Qi Z" , Ori Kam , "Iremonger, Bernard" , "Ye, Xiaolong" Cc: "dev@dpdk.org" , "Wu, Jingjing" , "Cao, Yahui" , "Su, Simei" References: <20200318170401.7938-5-jia.guo@intel.com> <20200414174225.64120-1-jia.guo@intel.com> <20200414174225.64120-2-jia.guo@intel.com> <039ED4275CED7440929022BC67E70611547F9991@SHSMSX103.ccr.corp.intel.com> From: Jeff Guo Message-ID: <66300ddf-eede-d9e0-5b51-cd62c9c2d0c3@intel.com> Date: Wed, 15 Apr 2020 11:11:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <039ED4275CED7440929022BC67E70611547F9991@SHSMSX103.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [dpdk-dev v4 1/3] ethdev: add new RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ori and qi On 4/15/2020 10:31 AM, Zhang, Qi Z wrote: > >> -----Original Message----- >> From: Ori Kam >> Sent: Tuesday, April 14, 2020 5:43 PM >> To: Guo, Jia ; Iremonger, Bernard >> ; Ye, Xiaolong ; >> Zhang, Qi Z >> Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui >> ; Su, Simei >> Subject: RE: [dpdk-dev v4 1/3] ethdev: add new RSS offload types >> >> Hi Jeff, >> PSB >> >> Best, >> Ori >>> -----Original Message----- >>> From: Jeff Guo >>> Sent: Tuesday, April 14, 2020 8:42 PM >>> To: Ori Kam ; bernard.iremonger@intel.com; >>> xiaolong.ye@intel.com; qi.z.zhang@intel.com >>> Cc: dev@dpdk.org; jingjing.wu@intel.com; yahui.cao@intel.com; >>> simei.su@intel.com; jia.guo@intel.com >>> Subject: [dpdk-dev v4 1/3] ethdev: add new RSS offload types >>> >>> Defines some new RSS offload types for ETH/SVLAN/CVLAN/GTPU/L2TPV3/ >>> ESP/AH/PFCP. >>> >>> Signed-off-by: Jeff Guo >>> Reviewed-by: Qi Zhang >>> --- >>> v4->v3: >>> no change >>> --- >>> lib/librte_ethdev/rte_ethdev.h | 11 ++++++++++- >>> 1 file changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/librte_ethdev/rte_ethdev.h >>> b/lib/librte_ethdev/rte_ethdev.h index d1a593ad1..efe705ff0 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> @@ -511,6 +511,13 @@ struct rte_eth_rss_conf { >>> #define ETH_RSS_GENEVE (1ULL << 20) >>> #define ETH_RSS_NVGRE (1ULL << 21) >>> #define ETH_RSS_GTPU (1ULL << 23) >>> +#define ETH_RSS_ETH (1ULL << 24) >>> +#define ETH_RSS_S_VLAN (1ULL << 25) >>> +#define ETH_RSS_C_VLAN (1ULL << 26) >>> +#define ETH_RSS_ESP (1ULL << 27) >>> +#define ETH_RSS_AH (1ULL << 28) >>> +#define ETH_RSS_L2TPV3 (1ULL << 29) >>> +#define ETH_RSS_PFCP (1ULL << 30) >>> >>> /* >>> * We use the following macros to combine with above ETH_RSS_* for >> @@ >>> -524,7 +531,9 @@ struct rte_eth_rss_conf { >>> #define ETH_RSS_L3_SRC_ONLY (1ULL << 63) >>> #define ETH_RSS_L3_DST_ONLY (1ULL << 62) >>> #define ETH_RSS_L4_SRC_ONLY (1ULL << 61) >>> -#define ETH_RSS_L4_DST_ONLY (1ULL << 60) >>> +#define ETH_RSS_L4_DST_ONLY (1ULL << 60) >>> +#define ETH_RSS_ETH_SRC_ONLY (1ULL << 59) >>> +#define ETH_RSS_ETH_DST_ONLY (1ULL << 58) >>> >> Why not change to L2_RSS_SRC_ONLY? Same for DST? >> Also if it is not ABI/API change I would suggest to move the ETH defines to be >> 63. > I think reorder will break Application which already use 19.11. Will rename it to ETH_RSS_L2_XXX and keep the order which will not break the ABI/API, if no objection. Thanks. >>> /** >>> * For input set change of hash filter, if SRC_ONLY and DST_ONLY of >>> -- >>> 2.20.1