From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id F04E01BB1A for ; Sat, 7 Apr 2018 11:41:29 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id AD4F4600056; Sat, 7 Apr 2018 09:41:27 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 7 Apr 2018 10:41:21 +0100 To: Adrien Mazarguil , Thomas Monjalon , Ferruh Yigit , CC: Ajit Khaparde , Somnath Kotur , Beilei Xing , Qi Zhang References: <20180404150312.12304-1-adrien.mazarguil@6wind.com> <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180406131736.19145-13-adrien.mazarguil@6wind.com> From: Andrew Rybchenko Message-ID: <664d5436-bd31-6f29-d309-a444db6d5a3e@solarflare.com> Date: Sat, 7 Apr 2018 12:41:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180406131736.19145-13-adrien.mazarguil@6wind.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23768.003 X-TM-AS-Result: No--14.599500-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523094089-VO5+ZjwHdIg8 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 12/15] ethdev: update behavior of VF/PF in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Apr 2018 09:41:30 -0000 On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > Contrary to all other pattern items, these are inconsistently documented as > affecting traffic instead of simply matching its origin, without provision > for the latter. > > This commit clarifies documentation and updates PMDs since the original > behavior now has to be explicitly requested using the new transfer > attribute. > > It breaks ABI compatibility for the following public functions: > > - rte_flow_create() > - rte_flow_validate() > > Impacted PMDs are bnxt and i40e, for which the VF pattern item is now only > supported when a transfer attribute is also present. > > Signed-off-by: Adrien Mazarguil > Cc: Ajit Khaparde > Cc: Somnath Kotur > Cc: Beilei Xing > Cc: Qi Zhang > --- > app/test-pmd/cmdline_flow.c | 12 +++--- > doc/guides/prog_guide/rte_flow.rst | 36 +++++++++--------- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +++--- > drivers/net/bnxt/bnxt_filter.c | 22 ++++++----- > drivers/net/i40e/i40e_flow.c | 23 +++++++----- > lib/librte_ether/rte_flow.h | 47 ++++++++++-------------- > 6 files changed, 77 insertions(+), 75 deletions(-) <...> > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index 735ce6323..beedc713b 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -518,15 +518,12 @@ Usage example, matching non-TCPv4 packets only: > Item: ``PF`` > ^^^^^^^^^^^^ > > -Matches packets addressed to the physical function of the device. > +Matches traffic originating from (ingress) or going to (egress) the physical > +function of the current device. Not sure that I understand above. It looks like ingress and egress are misplaced. There many similar cases below. <...>