Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 05/08/2018 02:02 PM, Ferruh Yigit wrote:
> On 5/8/2018 11:41 AM, Andrew Rybchenko wrote:
>> On 05/08/2018 01:05 PM, Wei Dai wrote:
>>
>> [...]
>>
>>> In the beginning of [rt]x_queue_setup( ) of underlying PMD,
>>> add offloads = [rt]xconf->offloads |
>>> dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API
>>> defined in 17.11 to avoid upper application broken due to offload
>>> API change.
>>> PMD can use the info that input [rt]xconf->offloads only carry
>>> the new added per-queue offloads to do some optimization or some
>>> code change on base of this patch.
>> It looks like I've missed why PMDs should be updated to
>> add device offloads to per-queue offloads.
>> Cannot it be done on ethdev layer? PMD still can find out
>> which offloads were enabled on device level by
>> checking [rt]xmode->offlaods.
> The stripping [rt]xconf->offloads part added into ethdev layer. This changed the
> input set to the PMDs.
>
> Above coded added to keep the input same for the PMDs. Expectation is later PMD
> update its code to use new input and remove this update.

Thanks Ferruh. I read code too fast and lost it from my view.
I'll provide more review notes related to net/sfc.

>>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>> [...]