From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62253A0597; Fri, 17 Apr 2020 22:39:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 071921EABE; Fri, 17 Apr 2020 22:39:45 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E05C61EA72 for ; Fri, 17 Apr 2020 22:39:43 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200417203942euoutp01f32b3c3b81c5fb2f71c7b43431c6ebad~GtfUYSvuX0827808278euoutp01a for ; Fri, 17 Apr 2020 20:39:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200417203942euoutp01f32b3c3b81c5fb2f71c7b43431c6ebad~GtfUYSvuX0827808278euoutp01a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587155983; bh=yNGbukxS1bQAR9J3Bs/aj15npLmoC1twPS331di3c0Q=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=mYVhaRxS/8/7oyoMHI8VmWanWa1sYewlk2L3TV93qHbJdwkRWz/XSgudFGctSHguj tpQrorr+4VIDEzVfF8jKFYt75bwtr7kIbzLqFMORp4ntPgNGANyVxz5Gbu/m6FDmUd anz/hvoGSn5YbREyY2mA4amldruB/XitW9k2Vq3U= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200417203942eucas1p197b6da066275fe24946a994e31b60646~GtfTux-fG0656306563eucas1p1B; Fri, 17 Apr 2020 20:39:42 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 92.8F.61286.E041A9E5; Fri, 17 Apr 2020 21:39:42 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200417203940eucas1p16e0d539cb5d43275722b9690136225d7~GtfSd7d4z0064600646eucas1p1y; Fri, 17 Apr 2020 20:39:40 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200417203940eusmtrp23f0796d85c56a29cb79a4f80d7c01fdc~GtfSdZJVR1639416394eusmtrp2c; Fri, 17 Apr 2020 20:39:40 +0000 (GMT) X-AuditID: cbfec7f2-f0bff7000001ef66-8a-5e9a140e0f5d Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 6B.34.08375.C041A9E5; Fri, 17 Apr 2020 21:39:40 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200417203940eusmtip2cdfc24cf40115f0227a3702a946142b2~GtfSKjsZw2246622466eusmtip2J; Fri, 17 Apr 2020 20:39:40 +0000 (GMT) To: Akhil Goyal Cc: "dev@dpdk.org" From: Lukasz Wojciechowski Message-ID: <6656b7d1-077b-1a7d-1321-1d756657665a@partner.samsung.com> Date: Fri, 17 Apr 2020 22:39:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42LZduznOV0+kVlxBqeecFmsPzOP0eLdp+1M DkwevxYsZfXY+G4HUwBTFJdNSmpOZllqkb5dAlfGtt+LGQv281bM673B3MD4n6uLkYNDQsBE 4sKz4C5GLg4hgRWMErcefmfpYuQEcr4wSrxZnwGR+Mwosbz3HlgCpOHvtnmsEInljBIPfzVC OW8ZJT7O2g1WJSwQLHH8xA12EFtEQFViQ8NfsDizgKLEp22zwWw2AVuJIzO/soLYvAJuErfe fmMDsVmA6o9//cYEcp6oQKzE9GshECWCEidnPgFr5QQK/+6byg4xUl6ieetsZghbROLGoxZG kHskBD6zSUztXAV1tYtE2+4GVghbWOLV8S3sELaMxP+d85kgGrYxSlz9/ROqez+jxPXeFVBV 1hKH//1mA7mIWUBTYv0ufYiwo8SGyT+ZIOHIJ3HjrSDEEXwSk7ZNZ4YI80p0tAlBVOtJPO2Z ygiz9s/aJywTGJVmIXltFpJ3ZiF5ZxbC3gWMLKsYxVNLi3PTU4sN81LL9YoTc4tL89L1kvNz NzECU8bpf8c/7WD8einpEKMAB6MSD69Bz8w4IdbEsuLK3EOMEhzMSiK8B92AQrwpiZVVqUX5 8UWlOanFhxilOViUxHmNF72MFRJITyxJzU5NLUgtgskycXBKNTCucqvdHRQ9TUTB9Y16y6oV 3RX794tP+d2t8Wn1T/XmwhPe4acndGbybA0Oe97G6mQz9y2Lwle/PXvehU7znrz23yRZpWWp Sp7ODQ+Vi348e7iZ75DEy9mOWpP/H5b9F/e5R2PbPGumb1HJ2y7zd9zf8u5Vs/vL2RcfyWpo zJr8YLvIWU1rqXQfJZbijERDLeai4kQAQudOaBUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsVy+t/xe7o8IrPiDB6vNLVYf2Yeo8W7T9uZ HJg8fi1Yyuqx8d0OpgCmKD2bovzSklSFjPziElulaEMLIz1DSws9IxNLPUNj81grI1MlfTub lNSczLLUIn27BL2Mbb8XMxbs562Y13uDuYHxP1cXIyeHhICJxN9t81i7GLk4hASWMkq8/d7H 3sXIAZSQkfhwSQCiRljiz7UuNoia14wS0/r/sYAkhAWCJY6fuMEOYosIqEpsaPgLFmcWUJT4 tG02C0TDNmaJDdM2gxWxCdhKHJn5lRXE5hVwk7j19hsbiM0C1Hz86zcmkMWiArESLRc1IUoE JU7OfAI2kxMo/LtvKjvEfDOJeZsfMkPY8hLNW2dD2SISNx61ME5gFJqFpH0WkpZZSFpmIWlZ wMiyilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzBKth37uXkH46WNwYcYBTgYlXh4DXpmxgmx JpYVV+YeYpTgYFYS4T3oBhTiTUmsrEotyo8vKs1JLT7EaAr020RmKdHkfGAE55XEG5oamltY GpobmxubWSiJ83YIHIwREkhPLEnNTk0tSC2C6WPi4JRqYMy6bPIgNN//3MGTN5c0xiQJHdDX zn/LwCLQdZ+BMzvQu11HLKfqwpXLsgw6al5HlxWvPyO1fNkuk/0T5ygsWGkxNZ+Nq/7d+shy 4z9XTujuZLFx6eF+kxd47hSvUX01g+shvYbj2w2Y1ngv/fhgWrJvTd83zy2Sc05Z7dvqOU/i vlrLu4qmH0osxRmJhlrMRcWJACVAaUuoAgAA X-CMS-MailID: 20200417203940eucas1p16e0d539cb5d43275722b9690136225d7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200409172528eucas1p1186911653001cab0e69f10fc42790023 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200409172528eucas1p1186911653001cab0e69f10fc42790023 References: <20200408031351.4288-1-l.wojciechow@partner.samsung.com> <20200409172502.1693-1-l.wojciechow@partner.samsung.com> Subject: Re: [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 17.04.2020 o 22:21, Akhil Goyal pisze: >> W dniu 17.04.2020 o 21:46, Akhil Goyal pisze: >>> Hi Lukasz, >>>> Set of patches fix minor issues like proper verification of input >>>> parameters and aligning documentation with code in the matter of return >>>> values. Another fixed issue is invalid decrementation of the session >>>> counter which might cause inconsistency between counter values and a true >>>> number of sessions. >>>> >>>> All of these issues (and all the librte_security) code is covered with >>>> unit tests. The tests are added to dpdk-test application and can be >>>> launched with "security_autotest" command. >>>> >>>> --- >>> Series >>> Acked-by: Akhil Goyal >> Thank you >>>> create mode 100644 app/test/test_security.c >>> This file need a MAINTANERS entry >>> Could you please send an update? I will squash it in the 5th patch. >>> >> I don't know if I should send the new version of al patches or just >> paste it here. Please let me know, if I should send the new updated patches. >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index f38621c2e..baa7fe015 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -412,6 +412,7 @@ M: Declan Doherty >>  T: git://dpdk.org/next/dpdk-next-crypto >>  F: lib/librte_security/ >>  F: doc/guides/prog_guide/rte_security.rst >> +F: app/test/test_security.c >> > Added the above change in your 5th patch. > > Applied to dpdk-next-crypto > > Thanks > Great! Thank you so much. -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com