From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0078.outbound.protection.outlook.com [104.47.37.78]) by dpdk.org (Postfix) with ESMTP id D6EA8107A for ; Fri, 29 Sep 2017 06:53:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/SeQf4g4lnMSJM2ipB0lEHfR+ne0HxeD+MOFqr88DJ4=; b=gZtbmSockbBB9t47i68GBxD0AFtPnz5mID13pcpxApjfrM4sR5bj7n4g6913RATrJZ37xltyOQ/0Vgad9hahq3f/GeaeM0cLnHUxI4Xf+Aq/PqyxvswFwfDJ2SX8gMJNC9kpyyroL7h6pdZtsz7PcHCqSLriWeRm2yl56gm1NpY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [192.168.88.32] (31.216.236.195) by BN6PR07MB3091.namprd07.prod.outlook.com (10.172.105.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 29 Sep 2017 04:53:54 +0000 To: Olivier MATZ References: <20170906112834.32378-1-santosh.shukla@caviumnetworks.com> <20170907153042.30890-1-santosh.shukla@caviumnetworks.com> <20170907153042.30890-9-santosh.shukla@caviumnetworks.com> <20170925114141.ynhho56eciqlyxqu@platinum> <8326c640-93f9-2662-56fb-26f50e42161c@caviumnetworks.com> Cc: dev@dpdk.org, thomas@monjalon.net, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com From: santosh Message-ID: <66635b0c-2a96-a1cd-4f99-89fea50faf11@caviumnetworks.com> Date: Fri, 29 Sep 2017 05:53:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <8326c640-93f9-2662-56fb-26f50e42161c@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [31.216.236.195] X-ClientProxiedBy: HE1P195CA0011.EURP195.PROD.OUTLOOK.COM (10.171.121.21) To BN6PR07MB3091.namprd07.prod.outlook.com (10.172.105.9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2332e1d-0b5d-44d4-2b48-08d506f616bd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BN6PR07MB3091; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 3:eG4T/hL4CZNX1f3KMQ/Lq5BbvELF+cMdd422buRcLcr6wFL778jbPUORI3MlGzp8engH2gI7d6rApaeO/5xE/AkbLyjIu8QWqRvcHiDmYsLMY4mtGaOp46HE8UnOPtPgCpmc7ByI3o3l4BlCtBu6aVDxPu2g9nlXs995UvbPq0UGkT/3Z0NWGTEUoJXGwVwwNkKQv/XoKSKuTmt6iWFenITHv8McjoGn5TN81eWrYMealonNK+eh1EHVe0yXCmzr; 25:bQY3xDYjxhOU8W916tixI8IcJLYh/B6WK15H2P9HVNIUUMG2TRh6SYb/D6bIYN1wHJodESZJPj2JNANv0QYHb5nUscfFwchbFLYeEZga2wveb5GxGTdrH2D/qRP4B2JkOqTz8tvGYNyl/B11uZuLi0mv6pClCMyEUxF4SRKN/ymWlWNBeT80eYSeDn3LM/Zg30/0mzs4ykLOhWQ5mtM5s0WsFED0oK4gwjCrP0KGSqWEZPOfXyW29I+jKAJVAgkyfL8fp71kjCTqyvLwQrZ26fRf7pEpxkzFEoTX0hfQ2oIsKuQEGmFbIthxI/bz2Lluv012ewW8RIppz7lu+ycsDg==; 31:nIdxmgNGCXcC0wScWJ2c5BSuUEDR12Acof6xLVZhg021CVUk7ijkScw2U4L8o2pU1oNPEHywZAqTvQDCJNHntcVNZZrv6xSX2obc4arwmSXh85yzR7F3y7Jx3KrSnyPQlXIUmJMENdeU0RxnY1YijONhhGJrLu0V0x0YMAuFvvYXthY+kVSzG/V9H/jlj9BMrGezQRMHk4Svv49V32fLiGl2JeBUpHCLmoZ4v+bnqzk= X-MS-TrafficTypeDiagnostic: BN6PR07MB3091: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 20:V3YQ6fhOW6fQp7vAnpVPyVzjunJA/Zz4mH6gwlBeFcTYcQbHNnDMhGlPf0M7qiZJjaUyDSZU+LyPqTwroYSg8GcqgEqkDWTZkRmt0BKEJSfK/O5FGXGx4jkha9n7B8tFwoICJdVsoZ6daozQiqGv+khPcibac0nkFWpOQ1CcQmHds0fAihR0ALdBCs7PaK1uGPvTFuhecGAVDveuEjWWyG3GPN3M9WANulauHzCo8OHOYqIV48U+C3JZRRX80wy2Yb9ULaLsWN8nXI7iO89eHm716fGStWb/jLciUmDQHZ5toWT6p9LG+r+02iMVYjpl4Xqr8fN8hZjAL33Y6TvL+G+setnH0Wr06Enuqzu+YaMNs8hnL8SFN2+vXrwCb8doxw7to7Ma20y5iy+RXJsC8a/p4BQt+hXHBayWeF8ozwZE2VpCMpXe3LIZoyoOpIzj3D+fBVM3gdruN3/6upSaA+LzLzdWMB6robMsOncvMirV7HaGS1H9q1fuEKWI6p6E0mkZmrsb1G1VkCBV2a5TBEt+3OkPGTvVIZs6oGXTx3mm5pf+riunJHW6ZfJM6YcztzWt69727c1p+TNKKpE3Zljlduxwzl5dyMLUjrGao6M=; 4:EjfXEHvWaHTxClY5JC5k9SJ4l9LuAiIgorBcuoa2KNH4+Dd/CzTPZIOb1mhUlbEAPsqxXcvw3cSHGqxFGa4YzkGqGewDI2ViogaL5fPwfibbn2FvWKaqdv0wWg/V9iaxDUykLSlGz4NV9b41akttVY1tVHwTnnBfFfYnCaAgh1jqKb8gNrvBsQaJKAmlaJMVX2MrBedkTSS5c/n9zqSrjEXeKmfEMfrCPVqq0wJRzOrHoeDarmmuJjrwDrer3n2H X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(6041248)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3091; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3091; X-Forefront-PRVS: 0445A82F82 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(6009001)(376002)(346002)(377454003)(189002)(24454002)(501624003)(199003)(229853002)(6486002)(2906002)(50466002)(230700001)(65806001)(6246003)(53936002)(31696002)(83506001)(189998001)(77096006)(90366009)(65826007)(31686004)(2950100002)(93886005)(58126008)(97736004)(5660300001)(42882006)(36756003)(316002)(6306002)(53376002)(6666003)(3846002)(16576012)(16526017)(86152003)(6916009)(478600001)(105586002)(81156014)(101416001)(966005)(72206003)(117156002)(305945005)(8936002)(106356001)(8656003)(6116002)(54356999)(50986999)(76176999)(7736002)(68736007)(8676002)(81166006)(47776003)(25786009)(65956001)(33646002)(23746002)(66066001)(4326008)(64126003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3091; H:[192.168.88.32]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR07MB3091; 23:pYX2oiPmU1FCNV4WPnoL5/E5SuUftVGoghODn?= =?Windows-1252?Q?Av+jbjFhoB7a4onXSi5Ym+eklqAujR+NO4sW/cUEnzqCFbDrLz5pcmdb?= =?Windows-1252?Q?VldxIq0Ld3GR4Pi4Ur5bklRp5yDDe9tlBhb2nYzkUsCRky5CMLWcGEJl?= =?Windows-1252?Q?EVmb5ykGEdi5luVnkDgztCznNxOTfa75rM6zpWT9qWX42rfXgwb7VD8I?= =?Windows-1252?Q?pMi/5TIpZXXuw+jf+NWWJT92AZ9hmK3Yx5f4cY0NVZf4dozQcxhYTlm5?= =?Windows-1252?Q?ssGT/QYnETjcIBzkm8aJax7cQ2xspc8tx9p+l82xGgVoNd+rzCBe5LwP?= =?Windows-1252?Q?vYwC89bO4yp/7FQ+R97rRoBFL68N7GpJ1ECYrI2Kk9vJc+28ly4WrKhU?= =?Windows-1252?Q?vrG5Ot++jwmZjKZjsXd2Zvfs5BzjLOKiHoZTIuoj82QR96jEkIjkh4tc?= =?Windows-1252?Q?z+tQfFxu72ijCz3MVBC2bNR26bYiElrLStyBbg12bJ1bYMPs8XAF/FHF?= =?Windows-1252?Q?tB3cu/gXigOoxCbEIKgXVsWjw/CLePvngmrG2nbXoKIUN2T+vGYH7DNd?= =?Windows-1252?Q?8aTxIOxwNaWGjxVaRxQThBpwgW6M03hKXvgqUA2LnMUHr+R+LyAM9B9e?= =?Windows-1252?Q?oTmlfT8UgxV46wDaGIcelPZvfw0kgDbB3j+cOeZYT1aUcrDmvPdEQxfi?= =?Windows-1252?Q?d/8wmqYluEC2uj0X4uUYSgK2zyvEOllwQp8tnI5NsR2fUbSuxac9zYdE?= =?Windows-1252?Q?jYpPM/LlOlNza/xntLQMVSJuP6I3neE2782jdDcovI0bVilntVxKIWyS?= =?Windows-1252?Q?tfceybPi7IUeVYABRGtg7STGV2wHaIOiJ3o89nZmvWXBvUaUxNfDSqnA?= =?Windows-1252?Q?8YuLC6NGSvmDkQ+SKTYKr9Cp8ZP7obUfrnQ+fN0vqlUwU3Nh646htKvI?= =?Windows-1252?Q?8FHMNjKNZLJTYbV9zsM6EtAeZXH4U8DLkei6D82TsKQi1TTpxEXclbBo?= =?Windows-1252?Q?0lUKchNZHKKN/5rPyHp0gof8vVhg9r/lkhs6Iu3Ga/NYN8KsTKtJ/nxF?= =?Windows-1252?Q?EjGBMZ+QO6chpEmhyuipLrrEMJNHmi8+zRNwHuiJFVEDo3X6V/gzpv0x?= =?Windows-1252?Q?KEIlhN8YtTmNvPAww7L1sCdXGApcF5FE0u7UFB2v69dxfl0riZu2u2Tk?= =?Windows-1252?Q?rErdBThMQDs1ynmwC54/MFuc39/5ithh7p5jKjf8CBHy7HvAs5ZjsMG2?= =?Windows-1252?Q?EPnTnJblcb8zTHXHPe4W+H8xXliaqw7i5CzjowK5NvK83F6NIvhxDKTn?= =?Windows-1252?Q?L8iGFROuc0/0oeEbY/qn7qzPGiDOwopZi7UOOobHEk/gNL3vvDyMC2us?= =?Windows-1252?Q?58hbpPH8VHnwWRSSY49wKhn8+bie/BlpiOND0EbK4fomfmRZIv5Q5K+C?= =?Windows-1252?Q?8efOsYl3JZCIYCED+/Nc9CHXBqhRzp5Ob3U2ATv5eyLLSwYGHUqCX109?= =?Windows-1252?Q?trhCAu7ccGW3MLuXLP1OXkz9N3+15csDYk8ceB1cXI54NGbg6R7Z4dU0?= =?Windows-1252?Q?Fvvey0ayjXTHCO7PWq3UcMrATkEkhHEbbmR36cJaR13m0/MUWtcYydI5?= =?Windows-1252?Q?R1SM0NLkKdP7yQLKBmOLDtu/U6KPMqIs8BhwGSa+Yit?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 6:c5vy1/wSJOueCBjABaPzu4w+jb6SmlimCOetltMMurdW6BNZaDCoZPEBplR/k2TQP04YavzJvFco0ky779cmLR5VMr1zRJX9NPWswflSRVrQmFkPpAoyMZBWHZyHvSGYh/TAaT9uWiQCh0bq9wmTLtoOiYOcTSDlBvwa6DKASNGneUbOyreMcbzzGMpjBpdVY+id89oWwtz5e3H5/cZdTeT/rSnnuabvECn6+lRCm2kAD/RTm92CIhQTtwrNTQOBAL48J4za0v0rUg/asa7acXkJv2CKs6dpuLKFg7BB6dfX+SbxL6G6OengCm6+/oSG3OmKQqtbZkD3Fn/9gXrstw==; 5:KkfprP3NG2mpqb7lt09/CO60hKHcLWjb6woP61Vp8N6F8LjKpHz7q/99WG7AeqgNe3yiJT1EOQhxFocs93XWElBrSNlezNkSakXuY77O9WxKxW0uti7VdOf2k6fIvNnjIQfkArtgrZpGwdu2CO/U3tmM1g/4r6nA+efVTPK4sgI=; 24:Wh3QmOZCUiFYhLFUKYzHr5xOlsYLpBCjFBr6cuBjZ6Vqp9mbFOQO0jqM4iNjI2y5IqVBPU5i0kuujGctnW7hKPKxiehu8S6G3V4+hib4T1I=; 7:2/xf5DSqZuc+bDQoyhpd4DOOeXj+IDiszb3264VhvSXfAUm0T6KdzmC/C9/llJi4ipeUWktpuElc3lk43jPuBPLnCnCGBckWssVptZjxOLTm5YUZR6uH6e3BE4LoaiQ4iCAfrGlv3x5TnI2c/8oG7uRDWLp62chUNIq5jtlHSIT1vi1KurUFg6bXIGPEOoxGRx6vmysn/2uSNzaQaxH7PwHl0QmHhplfnao46BtWDfM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2017 04:53:54.3667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3091 Subject: Re: [dpdk-dev] [PATCH v6 8/8] mempool: notify memory area to pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 04:53:58 -0000 Hi Olivier, On Monday 25 September 2017 11:18 PM, santosh wrote: > On Monday 25 September 2017 12:41 PM, Olivier MATZ wrote: >> On Thu, Sep 07, 2017 at 09:00:42PM +0530, Santosh Shukla wrote: >>> + * Mempool handler usually get notified once for the case of mempool get full >>> + * range of memory area. However, if several memory areas exist then mempool >>> + * handler gets notified each time. >> Not sure I understand this last paragraph. > Refer v5 history [1] for same. > > [1] http://dpdk.org/dev/patchwork/patch/28419/ > > there will be a case where mempool handler may have more than one memory example, no-hugepage case. > In that case _register_memory_area() ops will be called for more than once. > > In v5, you suggested to mention this case explicitly in api description. > > If your not clear with write up then could you propose one and also are you fine > with [8/8] patch beside above note? planning to send v7 by tomorrow, appreciate if you answer question. Ping? IMO, remove above description keep it like: "API to notify the mempool handler if a new memory area is added to pool." Is it ok with you? Can you pl. confirm, I need to send v7 and we want this series in -rc1, its blocking octeontx mempool and nw driver.. delayed review blocking progress. >>> + * >>> + * @param mp >>> + * Pointer to the memory pool. >>> + * @param vaddr >>> + * Pointer to the buffer virtual address >>> + * @param paddr >>> + * Pointer to the buffer physical address >>> + * @param len >>> + * Pool size >> Minor: missing dot at the end > ok. > >>> + * @return >>> + * - 0: Success; >>> + * - ENOTSUP: doesn't support register_memory_area ops (valid error case). >> Missing minus before ENOTSUP. >> The dot should be a semicolon instead. >> > ok. > > Thanks. >