From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 044C35F3C for ; Thu, 4 Oct 2018 05:15:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 20:15:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,338,1534834800"; d="scan'208";a="76050365" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.249.174.2]) ([10.249.174.2]) by fmsmga008.fm.intel.com with ESMTP; 03 Oct 2018 20:14:57 -0700 To: "Burakov, Anatoly" , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com, wenzhuo.lu@intel.com, jerin.jacob@caviumnetworks.com Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1538483726-96411-1-git-send-email-jia.guo@intel.com> <1538483726-96411-4-git-send-email-jia.guo@intel.com> <34b1d516-14b7-876b-7cd9-3854dbc2d0a9@intel.com> From: Jeff Guo Message-ID: <667cbd78-9189-1498-b430-3e501836cb19@intel.com> Date: Thu, 4 Oct 2018 11:14:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <34b1d516-14b7-876b-7cd9-3854dbc2d0a9@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v12 3/7] bus: add sigbus handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 03:15:02 -0000 On 10/2/2018 10:32 PM, Burakov, Anatoly wrote: > On 02-Oct-18 1:35 PM, Jeff Guo wrote: >> When a device is hot-unplugged, a sigbus error will occur of the >> datapath >> can still read/write to the device. A handler is required here to >> capture >> the sigbus signal and handle it appropriately. >> >> This patch introduces a bus ops to handle sigbus errors. Each bus can >> implement its own case-dependent logic to handle the sigbus errors. >> >> Signed-off-by: Jeff Guo >> Acked-by: Shaopeng He >> --- >> v12->v11: >> no change. >> --- >>   lib/librte_eal/common/include/rte_bus.h | 18 ++++++++++++++++++ >>   1 file changed, 18 insertions(+) >> >> diff --git a/lib/librte_eal/common/include/rte_bus.h >> b/lib/librte_eal/common/include/rte_bus.h >> index 1bb53dc..201454a 100644 >> --- a/lib/librte_eal/common/include/rte_bus.h >> +++ b/lib/librte_eal/common/include/rte_bus.h >> @@ -182,6 +182,21 @@ typedef int (*rte_bus_parse_t)(const char *name, >> void *addr); >>   typedef int (*rte_bus_hot_unplug_handler_t)(struct rte_device *dev); >>     /** >> + * Implement a specific sigbus handler, which is responsible for >> handling >> + * the sigbus error which is either original memory error, or >> specific memory >> + * error that caused of device be hot-unplugged. When sigbus error >> be captured, >> + * it could call this function to handle sigbus error. >> + * @param failure_addr >> + *    Pointer of the fault address of the sigbus error. >> + * >> + * @return >> + *    0 for success handle the sigbus. >> + *    1 for no bus handle the sigbus. > > I think the comment here should be reworded. I can't parse "no bus > handle the sigbus" - what does that mean, and how is it different from > an error? > ok, let me detail more.