From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5C7501B90E for ; Wed, 4 Jul 2018 00:35:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C586121B46; Tue, 3 Jul 2018 18:35:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 03 Jul 2018 18:35:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=PmjHHwbHMzqg+7kdCoa1nqyg2o F6dYfJS5BY4qQPSVs=; b=FdFe43reQstrqxPRptiplTvAXfqZfhgPlMoZr0SuY0 HqFd4m5/oFypSS37Fzy2OQxCrBN/lz6uQPffN3tVCyaIxUnk50ZH/ke2gDv53ZSD Sf5Zq0pOe/B58/t8enaJy9ATi75p6C4BiVpbvDGIvFKz+NH7bK9bUtRGK5EV++rj g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=PmjHHw bHMzqg+7kdCoa1nqyg2oF6dYfJS5BY4qQPSVs=; b=nDOQ8rtG5g1C7CDUkrovPj ihCDL982m62+UQq67XYmU4bd7uY/mldCtWYeN+cUX8AkNeODfgwoTEl34kDaKn7l vv5oG/EH6KqDbNtxcXAJXxrElPKlE5dQbBVvSQsBkBXXUIR0n1sbGspD90j8fU7h KeF2vXmx7NK4NdofCFilTPPTIUnOcBN02mUD8FbT91yrjTLxYX3nrnEjgt9i39Hg WXo2brt/WRR86tVJIpl29NEdhM+1/QgbDvmAdYe0cOGMWtzgJ5N0Pxjri49tDSCp Famu4wLBErEj46dvcJ4ctZXgk9OJfqdDNNl1r87iOSCH+lq3MVZwfho96jefiNbA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B3B41026B; Tue, 3 Jul 2018 18:35:51 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: dev@dpdk.org, "Burakov, Anatoly" , "Ananyev, Konstantin" , "Richardson, Bruce" , "Yigit, Ferruh" , "Shelton, Benjamin H" , "Vangati, Narender" Date: Wed, 04 Jul 2018 00:35:50 +0200 Message-ID: <6685892.NTdOAgpAes@xps> In-Reply-To: <13002513.5KdvWrtVWc@xps> References: <20180607123849.14439-1-qi.z.zhang@intel.com> <039ED4275CED7440929022BC67E7061153243554@SHSMSX103.ccr.corp.intel.com> <13002513.5KdvWrtVWc@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 22:35:53 -0000 03/07/2018 23:57, Thomas Monjalon: > 03/07/2018 17:03, Zhang, Qi Z: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > > +do_eth_dev_attach(const char *devargs, uint16_t *port_id); > > > > > > > > > > So you are duplicating rte_eth_dev_attach which is flawed in its > > > > > design and should be deprecated... > > > > > > > > OK, just to know this, but I guess it will not be the issue, if we move the dev > > > sync mechanism into eal layer in future right? > > > > > > Future is now :) > > > We must stop mixing devargs and port id in the same layer. > > > > Ok, is there any RFC I can learn? > > RFC for what? > It is just a design issue that we must stop propagating. Please read at this commit, which is 2 years old: http://git.dpdk.org/dpdk/commit/?id=b0fb26685570 It was starting to fix early design mistakes, but unfortunately it is not yet totally fixed today. > > > > > As you may have noticed, rte_eth_dev_attach() is calling > > > > > rte_eal_hotplug_add() which manages the EAL device. > > > > > It is wrong because the relation between an ethdev port and an EAL > > > > > device is not a 1:1 mapping. > > > > > We must manage the ethdev port as one of the possible abstractions > > > > > of a device represented by rte_device.