From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id C6B5C68AA for ; Thu, 18 Dec 2014 00:40:15 +0100 (CET) Received: by mail-wi0-f181.google.com with SMTP id r20so526437wiv.14 for ; Wed, 17 Dec 2014 15:40:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=XltLzzQZG2UWCu7OmbxyA90Y1rF2U/fX4cPY9mtqq78=; b=ZB2eKoFNU+ahm857ysf5mdpP/tQUy77g5L8lf4Q6wV63B8Ziyxl1qHT6wOBcTIg9Hv 96BtIELFwf1Ek7omKEYWWGvj1ihf04vOqVIvmDrYLqx0PJMa95VxmA2pkI7KXsY3gl1V 9y2xoSu9akMr8yY4o457djrsvJt7mDbWPn1fG1ZmGBKP1WbUeoVJC0YsjDTqqYsXFfap 2J60LnHqQbE/u8gS1/SefIGxjHAa/x4yhmAC7RJuhniHP0sB4AsIEcBvcnOcJ+nM+rAC 2x4aHQh9K+ANb6HkB36X+i2Fbj7VkXmtDRXG/6bcGX14AEpyRgJHoTHUdqk4w/9vtbUW psAg== X-Gm-Message-State: ALoCoQmvVf9Ru2zYCqhyH+e/Ihg7DDzvCHVgGLyZ3wKOcO7UuvgIi1iMoM7L4cykCHzlX6064ECb X-Received: by 10.180.186.40 with SMTP id fh8mr19182375wic.40.1418859615633; Wed, 17 Dec 2014 15:40:15 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id w10sm6882352wje.10.2014.12.17.15.40.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Dec 2014 15:40:14 -0800 (PST) From: Thomas Monjalon To: Jincheng Miao Date: Thu, 18 Dec 2014 00:39:48 +0100 Message-ID: <6695240.a3DIkdZQyy@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <5490F801.3020807@redhat.com> References: <1418275627-17145-1-git-send-email-jmiao@redhat.com> <4943955.d3ixVqDNjM@xps13> <5490F801.3020807@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: fix build on RHEL6.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 23:40:16 -0000 2014-12-17 11:26, Jincheng Miao: > On 12/16/2014 11:21 PM, Thomas Monjalon wrote: > > 2014-12-11 13:27, Jincheng Miao: > >> RHEL6.5 kernel is based on 2.6.32. But there are two changing > >> from 2.6.35: > >> 1. socket struct is changed > >> It wrappered previous wait_queue_head_t of socket to > >> struct socket_wq. So for the kernel older than 2.6.35, we should > >> directly use socket->wait instead. > >> > >> 2. new function sk_sleep() > >> This function is implemented from 2.6.35 to obtain wait queue > >> from struct sock. This patch adds a macro in kni/compat.h > >> to be compatible with older kernels. > > I don't understand the relation between RHEL-6.5 and the kernel 2.6.35. > > The patch seems not related to RHEL at all. > > Please start your explanations by describing what is the problem > > you want to solve. > > Hi Thomas, > > This patch is working for resolving the problem I found on RHEL6.5: > http://dpdk.org/ml/archives/dev/2014-December/009827.html > > Because the root cause is socket struct change from 2.6.35, so this > patch also fits for all kernels older than 2.6.35. > > Sorry for the ambiguous description, I think the title should be: > "kni: more compatibility for kernel older than 2.6.35" Applied with title "kni: fix build with kernel < 2.6.35 and vhost debug enabled" and error log. Thanks -- Thomas