From: Heinrich Kuhn <heinrich.kuhn@netronome.com>
To: Yunjian Wang <wangyunjian@huawei.com>, dev@dpdk.org
Cc: xudingke@huawei.com
Subject: Re: [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format
Date: Thu, 16 Jan 2020 10:12:06 +0200 [thread overview]
Message-ID: <66c18748-83ef-1b29-bc34-37745154a31b@netronome.com> (raw)
In-Reply-To: <1578923375-23820-1-git-send-email-wangyunjian@huawei.com>
> Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/net/nfp/nfp_net.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 3aafa7f80..64d9d218d 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -1377,9 +1377,9 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev)
> PMD_DRV_LOG(INFO, " Port %d: Link Down",
> dev->data->port_id);
>
> - PMD_DRV_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
> - pci_dev->addr.domain, pci_dev->addr.bus,
> - pci_dev->addr.devid, pci_dev->addr.function);
> + PMD_DRV_LOG(INFO, "PCI Address: " PCI_PRI_FMT,
> + pci_dev->addr.domain, pci_dev->addr.bus,
> + pci_dev->addr.devid, pci_dev->addr.function);
> }
>
> /* Interrupt configuration and handling */
>
Acked-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
next prev parent reply other threads:[~2020-01-16 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 13:49 Yunjian Wang
2020-01-16 8:12 ` Heinrich Kuhn [this message]
2020-01-16 18:41 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66c18748-83ef-1b29-bc34-37745154a31b@netronome.com \
--to=heinrich.kuhn@netronome.com \
--cc=dev@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).