* [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format
@ 2020-01-13 13:49 Yunjian Wang
2020-01-16 8:12 ` Heinrich Kuhn
0 siblings, 1 reply; 3+ messages in thread
From: Yunjian Wang @ 2020-01-13 13:49 UTC (permalink / raw)
To: dev, heinrich.kuhn, jan.gutter; +Cc: xudingke, Yunjian Wang
Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/nfp/nfp_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 3aafa7f80..64d9d218d 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -1377,9 +1377,9 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev)
PMD_DRV_LOG(INFO, " Port %d: Link Down",
dev->data->port_id);
- PMD_DRV_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
- pci_dev->addr.domain, pci_dev->addr.bus,
- pci_dev->addr.devid, pci_dev->addr.function);
+ PMD_DRV_LOG(INFO, "PCI Address: " PCI_PRI_FMT,
+ pci_dev->addr.domain, pci_dev->addr.bus,
+ pci_dev->addr.devid, pci_dev->addr.function);
}
/* Interrupt configuration and handling */
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format
2020-01-13 13:49 [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format Yunjian Wang
@ 2020-01-16 8:12 ` Heinrich Kuhn
2020-01-16 18:41 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Kuhn @ 2020-01-16 8:12 UTC (permalink / raw)
To: Yunjian Wang, dev; +Cc: xudingke
> Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/net/nfp/nfp_net.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 3aafa7f80..64d9d218d 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -1377,9 +1377,9 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev)
> PMD_DRV_LOG(INFO, " Port %d: Link Down",
> dev->data->port_id);
>
> - PMD_DRV_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
> - pci_dev->addr.domain, pci_dev->addr.bus,
> - pci_dev->addr.devid, pci_dev->addr.function);
> + PMD_DRV_LOG(INFO, "PCI Address: " PCI_PRI_FMT,
> + pci_dev->addr.domain, pci_dev->addr.bus,
> + pci_dev->addr.devid, pci_dev->addr.function);
> }
>
> /* Interrupt configuration and handling */
>
Acked-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format
2020-01-16 8:12 ` Heinrich Kuhn
@ 2020-01-16 18:41 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-01-16 18:41 UTC (permalink / raw)
To: Heinrich Kuhn, Yunjian Wang, dev; +Cc: xudingke
On 1/16/2020 8:12 AM, Heinrich Kuhn wrote:
>
>> Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>> ---
>> drivers/net/nfp/nfp_net.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
>> index 3aafa7f80..64d9d218d 100644
>> --- a/drivers/net/nfp/nfp_net.c
>> +++ b/drivers/net/nfp/nfp_net.c
>> @@ -1377,9 +1377,9 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev)
>> PMD_DRV_LOG(INFO, " Port %d: Link Down",
>> dev->data->port_id);
>>
>> - PMD_DRV_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
>> - pci_dev->addr.domain, pci_dev->addr.bus,
>> - pci_dev->addr.devid, pci_dev->addr.function);
>> + PMD_DRV_LOG(INFO, "PCI Address: " PCI_PRI_FMT,
>> + pci_dev->addr.domain, pci_dev->addr.bus,
>> + pci_dev->addr.devid, pci_dev->addr.function);
>> }
>>
>> /* Interrupt configuration and handling */
>>
>
> Acked-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-16 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 13:49 [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format Yunjian Wang
2020-01-16 8:12 ` Heinrich Kuhn
2020-01-16 18:41 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).