From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4ED3343A0D; Tue, 30 Jan 2024 13:17:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 345BD402AC; Tue, 30 Jan 2024 13:17:40 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2069.outbound.protection.outlook.com [40.107.220.69]) by mails.dpdk.org (Postfix) with ESMTP id 765F94026C for ; Tue, 30 Jan 2024 13:17:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qryq+HR8BcV5GSMs8rqyQpOOUvR09kssWJGIbKy8lvFVSIb7e1/LIny8OVLb9B7EkcZpW2f8LZBtwVPGKLC7aNpykAbFLdSfgngV6QTs1lOB4UhU7K2kvhIOj+WrwGjIMJ0GtsYWMLSpPQgTyorOnUgfWhdLude4ZCH2pmkQb4PNx3N5Yhym9m+98SoWeU7yw7JVC23OIp0wiMOmn6pwmq368DjBpjKYLIQrrO0Ni4/I9O+OK1UKdNBvG+97V0Dp3n8DmBaQ7v4qOttlSO/8Y1QAY7Xg1GAZKpteCvFz4JrQwGbeTnUNXrnHbyTthjprxWnjQm5HA7DbHBYi5NKJtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8IvL5iruHKIJNUUPS8P1G/qp386925zG85vUoY3LKhw=; b=RBIifS6Oz72Xt0F8pHs6n1U1DF6IgpssOcG/Rhg/fe9Tv2qiCQSKU+C6skoj2sHbf0fZ6hBSvNzWDSFP8oFo0cZgx/HQbNsY3+PRXc4OGiWM1zOcHdN5F0M/4k88fyEmt9wdxaoNM5OzdM/SHMy52poTKy8ZcQefl8fi6tykZjnGwSZumdo+OK1ijOjByZdYsQAcM6pDHCuCzQXjUY/dJZhMpAlMfVzgCNFAvTLbrtezByOlgTHFwuh3H/sIHPcTPYprs1LdaNkIA2/WPa1RjFcMCcLKa1KVU385iwZtRhEHflJSHhhBzVbClwUHxouu7o5kopuYdzDs9ycaw8c13A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8IvL5iruHKIJNUUPS8P1G/qp386925zG85vUoY3LKhw=; b=NdcLn4FPJVq3tW8GnYmCCFW3UNf6X/Rp3G3gSU6WVGp9o1iloiwXad6zAIbHccYo5msbAsheSXtM53HRcI+AYBTGowoK4aRe8+hwynqZHXGQTtdei6lcIhJVKzfgxEI4VmPlOWAmJMPMLpRqzAkVvCevpTs8Ms8lrjxUhTsKAjg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6020.namprd12.prod.outlook.com (2603:10b6:208:3d4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.22; Tue, 30 Jan 2024 12:17:32 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 12:17:32 +0000 Message-ID: <66c200cf-56e2-48f1-b386-78dbd9cdf78a@amd.com> Date: Tue, 30 Jan 2024 12:17:26 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] ethdev: fast path async flow API Content-Language: en-US To: Dariusz Sosnowski , Stephen Hemminger Cc: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko , Ori Kam , "dev@dpdk.org" References: <20231227105709.1951231-1-dsosnowski@nvidia.com> <20231228091657.14769682@hermes.local> <20240103170758.119e99d4@hermes.local> <97bbc06c-3baf-43fd-930d-27b01007f672@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0191.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6020:EE_ X-MS-Office365-Filtering-Correlation-Id: 24e63efe-cd12-48fa-2fd2-08dc218d6f44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JAMPaIv5qU63lNtMG+6ZwQrhkn0x/+0OBO6zoN4D36J5AwA9zFwWc774D8dgYXN6tofIAwrbOaf1lDZdOWEZQOadnwTqOXfVgvooTTW4v1J1MRXfMuITnnwEkPvQR2pVls3SSkBGF/mJSMZ8bmV0xRaCq/sGiJIhy/JrCDzB1c9c8EcyO2sIsWaWeGFwmIaRLV7VhcYJNkVhNqLd+/2n/h7S68h5bHt6MVWtVcwNXwj2dCTXE3uXs//P76/7hm5px36zmNzmEassEUP6ywoiTBBXNKtINZU82q/jWagt/hN2QJ9K4cYsPIhy90nhDn7JG367FAN/kvrwX7H8uw5Q2AX03n1Z4TTXrPN07XPIdThK2gnjRpNrdFr+aA2F2UNNNSYzfx14Cn+zXDmmIeqGsFNQNMEV1UGtvqye+CbR1JW3ZYqCARKD3oFZw5g151Uap/Y1zLB/2iuipgDE0S840bU4N6yMuAYsC3ciouopAvu+e4jqmVf1fK6GKPLe4pYwXPo0NP1jYXqNh+P7ylWD9qCHss3mCbpHkjoP2qEvO3lt1Su/eQeozhmheC2chrWdCCXnloMgJdVJzoEhJ3PzsyhpbKSsIG/dquBSDjN3ND4mB7TCYjmH3J4X8JB7TcO1RStASvxQisyPcprQ43gRJ4uLi/rT9sUT8xk5qm8uPSfQJ4lmHWkK0cjJ6hR1AZY9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(136003)(376002)(39860400002)(346002)(230273577357003)(230173577357003)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(36756003)(2906002)(41300700001)(54906003)(31696002)(110136005)(66476007)(66556008)(66946007)(86362001)(316002)(6512007)(53546011)(6506007)(2616005)(83380400001)(26005)(6486002)(478600001)(6666004)(44832011)(38100700002)(4326008)(8936002)(8676002)(31686004)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eStEb3JzNDZKWExQdnFaTjRDaHcrREprWDJ3Q0VPbzNWUXA4U0V6YmhMWmMr?= =?utf-8?B?TmRTNEV4VXpFRThpakpuMXZpT2puMnd3YTljZmJJR00rYmx5U3VYRmNVa3BP?= =?utf-8?B?dUFzNktKd0xFL1pCdjNCT1Jyc29COGRGOC9pRXBJZ3g1M1p3VlhCUlNBK1JX?= =?utf-8?B?VGNnenArT1hZYjY4enVCN09FbzJ1NFFPalZRYXZweFRwcWFwdk9pZU9vb1dm?= =?utf-8?B?bnR4ZUttc05SNUtJd3IvbWk0cFFFcEd0cXlyMTNpV0dDRkEzSmdVbnh6dTN2?= =?utf-8?B?dWtjUFBaRllnU0Y0SkRoWW55S015WU1kVTluTzMvUUM2UjlydW1ycDUyZGRs?= =?utf-8?B?emVEQ0V2L3ZUdnVCWVZsVjhveTVNSlNFWGs4SnJSWVYxZVhyRjB5YzJVRkRT?= =?utf-8?B?NmhuQUlsM2txVXYreFQ3TytvQS9SaUJMalA2clNUNXhMNkg0b093WHJNalFm?= =?utf-8?B?MEhxWktkRURHVE04dlFuNGpXYW9aejNRckJaV2RUcHhrZ1dHNHVBbFZZakh3?= =?utf-8?B?MlVYbkt2YXNwQXByaExXQUphNkh4VnRwU0FIYUtwMlRuNEdRalhnb3RubHNm?= =?utf-8?B?RXQ5dFlBeW0vaG0yd3lLUnlZc1dTeGJEVW1sU0lxZUlPY0FiQzVUTVRxT0cz?= =?utf-8?B?Wk44RnJNS3g2VnJtNFNQcEpXMWUrd2N0VGpxSEdrdS9Zbmx6cUtQc3o5N1ZP?= =?utf-8?B?SWN1d1c3dGF6S0ppRjVub1pPUkVyZTFQWTQxMGUzK3AvanBjdWZlTUNEdWtS?= =?utf-8?B?dXQramJPbkRiTnEzWUExdWUvYnZubS9FM3dIa1lIM2hXdHBKWHUyZHdTb211?= =?utf-8?B?VHZxeGsxcllSMzZQcklyL1JYTWFrZjg5bXZKaCt5bURWUDE1S2JXSnlyNEd2?= =?utf-8?B?QnRzbzNMYXRaOXl6MTJZREc3MmNTZFJibUFqQjU1b3gzRURSdGdDQkRPZTNX?= =?utf-8?B?RHV3eVpxbWRtTHJVdjlPUjAvMmNRanYwdnVrYzFYb3BGYnorUEhzZUtoWmZN?= =?utf-8?B?SEpscy9XdVZHM2gvS0tmK1Y5eGc5SS96eVBTMjZyTFhMY3N2bHNNQjRxSlZk?= =?utf-8?B?cEFQbDlkeVFqV0NJYzlqcmFIeUNZUjZlRFRNNjNsT2V3Uk5sSnpWQ1d0RkpJ?= =?utf-8?B?dnlRWktoYnB1TFRZa2YrbjFHSGQ1REpRZ3ZwWWtWL0FEZGlMUXhCSzNJZ0Vs?= =?utf-8?B?MlV3dmhtMnBVSDF4UlhHU3EydHk3c2NXUHVPNFdKQ2llaGZkTWtQK01nd052?= =?utf-8?B?OG1POGFGSVByWlVWSFgyR0oxMzNXNDJzUTFyOEhFK1g0YkwwTStkUUtwL2d0?= =?utf-8?B?TUs2MlpmaHMwWXNBRm9pelAyN0ZySk53QTQybERMajFFaXYrazVqWTliUzVr?= =?utf-8?B?OEpDWHMySkVrN2ZqZWZ5ZStFWldhK0dJZlBYekZES3VVNU4xc216dGF0REl6?= =?utf-8?B?bklsbWIxT0hZampRVkZkRXdIZU02Sytjbk5leEVaNWJqSlF0c21ESjhVd0lp?= =?utf-8?B?eitHRUthQWlLcjErODQ3U2hReURWcnBYbXJGL2JtVlRnTWZ4RDhyZEVKQ082?= =?utf-8?B?M3NwTGFJL0E1NHdjbXFtMlNRQ1Iyc3dGNFNYQTJmMXoxN0h2cmRKN1FPOGJ2?= =?utf-8?B?aHZNSzBvaURXYkg4Tk5lMkNWZ0hIcC9ZZEZ0a2JQaDQ5UlQ2b0NxM05PaEYw?= =?utf-8?B?MzluZ2hLUGsvUVd5MkZEYTBTN3NSbjBKY1lhYTVWMkJLbEI0NmtubUlzRkNl?= =?utf-8?B?WTRtRWF5Q1UycnJqckRxSWNtSWZka2xBZHZWVExwUTBEZUNndUhkOUdnWG5F?= =?utf-8?B?eGRXU2pnOTNqQlc1SUdEZm1SSDBsNmRUQktQQ1pPRUt3cUNMR29yRjhIWERK?= =?utf-8?B?cDNDMXNMc0NZb0gzOVpNK2pTWERkWkpnY3V2RTE1SloxMTZQeUdsRXpBTlNi?= =?utf-8?B?dmFGcUVwQ1NhTWx6UVVFM1puMG1BVFRlbG5LTXA3bWZyc00xazFBWXNMSVhy?= =?utf-8?B?VDR6a1BLNGNQMFJLM1B4TXBLOW5IdmN1dDdFM3BBVTdlVTJyam9nSloxakh5?= =?utf-8?B?eE00bkZEb2E5L0NObDFqbTNPUlE3ekU1TStma0paclVLU3BRdEgrZjB4TkxH?= =?utf-8?Q?pAn4=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24e63efe-cd12-48fa-2fd2-08dc218d6f44 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 12:17:32.3136 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R+yrsWZxraWbzSzyVWQt9Pmmfm6xgB18kwPSFJPUbgNxQP7Rl9WNHq8rxzc8BapC X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6020 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/30/2024 12:06 PM, Dariusz Sosnowski wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, January 29, 2024 18:36 >> To: Dariusz Sosnowski ; Stephen Hemminger >> >> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; >> Andrew Rybchenko ; Ori Kam >> ; dev@dpdk.org >> Subject: Re: [RFC] ethdev: fast path async flow API >> >> On 1/29/2024 1:38 PM, Dariusz Sosnowski wrote: >>> Hi all, >>> >>>> -----Original Message----- >>>> From: Dariusz Sosnowski >>>> Sent: Tuesday, January 23, 2024 12:37 >>>> To: Stephen Hemminger >>>> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; >>>> Ferruh Yigit ; Andrew Rybchenko >>>> ; Ori Kam ; >>>> dev@dpdk.org >>>> Subject: RE: [RFC] ethdev: fast path async flow API >>>> >>>> Hi Stephen, >>>> >>>> Sorry for such a late response. >>>> >>>> From: Stephen Hemminger >>>> Sent: Thursday, January 4, 2024 02:08 >>>>> On Wed, 3 Jan 2024 19:14:49 +0000 >>>>> Dariusz Sosnowski wrote: >>>>>> In summary, in my opinion extending the async flow API with bulking >>>>> capabilities or exposing the queue directly to the application is not >> desirable. >>>>>> This proposal aims to reduce the I-cache overhead in async flow API >>>>>> by >>>>> reusing the existing design pattern in DPDK - fast path functions >>>>> are inlined to the application code and they call cached PMD callbacks. >>>>> >>>>> Inline needs to more discouraged in DPDK, because it only works if >>>>> application ends up building with DPDK from source. >>>>> It doesn't work for the Linux distro packaging model and symbol >>>>> versioning, etc. >>>> >>>> I understand the problem. In that case, I have a proposal. >>>> I had a chat with Thomas regarding this RFC, and he noticed that >>>> there are 2 separate changes proposed here: >>>> >>>> 1. Per-port callbacks for async flow API. >>>> - Moves specified callbacks to rte_flow_fp_ops struct and allow >>>> PMDs to register them dynamically. >>>> - Removes indirection at API level - no need to call rte_flow_ops_get(). >>>> - Removes checking if callbacks are defined - either the default >>>> DPDK callback is used or the one provided by PMD. >>>> 2. Make async flow API functions inlineable. >>>> >>>> Change (1) won't break ABI (existing callbacks in rte_flow_ops can be >>>> marked as deprecated for now and phased out later) and in my opinion >>>> is less controversial compared to change (2). >>>> >>>> I'll rerun the benchmarks for both changes separately to compare >>>> their benefits in isolation. >>>> This would allow us to decide if change (2) is worth the drawbacks it >>>> introduces. >>>> >>>> What do you think? >>> >>> I split the RFC into 2 parts: >>> >>> 1. Introduce per-port callbacks: >>> - Introduce rte_flow_fp_ops struct - holds callbacks for fast path calls, for >> each port. PMD registers callbacks through rte_flow_fp_ops_register(). >>> - Relevant rte_flow_async_* functions just pass arguments to fast path >> callbacks. Validation checks are done only if RTE_FLOW_DEBUG macro is >> defined. >>> - Biggest difference is the removal of callback access through >> rte_flow_get_ops(). >>> 2. Inline async flow API functions. >>> - Relevant rte_flow_async_* functions definitions are moved to rte_flow.h >> and made inlineable. >>> >>> Here are the results of the benchmark: >>> >>> | | Avg Insertion | Diff over baseline | Avg >>> | Deletion | Diff over baseline | >>> |-----------------------|---------------|--------------------|--------------|------------- >> -------| >>> | baseline (v24.03-rc0) | 5855.4 | | 9026.8 | | >>> | applied (1) | 6384.2 | +528.8 (+9%) | 10054.2 | +1027.4 >> (+11.4%) | >>> | applied (2) | 6434.6 | +579.2 (+9.9%) | 10011.4 | +984.6 >> (+10.9%) | >>> >>> Results are in KFlows/sec. >>> The benchmark is continuously inserting and deleting 2M flow rules. >>> These rules match on IPv4 destination address and with a single action >> DROP. >>> Flow rules are inserted and deleted using a single flow queue. >>> >>> Change (2) improves insertion rate performance by ~1% compared to (1), >> but decreases deletion rate by ~0.5%. >>> Based on these results, I think we can say that making rte_flow_async_*() >> calls inlineable may not be worth it compared to the issues it causes. >>> >>> What do you all think about the results? >>> >> >> Hi Dariusz, >> >> As discussed before, converting APIs to static inline functions or exposing >> 'rte_eth_dev' has cons but with only applying first part above seems get rid of >> them with reasonable performance gain, so I think we can continue with this >> approach and continue to reviews. >> >> Most of the 'rte_flow_async_*' are already missing the function validity check, >> so having a default (dummy?) rte_flow_fp_ops for them seems even an >> improvement there. >> >> >> Only previously 'struct rte_flow_ops' was coming from drivers, ethdev layer >> doesn't need to maintain anything. >> But with 'rte_flow_fp_ops' struct, ethdev needs to store another array with >> fixed ('RTE_MAX_ETHPORTS') size which will be another blocker in the future >> to convert this fixed arrays to dynamically allocated arrays. >> >> For this, does it still help we add an a new field to "struct rte_eth_dev", like >> "struct rte_flow_ops *flow_ops", similar to 'dev_ops'? >> The indirection still will be there, but eliminate 'rte_flow_get_ops()' >> call and checks comes with it. >> If makes sense, is there a chance to experiment this and get some performance >> numbers with it? > Which option do you have in mind specifically? > > 1. Keeping only fast path callbacks in "dev->flow_ops", so "struct rte_eth_dev" will hold only a pointer to "struct rte_flow_fp_ops" as defined in RFC. > - Only async flow API will use "dev->flow_ops->callback". > - Other APIs will go through "rte_flow_ops_get()" > 2. Keeping all flow callbacks in "dev->flow_ops", so "struct rte_flow_ops". > - As a result, I think that "rte_flow_get_ops()" could be removed altogether assuming that all functions have default implementation, > checking for port validity (ENODEV if port not valid) and returning ENOSYS. > > Regardless of the version, I can experiment with additional indirection. > > Both can work, has some cons, I think "rte_flow_ops_get()" is more clear approach and rte_flow APIs already using it, so no change is required, but using separate struct for fast path will create two different structs drivers needs to fill, and both uses slightly different way to populate which is not nice. For this RFC I think we can go with option 1, and consider updating rest if there is more motivation for it.