From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 122FFA00E6 for ; Mon, 8 Jul 2019 18:47:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FA2C3256; Mon, 8 Jul 2019 18:47:29 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id C49E1324D for ; Mon, 8 Jul 2019 18:47:27 +0200 (CEST) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x68GauSN111532 for ; Mon, 8 Jul 2019 12:47:27 -0400 Received: from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202]) by mx0b-001b2d01.pphosted.com with ESMTP id 2tm6nryp0d-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 08 Jul 2019 12:47:27 -0400 Received: from localhost by e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Jul 2019 17:47:26 +0100 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e12.ny.us.ibm.com (146.89.104.199) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 8 Jul 2019 17:47:24 +0100 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x68GlNWg49742178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 Jul 2019 16:47:23 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 54F27124052; Mon, 8 Jul 2019 16:47:23 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C67E1124054; Mon, 8 Jul 2019 16:47:22 +0000 (GMT) Received: from Davids-MacBook-Pro.local (unknown [9.70.85.114]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 8 Jul 2019 16:47:22 +0000 (GMT) To: Thomas Monjalon Cc: dev@dpdk.org, Takeshi Yoshimura , dwilder@us.ibm.com References: <20190607022830.2044-1-tyos@jp.ibm.com> <4027907.MzmCEAoYMI@xps> From: David Christensen Date: Mon, 8 Jul 2019 09:47:21 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <4027907.MzmCEAoYMI@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19070816-0060-0000-0000-0000035A5CBA X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011397; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01229285; UDB=6.00647397; IPR=6.01010544; MB=3.00027635; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-08 16:47:24 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19070816-0061-0000-0000-00004A0F10E5 Message-Id: <66dc5ae0-22f2-86e2-e98a-7629d335c9f4@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-08_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907080206 Subject: Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Please, any review or ack for this patch? > > 07/06/2019 04:28, Takeshi Yoshimura: >> sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. >> However, Linux 4.17 or before returns incorrect page_shift for Power9. >> I added the code for retrying creation of sPAPR DMA window. >> >> Signed-off-by: Takeshi Yoshimura >> --- >> lib/librte_eal/linux/eal/eal_vfio.c | 26 +++++++++++++++++++++++--- >> 1 file changed, 23 insertions(+), 3 deletions(-) > I've shared my comments with Takeshi and I don't think the patch is ready in it's current state. It appears to modify x86 functionality and I'm not comfortable with signing off on that since it's in an anrea I'm not familiar with. Dave