* [dpdk-dev] [PATCH v1 1/2] config: enable more than 128 cores for Arm platform
2018-11-21 11:10 [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Joyce Kong
@ 2018-11-21 11:10 ` Joyce Kong
2018-11-21 11:10 ` [dpdk-dev] [PATCH v1 2/2] config: enable more than 128 cores for meson build Joyce Kong
` (3 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Joyce Kong @ 2018-11-21 11:10 UTC (permalink / raw)
To: dev; +Cc: thomas, jerin.jacob, Honnappa.Nagarahalli, gavin.hu, stable
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on Arm platform.
Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
1 file changed, 1 insertion(+)
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 1842744..a6ed90c 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -6,3 +6,4 @@
CONFIG_RTE_TOOLCHAIN="gcc"
CONFIG_RTE_TOOLCHAIN_GCC=y
+CONFIG_RTE_MAX_LCORE=256
--
2.7.4
^ permalink raw reply [flat|nested] 15+ messages in thread* [dpdk-dev] [PATCH v1 2/2] config: enable more than 128 cores for meson build
2018-11-21 11:10 [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Joyce Kong
2018-11-21 11:10 ` [dpdk-dev] [PATCH v1 1/2] config: enable more than 128 cores for Arm platform Joyce Kong
@ 2018-11-21 11:10 ` Joyce Kong
2018-11-21 11:13 ` [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Thomas Monjalon
` (2 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Joyce Kong @ 2018-11-21 11:10 UTC (permalink / raw)
To: dev; +Cc: thomas, jerin.jacob, Honnappa.Nagarahalli, gavin.hu, stable
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on thundex platform
for meson build.
Fixes: 200b88cb ("build: detect micro-arch on ARM")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
config/arm/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index b755138..020df09 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -51,7 +51,7 @@ flags_cavium = [
['RTE_MACHINE', '"thunderx"'],
['RTE_CACHE_LINE_SIZE', 128],
['RTE_MAX_NUMA_NODES', 2],
- ['RTE_MAX_LCORE', 96],
+ ['RTE_MAX_LCORE', 256],
['RTE_MAX_VFIO_GROUPS', 128],
['RTE_USE_C11_MEM_MODEL', false]]
flags_dpaa = [
--
2.7.4
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform
2018-11-21 11:10 [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Joyce Kong
2018-11-21 11:10 ` [dpdk-dev] [PATCH v1 1/2] config: enable more than 128 cores for Arm platform Joyce Kong
2018-11-21 11:10 ` [dpdk-dev] [PATCH v1 2/2] config: enable more than 128 cores for meson build Joyce Kong
@ 2018-11-21 11:13 ` Thomas Monjalon
2018-11-21 11:41 ` Joyce Kong (Arm Technology China)
2018-11-21 11:27 ` [dpdk-dev] [PATCH v2] config: enable more than 128 cores " Joyce Kong
2018-11-22 7:01 ` [dpdk-dev] [PATCH v3] " Joyce Kong
4 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2018-11-21 11:13 UTC (permalink / raw)
To: Joyce Kong
Cc: dev, jerin.jacob, Honnappa.Nagarahalli, gavin.hu, hemant.agrawal
Hi,
21/11/2018 12:10, Joyce Kong:
> v1: change the max core setting to 256 for arm64 platform
>
> Joyce Kong (2):
> config: enable more than 128 cores for Arm platform
> config: enable more than 128 cores for meson build
2 comments:
- It doesn't need to be split in 2 commits.
- Are you sure you want this change in 18.11? No risk?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform
2018-11-21 11:13 ` [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Thomas Monjalon
@ 2018-11-21 11:41 ` Joyce Kong (Arm Technology China)
2018-11-21 20:09 ` Stephen Hemminger
0 siblings, 1 reply; 15+ messages in thread
From: Joyce Kong (Arm Technology China) @ 2018-11-21 11:41 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, jerin.jacob, Honnappa Nagarahalli,
Gavin Hu (Arm Technology China),
hemant.agrawal
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, November 21, 2018 7:14 PM
> To: Joyce Kong (Arm Technology China) <Joyce.Kong@arm.com>
> Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; hemant.agrawal@nxp.com
> Subject: Re: [PATCH v1 0/2] change max core number to 256 for Arm64
> platform
>
> Hi,
>
> 21/11/2018 12:10, Joyce Kong:
> > v1: change the max core setting to 256 for arm64 platform
> >
> > Joyce Kong (2):
> > config: enable more than 128 cores for Arm platform
> > config: enable more than 128 cores for meson build
>
> 2 comments:
>
> - It doesn't need to be split in 2 commits.
Combined into 1 commit in v2.
> - Are you sure you want this change in 18.11? No risk?
Yes, no risk.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform
2018-11-21 11:41 ` Joyce Kong (Arm Technology China)
@ 2018-11-21 20:09 ` Stephen Hemminger
0 siblings, 0 replies; 15+ messages in thread
From: Stephen Hemminger @ 2018-11-21 20:09 UTC (permalink / raw)
To: Joyce Kong (Arm Technology China)
Cc: Thomas Monjalon, dev, jerin.jacob, Honnappa Nagarahalli,
Gavin Hu (Arm Technology China),
hemant.agrawal
On Wed, 21 Nov 2018 11:41:36 +0000
"Joyce Kong (Arm Technology China)" <Joyce.Kong@arm.com> wrote:
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Please fix your mail system. Because technically sending mail to a mailing list with this footer means everyone on the list should delete the mail.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2] config: enable more than 128 cores for Arm64 platform
2018-11-21 11:10 [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Joyce Kong
` (2 preceding siblings ...)
2018-11-21 11:13 ` [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Thomas Monjalon
@ 2018-11-21 11:27 ` Joyce Kong
2018-11-21 11:34 ` Jerin Jacob
2018-11-22 7:01 ` [dpdk-dev] [PATCH v3] " Joyce Kong
4 siblings, 1 reply; 15+ messages in thread
From: Joyce Kong @ 2018-11-21 11:27 UTC (permalink / raw)
To: dev; +Cc: thomas, jerin.jacob, Honnappa.Nagarahalli, gavin.hu, stable
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on Arm64 platform.
Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
config/arm/meson.build | 2 +-
config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index b755138..020df09 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -51,7 +51,7 @@ flags_cavium = [
['RTE_MACHINE', '"thunderx"'],
['RTE_CACHE_LINE_SIZE', 128],
['RTE_MAX_NUMA_NODES', 2],
- ['RTE_MAX_LCORE', 96],
+ ['RTE_MAX_LCORE', 256],
['RTE_MAX_VFIO_GROUPS', 128],
['RTE_USE_C11_MEM_MODEL', false]]
flags_dpaa = [
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 1842744..a6ed90c 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -6,3 +6,4 @@
CONFIG_RTE_TOOLCHAIN="gcc"
CONFIG_RTE_TOOLCHAIN_GCC=y
+CONFIG_RTE_MAX_LCORE=256
--
2.7.4
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [dpdk-dev] [PATCH v2] config: enable more than 128 cores for Arm64 platform
2018-11-21 11:27 ` [dpdk-dev] [PATCH v2] config: enable more than 128 cores " Joyce Kong
@ 2018-11-21 11:34 ` Jerin Jacob
2018-11-22 7:01 ` Joyce Kong (Arm Technology China)
0 siblings, 1 reply; 15+ messages in thread
From: Jerin Jacob @ 2018-11-21 11:34 UTC (permalink / raw)
To: Joyce Kong; +Cc: dev, thomas, Honnappa.Nagarahalli, gavin.hu, stable
-----Original Message-----
> Date: Wed, 21 Nov 2018 19:27:12 +0800
> From: Joyce Kong <joyce.kong@arm.com>
> To: dev@dpdk.org
> CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
> Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org
> Subject: [PATCH v2] config: enable more than 128 cores for Arm64 platform
> X-Mailer: git-send-email 2.7.4
>
>
> When running dpdk applications on cores whose ids are bigger
> than original max_core setting, eal error as below:
> EAL: Detected 104 lcore(s)
> EAL: Detected 2 NUMA nodes
> EAL: invalid core list
> -l CORELIST core indexes between 0 and 128
>
> The fix is to increase max_core to 256 on Arm64 platform.
>
> Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> config/arm/meson.build | 2 +-
> config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index b755138..020df09 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -51,7 +51,7 @@ flags_cavium = [
> ['RTE_MACHINE', '"thunderx"'],
> ['RTE_CACHE_LINE_SIZE', 128],
> ['RTE_MAX_NUMA_NODES', 2],
> - ['RTE_MAX_LCORE', 96],
> + ['RTE_MAX_LCORE', 256],
This change makes thunderx config to 256 cores not armv8.
For generic config, it needs to be under "flags_generic"
not under "flags_cavium". Just like you did for updating
defconfig_arm64-armv8a-linuxapp-gcc config instead of
defconfig_arm64-thunderx-linuxapp-gcc
> ['RTE_MAX_VFIO_GROUPS', 128],
> ['RTE_USE_C11_MEM_MODEL', false]]
> flags_dpaa = [
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 1842744..a6ed90c 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -6,3 +6,4 @@
>
> CONFIG_RTE_TOOLCHAIN="gcc"
> CONFIG_RTE_TOOLCHAIN_GCC=y
> +CONFIG_RTE_MAX_LCORE=256
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [dpdk-dev] [PATCH v2] config: enable more than 128 cores for Arm64 platform
2018-11-21 11:34 ` Jerin Jacob
@ 2018-11-22 7:01 ` Joyce Kong (Arm Technology China)
0 siblings, 0 replies; 15+ messages in thread
From: Joyce Kong (Arm Technology China) @ 2018-11-22 7:01 UTC (permalink / raw)
To: Jerin Jacob
Cc: dev, thomas, Honnappa Nagarahalli,
Gavin Hu (Arm Technology China),
stable
> -----Original Message-----
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Sent: Wednesday, November 21, 2018 7:35 PM
> To: Joyce Kong (Arm Technology China) <Joyce.Kong@arm.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH v2] config: enable more than 128 cores for Arm64
> platform
>
> -----Original Message-----
> > Date: Wed, 21 Nov 2018 19:27:12 +0800
> > From: Joyce Kong <joyce.kong@arm.com>
> > To: dev@dpdk.org
> > CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
> > Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org
> > Subject: [PATCH v2] config: enable more than 128 cores for Arm64
> > platform
> > X-Mailer: git-send-email 2.7.4
> >
> >
> > When running dpdk applications on cores whose ids are bigger than
> > original max_core setting, eal error as below:
> > EAL: Detected 104 lcore(s)
> > EAL: Detected 2 NUMA nodes
> > EAL: invalid core list
> > -l CORELIST core indexes between 0 and 128
> >
> > The fix is to increase max_core to 256 on Arm64 platform.
> >
> > Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> > config/arm/meson.build | 2 +-
> > config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > b755138..020df09 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -51,7 +51,7 @@ flags_cavium = [
> > ['RTE_MACHINE', '"thunderx"'],
> > ['RTE_CACHE_LINE_SIZE', 128],
> > ['RTE_MAX_NUMA_NODES', 2],
> > - ['RTE_MAX_LCORE', 96],
> > + ['RTE_MAX_LCORE', 256],
>
> This change makes thunderx config to 256 cores not armv8.
> For generic config, it needs to be under "flags_generic"
> not under "flags_cavium". Just like you did for updating defconfig_arm64-
> armv8a-linuxapp-gcc config instead of defconfig_arm64-thunderx-linuxapp-
> gcc
>
Config to 256 cores for both flags_generic and flags_cavium in V3.
For thunderx, it will do meson build according to flasg_cavium instead of flags_generic.
And there is no inheritance relationship between the two flags.
> > ['RTE_MAX_VFIO_GROUPS', 128],
> > ['RTE_USE_C11_MEM_MODEL', false]] flags_dpaa = [ diff --git
> > a/config/defconfig_arm64-armv8a-linuxapp-gcc
> > b/config/defconfig_arm64-armv8a-linuxapp-gcc
> > index 1842744..a6ed90c 100644
> > --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> > +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> > @@ -6,3 +6,4 @@
> >
> > CONFIG_RTE_TOOLCHAIN="gcc"
> > CONFIG_RTE_TOOLCHAIN_GCC=y
> > +CONFIG_RTE_MAX_LCORE=256
> > --
> > 2.7.4
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v3] config: enable more than 128 cores for Arm64 platform
2018-11-21 11:10 [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Joyce Kong
` (3 preceding siblings ...)
2018-11-21 11:27 ` [dpdk-dev] [PATCH v2] config: enable more than 128 cores " Joyce Kong
@ 2018-11-22 7:01 ` Joyce Kong
2018-11-22 7:08 ` Jerin Jacob
2018-11-22 7:37 ` [dpdk-dev] [PATCH v4] " Joyce Kong
4 siblings, 2 replies; 15+ messages in thread
From: Joyce Kong @ 2018-11-22 7:01 UTC (permalink / raw)
To: dev; +Cc: thomas, jerin.jacob, Honnappa.Nagarahalli, gavin.hu, stable
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on Arm64 platform.
Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
config/arm/meson.build | 5 +++--
config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index b755138..9b5f09c 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -46,13 +46,14 @@ flags_common_default = [
flags_generic = [
['RTE_MACHINE', '"armv8a"'],
+ ['RTE_MAX_LCORE', 256],
['RTE_CACHE_LINE_SIZE', 128]]
flags_cavium = [
['RTE_MACHINE', '"thunderx"'],
['RTE_CACHE_LINE_SIZE', 128],
['RTE_MAX_NUMA_NODES', 2],
- ['RTE_MAX_LCORE', 96],
- ['RTE_MAX_VFIO_GROUPS', 128],
+ ['RTE_MAX_LCORE', 256],
+ ['RTE_MAX_VFIO_GROUPS', 128],
['RTE_USE_C11_MEM_MODEL', false]]
flags_dpaa = [
['RTE_MACHINE', '"dpaa"'],
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 1842744..a6ed90c 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -6,3 +6,4 @@
CONFIG_RTE_TOOLCHAIN="gcc"
CONFIG_RTE_TOOLCHAIN_GCC=y
+CONFIG_RTE_MAX_LCORE=256
--
2.7.4
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [dpdk-dev] [PATCH v3] config: enable more than 128 cores for Arm64 platform
2018-11-22 7:01 ` [dpdk-dev] [PATCH v3] " Joyce Kong
@ 2018-11-22 7:08 ` Jerin Jacob
2018-11-22 7:43 ` Joyce Kong (Arm Technology China)
2018-11-22 7:37 ` [dpdk-dev] [PATCH v4] " Joyce Kong
1 sibling, 1 reply; 15+ messages in thread
From: Jerin Jacob @ 2018-11-22 7:08 UTC (permalink / raw)
To: Joyce Kong; +Cc: dev, thomas, Honnappa.Nagarahalli, gavin.hu, stable
-----Original Message-----
> Date: Thu, 22 Nov 2018 15:01:14 +0800
> From: Joyce Kong <joyce.kong@arm.com>
> To: dev@dpdk.org
> CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
> Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org
> Subject: [PATCH v3] config: enable more than 128 cores for Arm64 platform
> X-Mailer: git-send-email 2.7.4
>
>
> When running dpdk applications on cores whose ids are bigger
> than original max_core setting, eal error as below:
> EAL: Detected 104 lcore(s)
> EAL: Detected 2 NUMA nodes
> EAL: invalid core list
> -l CORELIST core indexes between 0 and 128
>
> The fix is to increase max_core to 256 on Arm64 platform.
>
> Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> config/arm/meson.build | 5 +++--
> config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index b755138..9b5f09c 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -46,13 +46,14 @@ flags_common_default = [
>
> flags_generic = [
> ['RTE_MACHINE', '"armv8a"'],
> + ['RTE_MAX_LCORE', 256],
> ['RTE_CACHE_LINE_SIZE', 128]]
> flags_cavium = [
> ['RTE_MACHINE', '"thunderx"'],
> ['RTE_CACHE_LINE_SIZE', 128],
> ['RTE_MAX_NUMA_NODES', 2],
> - ['RTE_MAX_LCORE', 96],
> - ['RTE_MAX_VFIO_GROUPS', 128],
> + ['RTE_MAX_LCORE', 256],
thunderx has only 96 cores. It the "thunderx2" which has more cores.
There no speerate config "thunderx2", it is using generic armv8 config.
So this specific line of change is not needed.
> + ['RTE_MAX_VFIO_GROUPS', 128],
> ['RTE_USE_C11_MEM_MODEL', false]]
> flags_dpaa = [
> ['RTE_MACHINE', '"dpaa"'],
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 1842744..a6ed90c 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -6,3 +6,4 @@
>
> CONFIG_RTE_TOOLCHAIN="gcc"
> CONFIG_RTE_TOOLCHAIN_GCC=y
> +CONFIG_RTE_MAX_LCORE=256
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [dpdk-dev] [PATCH v3] config: enable more than 128 cores for Arm64 platform
2018-11-22 7:08 ` Jerin Jacob
@ 2018-11-22 7:43 ` Joyce Kong (Arm Technology China)
0 siblings, 0 replies; 15+ messages in thread
From: Joyce Kong (Arm Technology China) @ 2018-11-22 7:43 UTC (permalink / raw)
To: Jerin Jacob
Cc: dev, thomas, Honnappa Nagarahalli,
Gavin Hu (Arm Technology China),
stable
> -----Original Message-----
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Sent: Thursday, November 22, 2018 3:09 PM
> To: Joyce Kong (Arm Technology China) <Joyce.Kong@arm.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH v3] config: enable more than 128 cores for Arm64
> platform
>
> -----Original Message-----
> > Date: Thu, 22 Nov 2018 15:01:14 +0800
> > From: Joyce Kong <joyce.kong@arm.com>
> > To: dev@dpdk.org
> > CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
> > Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org
> > Subject: [PATCH v3] config: enable more than 128 cores for Arm64
> > platform
> > X-Mailer: git-send-email 2.7.4
> >
> >
> > When running dpdk applications on cores whose ids are bigger than
> > original max_core setting, eal error as below:
> > EAL: Detected 104 lcore(s)
> > EAL: Detected 2 NUMA nodes
> > EAL: invalid core list
> > -l CORELIST core indexes between 0 and 128
> >
> > The fix is to increase max_core to 256 on Arm64 platform.
> >
> > Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> > config/arm/meson.build | 5 +++--
> > config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > b755138..9b5f09c 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -46,13 +46,14 @@ flags_common_default = [
> >
> > flags_generic = [
> > ['RTE_MACHINE', '"armv8a"'],
> > + ['RTE_MAX_LCORE', 256],
> > ['RTE_CACHE_LINE_SIZE', 128]]
> > flags_cavium = [
> > ['RTE_MACHINE', '"thunderx"'],
> > ['RTE_CACHE_LINE_SIZE', 128],
> > ['RTE_MAX_NUMA_NODES', 2],
> > - ['RTE_MAX_LCORE', 96],
> > - ['RTE_MAX_VFIO_GROUPS', 128],
> > + ['RTE_MAX_LCORE', 256],
>
> thunderx has only 96 cores. It the "thunderx2" which has more cores.
> There no speerate config "thunderx2", it is using generic armv8 config.
> So this specific line of change is not needed.
>
Remove this specific line of change in V4.
> > + ['RTE_MAX_VFIO_GROUPS', 128],
> > ['RTE_USE_C11_MEM_MODEL', false]] flags_dpaa = [
> > ['RTE_MACHINE', '"dpaa"'],
> > diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc
> > b/config/defconfig_arm64-armv8a-linuxapp-gcc
> > index 1842744..a6ed90c 100644
> > --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> > +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> > @@ -6,3 +6,4 @@
> >
> > CONFIG_RTE_TOOLCHAIN="gcc"
> > CONFIG_RTE_TOOLCHAIN_GCC=y
> > +CONFIG_RTE_MAX_LCORE=256
> > --
> > 2.7.4
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v4] config: enable more than 128 cores for Arm64 platform
2018-11-22 7:01 ` [dpdk-dev] [PATCH v3] " Joyce Kong
2018-11-22 7:08 ` Jerin Jacob
@ 2018-11-22 7:37 ` Joyce Kong
2018-11-22 11:04 ` Jerin Jacob
1 sibling, 1 reply; 15+ messages in thread
From: Joyce Kong @ 2018-11-22 7:37 UTC (permalink / raw)
To: dev; +Cc: thomas, jerin.jacob, Honnappa.Nagarahalli, gavin.hu, nd, stable
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on Arm64 platform.
Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
config/arm/meson.build | 1 +
config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
2 files changed, 2 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index b755138..3f91725 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -46,6 +46,7 @@ flags_common_default = [
flags_generic = [
['RTE_MACHINE', '"armv8a"'],
+ ['RTE_MAX_LCORE', 256],
['RTE_CACHE_LINE_SIZE', 128]]
flags_cavium = [
['RTE_MACHINE', '"thunderx"'],
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 1842744..a6ed90c 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -6,3 +6,4 @@
CONFIG_RTE_TOOLCHAIN="gcc"
CONFIG_RTE_TOOLCHAIN_GCC=y
+CONFIG_RTE_MAX_LCORE=256
--
2.7.4
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [dpdk-dev] [PATCH v4] config: enable more than 128 cores for Arm64 platform
2018-11-22 7:37 ` [dpdk-dev] [PATCH v4] " Joyce Kong
@ 2018-11-22 11:04 ` Jerin Jacob
2018-11-23 0:49 ` Thomas Monjalon
0 siblings, 1 reply; 15+ messages in thread
From: Jerin Jacob @ 2018-11-22 11:04 UTC (permalink / raw)
To: Joyce Kong; +Cc: dev, thomas, Honnappa.Nagarahalli, gavin.hu, nd, stable
-----Original Message-----
> Date: Thu, 22 Nov 2018 15:37:07 +0800
> From: Joyce Kong <joyce.kong@arm.com>
> To: dev@dpdk.org
> CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
> Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, nd@arm.com,
> stable@dpdk.org
> Subject: [PATCH v4] config: enable more than 128 cores for Arm64 platform
> X-Mailer: git-send-email 2.7.4
>
>
> When running dpdk applications on cores whose ids are bigger
> than original max_core setting, eal error as below:
> EAL: Detected 104 lcore(s)
> EAL: Detected 2 NUMA nodes
> EAL: invalid core list
> -l CORELIST core indexes between 0 and 128
>
> The fix is to increase max_core to 256 on Arm64 platform.
>
> Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> config/arm/meson.build | 1 +
> config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index b755138..3f91725 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -46,6 +46,7 @@ flags_common_default = [
>
> flags_generic = [
> ['RTE_MACHINE', '"armv8a"'],
> + ['RTE_MAX_LCORE', 256],
> ['RTE_CACHE_LINE_SIZE', 128]]
> flags_cavium = [
> ['RTE_MACHINE', '"thunderx"'],
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 1842744..a6ed90c 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -6,3 +6,4 @@
>
> CONFIG_RTE_TOOLCHAIN="gcc"
> CONFIG_RTE_TOOLCHAIN_GCC=y
> +CONFIG_RTE_MAX_LCORE=256
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [dpdk-dev] [PATCH v4] config: enable more than 128 cores for Arm64 platform
2018-11-22 11:04 ` Jerin Jacob
@ 2018-11-23 0:49 ` Thomas Monjalon
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2018-11-23 0:49 UTC (permalink / raw)
To: Joyce Kong; +Cc: dev, Jerin Jacob, Honnappa.Nagarahalli, gavin.hu, nd, stable
22/11/2018 12:04, Jerin Jacob:
> From: Joyce Kong <joyce.kong@arm.com>
> >
> > When running dpdk applications on cores whose ids are bigger
> > than original max_core setting, eal error as below:
> > EAL: Detected 104 lcore(s)
> > EAL: Detected 2 NUMA nodes
> > EAL: invalid core list
> > -l CORELIST core indexes between 0 and 128
> >
> > The fix is to increase max_core to 256 on Arm64 platform.
> >
> > Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Applied, thanks
Note: Arm64 replace by arm64 to comply with Honnappa's naming recommendation.
^ permalink raw reply [flat|nested] 15+ messages in thread