Re: [dpdk-dev] [PATCH v7 03/14] doc: remove references to make from NICs guides

[Thomas Monjalon <thomas@monjalon.net>]

22/10/2020 12:03, Power, Ciara:
> From: Thomas Monjalon <thomas@monjalon.net>
> >> -- ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER`` (default ``n``)
> >> -
> >> -  Toggles display of bus configurations and enables a debugging queue
> >> -  to fetch error (Rx/Tx) packets to driver. By default, packets with
> >> errors
> >> -  (like wrong checksum) are dropped by the hardware.
> >> -
> >> -- ``CONFIG_RTE_LIBRTE_DPAA_HWDEBUG`` (default ``n``)
> >> -
> >> -  Enables debugging of the Queue and Buffer Manager layer which
> >> interacts
> >> -  with the DPAA hardware.
> >
> >I feel these explanations should be kept.
> >Or do you think it's not worth?
> 
> Yes sure, keep them.

You dropped other debug flags, so it's OK drop them as you did.

> >[...]
> >> -- ``CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER`` (default ``n``)
> >> -
> >> -  Toggle display of debugging messages/logic
> >> -
> >> -- ``CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA`` (default ``n``)
> >> -
> >> -  Toggle to use physical address vs virtual address for hardware
> >accelerators.
> >
> >Keep these ones?
> >
> 
> Yes can keep, although one thing to note is I think RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is now enabled by default, going by config/meson.build:
> 	dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true)

OK so let's drop.

> >[...]
> >> -   * **CONFIG_RTE_LIBRTE_ENA_DEBUG_RX** (default n): Enables or
> >disables debug
> >> -     logging of RX logic within the ENA PMD driver.
> >> -
> >> -   * **CONFIG_RTE_LIBRTE_ENA_DEBUG_TX** (default n): Enables or
> >disables debug
> >> -     logging of TX logic within the ENA PMD driver.
> >> -
> >> -   * **CONFIG_RTE_LIBRTE_ENA_COM_DEBUG** (default n): Enables or
> >disables debug
> >> -     logging of low level tx/rx logic in ena_com(base) within the ENA PMD
> >driver.
> >
> >Keep? Or debug options not worth?
> >
> 
> Yes sure, I have no problems keeping them.

No problem to drop :)