From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6D81A04DD; Thu, 22 Oct 2020 12:16:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 665B4A993; Thu, 22 Oct 2020 12:16:30 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 5CE97697A for ; Thu, 22 Oct 2020 12:16:28 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id AFB2B58031E; Thu, 22 Oct 2020 06:16:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 22 Oct 2020 06:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= BuUPOq+9zuDOBcQMQC/hebyPMNxA3vgRsntgz1XwNR8=; b=ie/Xc5oym6vDrgu4 4ZDABU25VzBKm9KDyY+QOtszBNqNiPMwqKmF2HlTWPVVx8Iipc+KGWORdj/cl//+ WtUuKBOVeGIXeovwe3TlX5bk1WUiXIVf6FWN/gS/tF5AqlmqQInR2D22GMBoP/Bp cxhle8+xvxwa4aykqw9IQRyFPBwDPjrdWiLKh4ZO95/BUNmncVwJbncKdv9t9cMG dDi4YGqFKoyCNnZCUnnFuhVHBo+bQ0W1AUurEbO+ugGTECLRQ8u9etRZ7A1J2DAr ncO1Hj3KYAXyAIhbNcdASm6m9QiuDsPBpy2Tw5wzu1gR5c7veYbmNua6CWW4s1m9 hcOkIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BuUPOq+9zuDOBcQMQC/hebyPMNxA3vgRsntgz1XwN R8=; b=YbLqQNZkYs6mDgFw77nV2+z5YWVSBLTkFATKt75cv9+PmPZdmPHlgeTWR 03LW+piOzd6TU2Mo+cU++///CvgIBaIMjX5oUCBx3aFE3Ap3ZUIPaJ3zPwfredmk k3srWBHqKSsTmrb6OYv7b47wh3XAcoC2ZlX1SZP00pn9V9FlKiMlxVhFRZWHEJMJ x5AHQuaeFRp9OXTrnU+fA9m1o0AUG3jhnP/343d6Nl2UNSSvsh5lMrDl7MQrJsUf Awmgn0niFvOMCRNaEWxOiYCMlS0jwVnhrA6fei3KILSbfQx1O2cePnBG6AWzxZrX t6XE9RGT12THb4lthVbTbeFLbF0LQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeejgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EB3D8306467D; Thu, 22 Oct 2020 06:16:19 -0400 (EDT) From: Thomas Monjalon To: "Richardson, Bruce" , "Power, Ciara" Cc: "dev@dpdk.org" , Igor Russkikh , "Yigit, Ferruh" , Harman Kalra , Ajit Khaparde , Hyong Youb Kim , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Gaetan Rivet , "Zhang, Qi Z" , "Wang, Xiao W" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , "Xing, Beilei" , "Guo, Jia" , "Yang, Qiming" , "Wang, Haiyue" , Alfredo Cardigliano , "Xu, Rosen" , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Martin Spinler , Heinrich Kuhn , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Singh, Jasvinder" , "Dumitrescu, Cristian" , Maciej Czekaj , Maxime Coquelin , "Xia, Chenbo" , "Wang, Zhihong" Date: Thu, 22 Oct 2020 12:16:17 +0200 Message-ID: <6709812.uOoTMiro2r@thomas> In-Reply-To: References: <20200807123009.21266-1-ciara.power@intel.com> <3176147.upzOanXTzD@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 03/14] doc: remove references to make from NICs guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/10/2020 12:03, Power, Ciara: > From: Thomas Monjalon > >> -- ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER`` (default ``n``) > >> - > >> - Toggles display of bus configurations and enables a debugging queue > >> - to fetch error (Rx/Tx) packets to driver. By default, packets with > >> errors > >> - (like wrong checksum) are dropped by the hardware. > >> - > >> -- ``CONFIG_RTE_LIBRTE_DPAA_HWDEBUG`` (default ``n``) > >> - > >> - Enables debugging of the Queue and Buffer Manager layer which > >> interacts > >> - with the DPAA hardware. > > > >I feel these explanations should be kept. > >Or do you think it's not worth? > > Yes sure, keep them. You dropped other debug flags, so it's OK drop them as you did. > >[...] > >> -- ``CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER`` (default ``n``) > >> - > >> - Toggle display of debugging messages/logic > >> - > >> -- ``CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA`` (default ``n``) > >> - > >> - Toggle to use physical address vs virtual address for hardware > >accelerators. > > > >Keep these ones? > > > > Yes can keep, although one thing to note is I think RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is now enabled by default, going by config/meson.build: > dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true) OK so let's drop. > >[...] > >> - * **CONFIG_RTE_LIBRTE_ENA_DEBUG_RX** (default n): Enables or > >disables debug > >> - logging of RX logic within the ENA PMD driver. > >> - > >> - * **CONFIG_RTE_LIBRTE_ENA_DEBUG_TX** (default n): Enables or > >disables debug > >> - logging of TX logic within the ENA PMD driver. > >> - > >> - * **CONFIG_RTE_LIBRTE_ENA_COM_DEBUG** (default n): Enables or > >disables debug > >> - logging of low level tx/rx logic in ena_com(base) within the ENA PMD > >driver. > > > >Keep? Or debug options not worth? > > > > Yes sure, I have no problems keeping them. No problem to drop :)