From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 107FF45C21; Thu, 31 Oct 2024 14:22:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA04C43583; Thu, 31 Oct 2024 14:22:56 +0100 (CET) Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) by mails.dpdk.org (Postfix) with ESMTP id 1779240264 for ; Thu, 31 Oct 2024 14:22:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=MIME-Version:From:Subject:Date:Content-Type: Message-Id; bh=lF0Bn3H6ZFkDVElPA39yCynASFvTJAlXkTV10CANhY4=; b=H fpw50R9zYCacdgV/6j5kYrItlXsYqXvSxTrCspBHTPGRaXrRR6UZ8XMFLVErOY1N PK/VzF+V97DUeIGNhQgINQ//AWLsvjTrl+eFLq8xiKsUNbfEQpz3VVO7vq3HbHn9 RpUzHjqq3UCEbH9B0zC89JYX+u6Yv0nUEQeSIhdl4Q= Received: from [IPv6:::ffff:192.168.250.237] (unknown [223.104.40.100]) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wC3X2GphCNntxz8EQ--.6936S2; Thu, 31 Oct 2024 21:22:50 +0800 (CST) MIME-Version: 1.0 To: "pbhagavatula@marvell.com" Cc: "dev@dpdk.org" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "ndabilpuram@marvell.com" , "yanzhirun_163@163.com" From: Huichao Cai Subject: Re: [PATCH] graph: fix memory leak in node clone Date: Thu, 31 Oct 2024 21:22:50 +0800 Importance: normal X-Priority: 3 Content-Type: multipart/alternative; boundary="_947BBCFF-7BC0-4CCF-8779-4854A312667B_" X-CM-TRANSID: _____wC3X2GphCNntxz8EQ--.6936S2 Message-Id: <672384AA.180E9A.00001@m16.mail.163.com> X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RLVyVUUUUU X-Originating-IP: [223.104.40.100] X-CM-SenderInfo: pfkfuxrfyyqiywtou0bp/1tbiMReJF2cjgxsdFQAAss X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_947BBCFF-7BC0-4CCF-8779-4854A312667B_ Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" VGhlcmUgaXMgb25lIG1vcmUgcGxhY2UgaW4gdGhlIG5vZGVfY2xvbmUgZnVuY3Rpb24gdGhhdCBu ZWVkcyB0byBiZSBtb2RpZmllZDoNCglpZiAoY2xvbmVfbmFtZShyZWctPm5hbWUsIG5vZGUtPm5h bWUsIG5hbWUpKQ0KCQkvL2dvdG8gZnJlZTsNCgkJZ290byBmcmVlX3hzdGF0Ow0KDQoNCuS7jiBX aW5kb3dzIOeJiOmCruS7tuWPkemAgQ0KDQo= --_947BBCFF-7BC0-4CCF-8779-4854A312667B_ Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

There is one more place in =
the node_clone function that needs to be modified:

<= /div>

=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (clone_name(reg->name, nod=
e->name, name))

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 //goto free;=

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto free_xstat;

<= /div>

=E4=BB=8E W= indows =E7=89=88=E9=82=AE= =E4=BB=B6=E5=8F=91=E9=80=81

&nb= sp;

= --_947BBCFF-7BC0-4CCF-8779-4854A312667B_--