From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79E06A0471 for ; Fri, 16 Aug 2019 09:48:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E7681BED5; Fri, 16 Aug 2019 09:48:49 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id EDA361BEBF for ; Fri, 16 Aug 2019 09:48:46 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 2C7B9100079; Fri, 16 Aug 2019 07:48:45 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 16 Aug 2019 08:48:37 +0100 To: , , , John McNamara , "Marko Kovacevic" , Thomas Monjalon CC: References: <20190816055511.2322-1-pbhagavatula@marvell.com> <20190816055511.2322-3-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: <672afa31-6f88-9099-f4c7-e85a24959c0e@solarflare.com> Date: Fri, 16 Aug 2019 10:48:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190816055511.2322-3-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24850.003 X-TM-AS-Result: No-4.767100-8.000000-10 X-TMASE-MatchedRID: 8+bhjh9TQnEeimh1YYHcKPZvT2zYoYOwC/ExpXrHizyRoQLwUmtovzCW p18HPoW8SjVIFO5E44BCxxedyPqGQS5rFQ7ithY8IAjxomarSPDxuhkRWK22GJ+4ziUPq4LxI1j 7tcek4Y7OdLBm+1W1mO7vhe/gZIXmpljg/F9ExYRK9CbrGqYI8ilayzmQ9QV0KBVvFbsUM5XyDf 8WuUgFip+EdAMWhZ2MkbXd/BrUE3ch4UgUH4JX7APZZctd3P4BxYt6Ilbxn6nRM7/5sQx33nERb S7OZpEDO8WI2rwbczmFdRK8kSpVO0d++++MC1b2caD+wPaBYtY1TzP60UkdHUWc5l/zdnvro8WM kQWv6iUD0yuKrQIMCAGLeSok4rrZbdTuPa9VRGvEQdG7H66TyJ8TMnmE+d0ZPSQzWjwld6ZtmCA ivkPEc0sFy0ZHH3l1I5h/21aS8Pj6b9D+qYcvUTQw6Kpq+rhf9fnJgIp3/lyF92wxVb+0/a8j8g R9gsXp1DXsKeBNv04EqZlWBkJWd7MZNZFdSWvHG2wlTHLNY1JWXGvUUmKP2w== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.767100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24850.003 X-MDID: 1565941726-4R4JHa8eTXKZ Subject: Re: [dpdk-dev] [PATCH 2/7] ethdev: add mbuf RSS update as a offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/16/19 8:55 AM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to > enable/disable PMDs write to `rte_mbuf::hash::rss`. It should be highlighted that presence of the RSS hash is indicated by PKT_RX_RSS_HASH flag in mbuf anyway. Now applications have a way to check that RSS hash delivery is supported and should enable the offload if RSS hash is used. PMD may still provide the hash even if the offload is not enabled. > Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko with above and one note below fixed. > --- > doc/guides/nics/features.rst | 2 ++ > lib/librte_ethdev/rte_ethdev.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index d4d55f721..f79b69b38 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -274,6 +274,7 @@ Supports RSS hashing on RX. > > * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` = ``ETH_MQ_RX_RSS_FLAG``. > * **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``. > +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_RSS_HASH``. > * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``. > * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_RSS_HASH``, ``mbuf.rss``. > > @@ -286,6 +287,7 @@ Inner RSS > Supports RX RSS hashing on Inner headers. > > * **[uses] rte_flow_action_rss**: ``level``. > +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_RSS_HASH``. > * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_RSS_HASH``, ``mbuf.rss``. > > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index f97f0a6e5..889486a11 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1013,6 +1013,7 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_KEEP_CRC 0x00010000 > #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 > #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000 > +#define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 Should be added to rte_rx_offload_names in lib/librte_ethdev/rte_ethdev.c.