DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: fengchengwen <fengchengwen@huawei.com>
Cc: dev@dpdk.org, liuyonglong@huawei.com
Subject: Re: [PATCH v4 4/4] dma/acc: add doc
Date: Wed, 15 Oct 2025 16:09:42 +0200	[thread overview]
Message-ID: <6737262.UjTJXf6HLC@thomas> (raw)
In-Reply-To: <91af2066-2501-0864-f5f4-68037a8515b8@huawei.com>

15/10/2025 14:55, fengchengwen:
> On 2025/10/15 20:01, Thomas Monjalon wrote:
> > 15/10/2025 13:10, fengchengwen:
> >> On 2025/10/15 18:05, Thomas Monjalon wrote:
> >>> 13/10/2025 11:11, Chengwen Feng:
> >>>> +HISILICON Accelerator DMA Driver
> >>>> +================================
> >>>> +
> >>>> +Kunpeng SoC has an internal accelerator unit which includes zip function, and
> >>>> +the zip also supports data copy and fill. This driver exposes this capability to
> >>>> +DPDK application.
> >>> How is it different of drivers/dma/hisilicon/ ?
> >>>
> >>> "
> >>> Kunpeng SoC has an internal DMA unit which can be used by application
> >>> to accelerate data copies.
> >>> "
> >>>
> >>> If it is the same hardware (Kunpeng),
> >>> I recommend having a single driver, or a single directory.
> >>> Also we already have a driver named "acc" in baseband.
> >>
> >> they belong to different hardware IP of Kunpeng platform, /dma/hisilicon
> >> is the PCIE subsystem DMA's driver, while this acc is the
> >> Accelerator(ZIP) subsystem DMA's driver.  they don't exist in the same
> >> specific Kunpeng Soc.
> >>
> >> a single driver will add complex.
> >>
> >> as for a single directory, should we do for all vendor?  I see there
> >> are  dpaa and dpaa2, ioat and idxd both belong to vendor platform.
> > When it is really different driver, it is OK to keep them separate.
> >
> >> if there are no rule to have same name with different subsystem driver,
> >> I prefer keep it.
> > OK but why it does not contain HiSilicon or Kunpeng in its name?
> > "acc" is a really short name, and already used.
> > Please find something else.
> 
> how about hacc and kacc ?   Hisilicon / Kunpeng accelerator DMA

You already have one DMA driver in drivers/dma/hisilicon/
Can you build around that? like hisilicon_something?
hisil_acc?



      reply	other threads:[~2025-10-15 14:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27  9:27 [PATCH 0/4] add Hisilicon accelerator DMA driver Chengwen Feng
2025-08-27  9:27 ` [PATCH 1/4] dma/acc: add probe and remove Chengwen Feng
2025-08-27  9:27 ` [PATCH 2/4] dma/acc: add control path ops Chengwen Feng
2025-08-27  9:27 ` [PATCH 3/4] dma/acc: add data " Chengwen Feng
2025-08-27  9:27 ` [PATCH 4/4] dma/acc: add doc Chengwen Feng
2025-09-08  2:39 ` [PATCH v2 0/4] add Hisilicon accelerator DMA driver Chengwen Feng
2025-09-08  2:39   ` [PATCH v2 1/4] dma/acc: add probe and remove Chengwen Feng
2025-09-08  2:39   ` [PATCH v2 2/4] dma/acc: add control path ops Chengwen Feng
2025-09-08  2:39   ` [PATCH v2 3/4] dma/acc: add data " Chengwen Feng
2025-09-08  2:39   ` [PATCH v2 4/4] dma/acc: add doc Chengwen Feng
2025-09-10  8:50 ` [PATCH v3 0/4] add Hisilicon accelerator DMA driver Chengwen Feng
2025-09-10  8:50   ` [PATCH v3 1/4] dma/acc: add probe and remove Chengwen Feng
2025-09-10  8:51   ` [PATCH v3 2/4] dma/acc: add control path ops Chengwen Feng
2025-09-10  8:51   ` [PATCH v3 3/4] dma/acc: add data " Chengwen Feng
2025-09-10  8:51   ` [PATCH v3 4/4] dma/acc: add doc Chengwen Feng
2025-10-13  9:11 ` [PATCH v4 0/4] add Hisilicon accelerator DMA driver Chengwen Feng
2025-10-13  9:11   ` [PATCH v4 1/4] dma/acc: add probe and remove Chengwen Feng
2025-10-13  9:11   ` [PATCH v4 2/4] dma/acc: add control path ops Chengwen Feng
2025-10-13  9:11   ` [PATCH v4 3/4] dma/acc: add data " Chengwen Feng
2025-10-13  9:11   ` [PATCH v4 4/4] dma/acc: add doc Chengwen Feng
2025-10-15 10:05     ` Thomas Monjalon
2025-10-15 11:10       ` fengchengwen
2025-10-15 12:01         ` Thomas Monjalon
2025-10-15 12:55           ` fengchengwen
2025-10-15 14:09             ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6737262.UjTJXf6HLC@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=liuyonglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).