From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id EFFE81B46E
 for <dev@dpdk.org>; Thu, 12 Jul 2018 11:21:10 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 8228620F12;
 Thu, 12 Jul 2018 05:21:10 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 12 Jul 2018 05:21:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=HGQsGUTqZPSR9CegV/KIm9bLOk
 63AAxQNNeTwJOnU90=; b=I+QDQ4kOw/fLPh1EeS96cd9cRPj/xcy979PKHts/rR
 c2HggTHJk/I+BdXphp/3tJciDtvadkiXjXTdtWy1kB08fXAs+H3o4fel6lQsWwwS
 0zPbdru8kkKxD+r+pdhQrS5ZV5vKeVBq6TF18buhmW07qZdN4JFPTH00L2zkjEpM
 U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=HGQsGU
 TqZPSR9CegV/KIm9bLOk63AAxQNNeTwJOnU90=; b=J20MPdzR2ep+z4bmP+x6L/
 J9L4dyaqKRzmSpqIb8EdO5SpQHzqYDIx42Q3Y02C1F1kRFMVySt116WqvgJ4bmja
 9xna9yd/B6S39c0F+ZIv22maqhjQZ3xdvtda4S2Gjbrkn1yODfW1xB/UeD/IJ7w6
 u2exM1OmS24IlfqGRXjCSE0IvpQexVseuc+hqU/cd5F7Jr8knnoe5UQT0un/pNo0
 45nQTuouzyrx3/wDNyIQZLtzMkoq5gvE0cmCMhDey/50s+3f+7tmKEAdq0pJI0kK
 9oxAxSOC072zNSmfEs8S1IemyU0cSTFsnPUQE1sgGL0kRp4YaEMUGD3qijBkd2CA
 ==
X-ME-Proxy: <xmx:hh1HW33ewMrWO8kT4Oq-YPOmlrUhWijnfixZvB4Y33gvC0N1i0soQg>
 <xmx:hh1HW9w4BEv15MWZKQagW0344Ln1IJBwbfEk7lV2ZZxqvd1O1vy3Gg>
 <xmx:hh1HW9tzUDTyawFm0qbVkMec_LtNNdVHM0wPOflKcSiJNO2nzu4_5A>
 <xmx:hh1HW-NYDiET3MtH0FARt4UMLi2KG-a_I5X5Gy5F8b_QSoNOEH5GNQ>
 <xmx:hh1HW1w6TxlH9CNbEtePhs49xEU3lYnVP7bgVcrt6qXxlM1UTpZCBw>
 <xmx:hh1HW7_G2phUH3uhLE9hOCZe43g6RqHL7j9uyPNtOSNYxgicW0dzKg>
X-ME-Sender: <xms:hh1HW9PfCBP6JmYsID5acvvQ6s6GF4AjcNZhOFdZZY0R2dPwEvhWkg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 08E491028D;
 Thu, 12 Jul 2018 05:21:08 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "Shelton, Benjamin H" <benjamin.h.shelton@intel.com>, "Vangati,
 Narender" <narender.vangati@intel.com>, gaetan.rivet@6wind.com
Date: Thu, 12 Jul 2018 11:21:07 +0200
Message-ID: <6746975.Jtb5olJ73J@xps>
In-Reply-To: <039ED4275CED7440929022BC67E706115325966D@SHSMSX103.ccr.corp.intel.com>
References: <20180607123849.14439-1-qi.z.zhang@intel.com>
 <2770006.tjtdisTQ3j@xps>
 <039ED4275CED7440929022BC67E706115325966D@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v12 00/19] enable hotplug on multi-process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2018 09:21:11 -0000

12/07/2018 11:11, Zhang, Qi Z:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 12/07/2018 03:14, Qi Zhang:
> > > v13:
> > > - Since rte_eth_dev_attach/rte_eth_dev_detach will be deprecated,
> > >   so, modify the sample code to use rte_eal_hotplug_add and
> > >   rte_eal_hotplug_remove to attach/detach device.
> > 
> > Yes, this is what I tried to explain you.
> > 
> > I think it is now too late for 18.08.
> 
> Understand, but probably patch 2,3,4 could be considered in 18.08, since they fix general issue but not just for hotplug mp.
> What do you think?

Yes, you are right.

Please send a separate patchset and try to get reviews.
Gaetan, Anatoly, please review patches 2 and 3.