From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 454401D7; Wed, 20 Feb 2019 15:56:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 06:56:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="148391965" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.132]) ([10.237.221.132]) by fmsmga001.fm.intel.com with ESMTP; 20 Feb 2019 06:56:37 -0800 To: Ferruh Yigit , Hari Kumar Vemula , dev@dpdk.org Cc: "Pattan, Reshma" , JananeeX M , Declan , stable@dpdk.org, Hyong Youb Kim References: <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com> <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com> From: Radu Nicolau Message-ID: <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com> Date: Wed, 20 Feb 2019 14:56:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix reset active slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 14:56:41 -0000 On 2/20/2019 12:33 PM, Ferruh Yigit wrote: > On 2/18/2019 3:58 PM, Radu Nicolau wrote: >> >> On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: >>> test_alb_reply_from_client test fails due to incorrect active slave >>> array's index. This was due to invalid active slave count. >>> >>> Count of internals->active_slave is not updated even when active slave >>> is deactivated. >>> Hence active slave count always keeps incrementing beyond the actual >>> active slaves. >>> >>> Fix is to set the internals->active_slave to starting index 0 whenever >>> it exceeds the number of slaves in active slave list and also update >>> the active slave count during slave de-activation. >>> >>> Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Hari Kumar Vemula >>> --- >>> >> Acked-by: Radu Nicolau > > > Hi Radu, Hari, > > There is another bonding patch, can you please check how related are they and if > are these fixing same root cause: > > net/bonding: avoid the next active slave going out of bound > https://patches.dpdk.org/patch/49573/ > Hi, it's a similar fix for the same root cause, but this one covers more (or all) situations that can cause active_slave to go out of bounds.