[dpdk-dev] [PATCH 1/4] .gitignore: add section header comments

[dpdk-dev] [PATCH 1/4] .gitignore: add section header comments

[Bruce Richardson]

Split the ignored file list into section based on logical groups of files,
putting a comment at the top of each section clarifying what it is.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index 9105e26c5..b23e1dbb7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,9 +1,12 @@
+# ignore generated documentation tables
 doc/guides/nics/overview_table.txt
 doc/guides/cryptodevs/overview_feature_table.txt
 doc/guides/cryptodevs/overview_cipher_table.txt
 doc/guides/cryptodevs/overview_auth_table.txt
 doc/guides/cryptodevs/overview_aead_table.txt
 doc/guides/compressdevs/overview_feature_table.txt
+
+# ignore generated ctags/cscope files
 cscope.out.po
 cscope.out.in
 cscope.out
-- 
2.20.1

[dpdk-dev] [PATCH 2/4] .gitignore: ignore python bytecode files

[Bruce Richardson]

After you run a python script, a .pyc file is often left behind, which we
don't want to track in git.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index b23e1dbb7..eb3c23705 100644
--- a/.gitignore
+++ b/.gitignore
@@ -16,3 +16,6 @@ GPATH
 GRTAGS
 tags
 TAGS
+
+# ignore python bytecode files
+*.pyc
-- 
2.20.1

[dpdk-dev] [PATCH 3/4] .gitignore: ignore hidden files

[Bruce Richardson]

Generally hidden files are hidden for good reason and we don't want to
track them in git. They can always be manually added to git tracking
individually if needed.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index eb3c23705..79509c35d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,3 +19,6 @@ TAGS
 
 # ignore python bytecode files
 *.pyc
+
+# ignore hidden files
+.*
-- 
2.20.1

[dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

[Bruce Richardson]

test-meson-build.sh generates multiple build directories for various
targets. As these follow a few known patterns of reasonable lengths,
and since they don't need to be tracked in git, we can add them to
the gitignore file.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.gitignore b/.gitignore
index 79509c35d..e10605c4b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,3 +22,9 @@ TAGS
 
 # ignore hidden files
 .*
+
+# ignore build directories from test-meson-builds
+build-arm64-*
+build-clang-*
+build-gcc-*
+build-x86-default
-- 
2.20.1

Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

[Thomas Monjalon]

06/03/2019 18:05, Bruce Richardson:
> test-meson-build.sh generates multiple build directories for various
> targets. As these follow a few known patterns of reasonable lengths,
> and since they don't need to be tracked in git, we can add them to
> the gitignore file.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> --- a/.gitignore
> +++ b/.gitignore
> +build-arm64-*
> +build-clang-*
> +build-gcc-*
> +build-x86-default

We could even ignore build-* ?

Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

[Stephen Hemminger]

On Sat, 09 Mar 2019 01:47:32 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 06/03/2019 18:05, Bruce Richardson:
> > test-meson-build.sh generates multiple build directories for various
> > targets. As these follow a few known patterns of reasonable lengths,
> > and since they don't need to be tracked in git, we can add them to
> > the gitignore file.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > --- a/.gitignore
> > +++ b/.gitignore
> > +build-arm64-*
> > +build-clang-*
> > +build-gcc-*
> > +build-x86-default  
> 
> We could even ignore build-* ?
> 
> 

Why not?
build*

Since the default build directory in build/

Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

[Thomas Monjalon]

09/03/2019 04:03, Stephen Hemminger:
> On Sat, 09 Mar 2019 01:47:32 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 06/03/2019 18:05, Bruce Richardson:
> > > test-meson-build.sh generates multiple build directories for various
> > > targets. As these follow a few known patterns of reasonable lengths,
> > > and since they don't need to be tracked in git, we can add them to
> > > the gitignore file.
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > +build-arm64-*
> > > +build-clang-*
> > > +build-gcc-*
> > > +build-x86-default  
> > 
> > We could even ignore build-* ?
> 
> Why not?
> build*
> 
> Since the default build directory in build/

Yes, but "git ls build*" is not empty because of buildtools/
Could be "build" and "build-*".

Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

[Rami Rosen]

> Thomas Monjalon <thomas@monjalon.net> wrote:

>Yes, but "git ls build*" is not empty because of buildtools/
>Could be "build" and "build-*".

+1


>
>
>
>
>

Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

[Bruce Richardson]

On Sat, Mar 09, 2019 at 03:32:57PM +0200, Rami Rosen wrote:
>    > Thomas Monjalon <[1]thomas@monjalon.net> wrote:
>    >Yes, but "git ls build*" is not empty because of buildtools/
>    >Could be "build" and "build-*".
>    +1
> 
Ok. I didn't want to be too liberal in my wildcarding hence the set I
provided, but I'll do a V2 with this sorter version, since it makes sense
and is unlikely to cause us issues.

/Bruce

[dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments

[Bruce Richardson]

Split the ignored file list into section based on logical groups of files,
putting a comment at the top of each section clarifying what it is.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index 9105e26c5..b23e1dbb7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,9 +1,12 @@
+# ignore generated documentation tables
 doc/guides/nics/overview_table.txt
 doc/guides/cryptodevs/overview_feature_table.txt
 doc/guides/cryptodevs/overview_cipher_table.txt
 doc/guides/cryptodevs/overview_auth_table.txt
 doc/guides/cryptodevs/overview_aead_table.txt
 doc/guides/compressdevs/overview_feature_table.txt
+
+# ignore generated ctags/cscope files
 cscope.out.po
 cscope.out.in
 cscope.out
-- 
2.20.1

[dpdk-dev] [PATCH v2 2/4] .gitignore: ignore python bytecode files

[Bruce Richardson]

After you run a python script, a .pyc file is often left behind, which we
don't want to track in git.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index b23e1dbb7..eb3c23705 100644
--- a/.gitignore
+++ b/.gitignore
@@ -16,3 +16,6 @@ GPATH
 GRTAGS
 tags
 TAGS
+
+# ignore python bytecode files
+*.pyc
-- 
2.20.1

[dpdk-dev] [PATCH v2 3/4] .gitignore: ignore hidden files

[Bruce Richardson]

Generally hidden files are hidden for good reason and we don't want to
track them in git. They can always be manually added to git tracking
individually if needed.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index eb3c23705..79509c35d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,3 +19,6 @@ TAGS
 
 # ignore python bytecode files
 *.pyc
+
+# ignore hidden files
+.*
-- 
2.20.1

[dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories

[Bruce Richardson]

test-meson-build.sh generates multiple build directories for various targets.
As these follow a known pattern, and since they don't need to be tracked in
git, we can add them to the gitignore file, along with the default build
directory "build".

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.gitignore b/.gitignore
index 79509c35d..73822ae5e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,3 +22,7 @@ TAGS
 
 # ignore hidden files
 .*
+
+# ignore default build directory, and directories from test-meson-builds.sh
+build
+build-*
-- 
2.20.1

Re: [dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories

[Rami Rosen]

Acked-by: Rami Rosen <ramirose@gmail.com>


>

Re: [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments

[Thomas Monjalon]

11/03/2019 11:57, Bruce Richardson:
> Split the ignored file list into section based on logical groups of files,
> putting a comment at the top of each section clarifying what it is.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Series applied, thanks