From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B035A00BE; Tue, 29 Oct 2019 11:31:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CE401BEA7; Tue, 29 Oct 2019 11:31:36 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7441A2BAA for ; Tue, 29 Oct 2019 11:31:34 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id A8E688005C; Tue, 29 Oct 2019 10:31:32 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 29 Oct 2019 10:31:25 +0000 To: Olivier Matz , CC: Anatoly Burakov , Ferruh Yigit , "Giridharan, Ganesan" , Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Stephen Hemminger , "Thomas Monjalon" , Vamsi Krishna Attunuru References: <20190719133845.32432-1-olivier.matz@6wind.com> <20191028140122.9592-1-olivier.matz@6wind.com> <20191028140122.9592-5-olivier.matz@6wind.com> From: Andrew Rybchenko Message-ID: <67618332-fac8-eac1-ea66-24ed8a4b5c93@solarflare.com> Date: Tue, 29 Oct 2019 13:31:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191028140122.9592-5-olivier.matz@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25008.003 X-TM-AS-Result: No-0.237600-8.000000-10 X-TMASE-MatchedRID: VPleTT1nwdQ6yy6RAAEPc2Lv/foKD6FA69aS+7/zbj+qvcIF1TcLYAYx Jykfuo4AkCFNQ46XU+wO6bgzXko5LNP/9zlego/mLbjXqdzdtCV5GpkA2em4X6tkcxxU6EVIaNO zkv3XITOt2gtuWr1Lmh3fcQAWUOWdGY2qxS6i1Gz/V0SDC1Do0LY6GIm8HMwtQzcrLK1tq+ejxY yRBa/qJQPTK4qtAgwIIC0OoeD/hCbQLWxBF9DMQcRB0bsfrpPIreCTu6Ejg5jeUv2hwmXVFVLh2 BRedgf2vBFBzeu7zVYFVYB58wm3ja00hwnb1lJKptRGthNczj/CwTphO+AcIj+RX64RAKGDVa3D hFjPr/bUNewp4E2/TgSpmVYGQlZ3sxk1kV1Ja8cbbCVMcs1jUlqAtPM/2FFilExlQIQeRG0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.237600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25008.003 X-MDID: 1572345093-IlvQjdUWOqz8 Subject: Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/28/19 5:01 PM, Olivier Matz wrote: > In rte_mempool_populate_default(), we determine the page size, > which is needed for calc_size and allocation of memory. > > Move this in a function and export it, it will be used in next > commit. > > Signed-off-by: Olivier Matz One question below: Reviewed-by: Andrew Rybchenko [snip] > diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map > index 17cbca460..4eff2767d 100644 > --- a/lib/librte_mempool/rte_mempool_version.map > +++ b/lib/librte_mempool/rte_mempool_version.map > @@ -56,5 +56,6 @@ DPDK_18.05 { > EXPERIMENTAL { > global: > > + rte_mempool_get_page_size; > rte_mempool_ops_get_info; > }; Should internal function be here?