From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DB77A050B; Wed, 13 Apr 2022 14:02:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EAAC40694; Wed, 13 Apr 2022 14:02:56 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id BE4174068B; Wed, 13 Apr 2022 14:02:54 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 09DBE5C0275; Wed, 13 Apr 2022 08:02:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 13 Apr 2022 08:02:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1649851374; x= 1649937774; bh=PaMNfvlxh9ex9eGigwowUNKWHC7GXtP+rAmiE9cjizE=; b=w 0Dh3dlU/WQ+5OMIuGZ1HKXmqa/DDjgJuh8RLoZian+vVFeZvwTIaeROeMs7KgDTQ 1fayxFDUMwF9I721LswgSP+qQmkRX03v3s8AYTfG0LQSZnZQdYZ3ZE6RoFAv4x2R oPQftEZf+5VT9zm0DYCosiMhFZ9H3EWCke4vqvgUerlMo5YqezjAJGB1pJKvueQP F+kTao3uJDUnupcYs6t7Gl/aZD8+/07ppUjRchYRZqjnhnceRCWxpPdPDj6SNINm CqDBy4bQ2HvTBJI8TcVJNLblBeWtscm28UjEL7Ji9nOy8j7clq+Zel7EOYBVFfW0 PmDE/uuRQ5isTdg/cRbjw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1649851374; x=1649937774; bh=PaMNfvlxh9ex9 eGigwowUNKWHC7GXtP+rAmiE9cjizE=; b=IT25muXtf3mtwQ4qPjrDq3AR1UPz0 UiKOR0kgbFhkqlm6UAV8rLoZ4H8VEO1B5ZzRIfMbORAsM5VMvt+bqenZrUUkZ12O QzuCFTcZBUmPSavHfyGb5Vn/opjXVyEePDHOgNqQHr3lJ7M+NlVnwGN/P29MyG6j Cdrb4OluvT91p9nkcH5q+yzN5Qla5V6B9Q82g2UYPJ/pwbsVqqYw16NfDE3yFqaP rqhRAdkXhcg/fGmBznelvWcTyMO6LCVScyS9krIk+VgoInVlGeVq4hAfi6Iz+LuX IkD2vNqihHI5h2PQverWx7puajkxL1n02FfIOpDF3AE2cLJe7bGlYxcnQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeluddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu veegvdeggedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Apr 2022 08:02:52 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz , Ben Magistro Cc: Morten =?ISO-8859-1?Q?Br=F8rup?= , dev@dpdk.org, ben.magistro@trinitycyber.com, Stefan Baranoff , stable@dpdk.org, Luca Boccassi , Christian Ehrhardt , "Xueming(Steven) Li" , Kevin Traynor , stable@dpdk.org Subject: Re: [PATCH] mbuf: expose outer vlan in mbuf dump Date: Wed, 13 Apr 2022 14:02:50 +0200 Message-ID: <6763347.18pcnM708K@thomas> In-Reply-To: References: <20220404005634.2657-1-koncept1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/04/2022 18:11, Ben Magistro: > Was there a consensus on if this should be re-drafted as a bug and fixes = or > left as a backportable feature/improvement? I am good either way, just > wanted to clarify if I had an additional action at this time. There is no consensus but that's a detail. In any case we agree to backport it. I'll merge it with Cc: stable@dpdk.org > On Wed, Apr 6, 2022 at 3:33 AM Olivier Matz wrot= e: >=20 > > Hi, > > > > On Tue, Apr 05, 2022 at 05:51:05PM +0200, Thomas Monjalon wrote: > > > 04/04/2022 12:33, Kevin Traynor: > > > > On 04/04/2022 07:15, Morten Br=F8rup wrote: > > > > >> From: Ben Magistro [mailto:koncept1@gmail.com] > > > > >> Sent: Monday, 4 April 2022 02.57 > > > > >> > > > > >> Enable printing of the outer vlan if flags indicate it is presen= t. > > > > >> > > > > >> Signed-off-by: Ben Magistro > > > > Acked-by: Olivier Matz > > > > > > >> > > > > >> --- > > > > >> > > > > >> While troubleshooting some QinQ offloads with various Intel i40e > > > > >> firmware[1], it was > > > > >> helpful to expose the outer vlan in the dump mbuf calls. This > > should > > > > >> be straightforward > > > > >> to backport and happy to do the work if accepted. I understand t= hat > > > > >> this may not be a > > > > >> widely supported capability at this time, so we are okay if this= is > > not > > > > >> accepted and > > > > >> we just maintain a local patch. > > > > > > > > > > Features are usually not backported, only bug fixes. > > > > > > > > > > However, since this patch proved helpful finding a bug, and it is > > very simple, it could be considered by the LTS maintainers. > > > > > > > > > > > > Suggest to tag the patch with 'Cc: stable@dpdk.org' to indicate it = is > > > > requested for stable branches. It will be caught by stable maintain= er > > > > filters when it is time for backports and can be discussed further > > then. > > > > > > I think it is a bug. > > > What was introduced first? the function or the field? > > > Please find the commit where it should have been done > > > and mark it with "Fixes:" syntax + Cc:stable. > > > > The vlan dump was introduced by commit 5b6eaea8ea7c ("mbuf: display more > > fields in dump"), but I don't think we can say it's a bug. To me, it is > > an enhancement that could be backported, because there is a benefit with > > a very low risk. > > >=20