From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD4CAA2EDB for ; Fri, 6 Sep 2019 15:33:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 676CB1F414; Fri, 6 Sep 2019 15:33:46 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1D77791 for ; Fri, 6 Sep 2019 15:33:45 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 9F2659C0053; Fri, 6 Sep 2019 13:33:42 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Sep 2019 14:33:14 +0100 To: Aaron Conole CC: "John W. Linville" , Xiaolong Ye , Qi Zhang , Shepard Siegel , Ed Czeck , "John Miller" , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , "Guy Tzalik" , Evgeny Schemeilin , Gagandeep Singh , John Daley , "Hyong Youb Kim" , Gaetan Rivet , "Xiao Wang" , Ziyang Xuan , "Xiaoyun Wang" , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Ferruh Yigit , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Yongseok Koh , "Viacheslav Ovsiienko" , Zyta Szpak , "Liron Himi" , Tomasz Duszynski , "Stephen Hemminger" , "K. Y. Srinivasan" , Haiyang Zhang , Rastislav Cernay , Jan Remes , Alejandro Lucero , Tetsuya Mukawa , "Jerin Jacob" , Nithin Dabilpuram , Kiran Kumar K , Bruce Richardson , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Thomas Monjalon , , Ivan Ilchenko References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <1567755066-31389-1-git-send-email-arybchenko@solarflare.com> <1567755066-31389-18-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <6772b880-c445-787b-f954-1dbc477281a0@solarflare.com> Date: Fri, 6 Sep 2019 16:33:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24892.003 X-TM-AS-Result: No-0.341300-8.000000-10 X-TMASE-MatchedRID: zGP2F0O7j/s6yy6RAAEPc0PdsiR0fGlp69aS+7/zbj+qvcIF1TcLYHEw XQeqkv+8QOaAfcvrs347Ela2LzAmnxLwsVmbC9NrzNIobH2DzGFpeZ1cXZibx/n6214PlHOFJWY O7g6dGwvMWVcuVROElQJzbAuZnLsAYTc/uPw/7oLm96eHJyFxjWcCy3wC35zdVz8J52OVy+QcUn IIyt02Sd//UJxAfUVBe0HF0ouRBViPaFHMfVTC4IMbH85DUZXyseWplitmp0j6C0ePs7A07YOP5 ZSwIKJEvcbvnB4EpgwkxuH7eeX4zUrdB5hj4J20wqbmQ26hNF15PGeCWV7UCkRet2zP1cNEUsTb /gUjNuRBwNN4eSFDaDfTu2PbImn8UdNvZjjOj9C63BPMcrcQuXeYWV2RaAfD8VsfdwUmMsnud1Q dQyZe7n7cGd19dSFd X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.341300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24892.003 X-MDID: 1567776824-QEXCB5XhueDs Subject: Re: [dpdk-dev] [PATCH v3 17/54] ethdev: change device info get callback to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/6/19 4:29 PM, Aaron Conole wrote: > Andrew Rybchenko writes: > >> From: Ivan Ilchenko >> >> Change eth_dev_infos_get_t return value from void to int. >> Make eth_dev_infos_get_t implementations across all drivers to return >> negative errno values if case of error conditions. >> >> Signed-off-by: Ivan Ilchenko >> Signed-off-by: Andrew Rybchenko >> --- > This patch needs a respin. > > ../drivers/net/atlantic/atl_ethdev.c > ../drivers/net/atlantic/atl_ethdev.c:123:12: error: conflicting types for ‘atl_dev_info_get’ > static int atl_dev_info_get(struct rte_eth_dev *dev, > ^ > ../drivers/net/atlantic/atl_ethdev.c:48:13: note: previous declaration of ‘atl_dev_info_get’ was here > static void atl_dev_info_get(struct rte_eth_dev *dev, > > Looks like the function prototype appears twice in the .c file - I > suggest removing one of them. It is already done: http://git.dpdk.org/next/dpdk-next-net/commit/?id=2c9202612408baf748609d3ee4e49cc183e0366c