From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2D16849E0
 for <dev@dpdk.org>; Fri, 10 May 2019 00:31:46 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id BA38F2104A;
 Thu,  9 May 2019 18:31:45 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 09 May 2019 18:31:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=+PHXhVeRMAjcmbBMGjmsAilUaNdJ92XM0ao5lcAjFM4=; b=PDodEa3ZDImK
 KMT6ZRJcwDwIeUfyfEydwT/OUbdlB88Exy1EiO/WbwZIhoHhjtza5xh+ldmWu7gA
 v3WpKbqc/Qtm5BU1Jb7rEGJ4PM+AtvAr8/Eb/IyYDGNyZFMUL7rbeDABknhibpV9
 djLV3eMzUjLdBdNBSXdbmKIcp71Q18E=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=+PHXhVeRMAjcmbBMGjmsAilUaNdJ92XM0ao5lcAjF
 M4=; b=QUD2+BpMUUbDLonr9nyQWX346LrChpUFkMaJIuN0f9oyd38Lkq8ytapjE
 U+HmLdgkbCjdAB4IN5SiXvDdQh/jkSBhGJoLMdm50PKKQd3M23SBf51DmyaiYUip
 IMiEMigOKHkvVv5kyLeis71yYl+YR+rxNNjk6waB7zwdRNA7aAI/EHlXBddYEnvW
 8HZgSFW4o8UvL3rgp4kQvg+8vQnpLW2ai2l8UFiqz0Wf8wECh8KAyZQ/cZcfZfp2
 GypVfo2/QsO2uIohrTYNmmhdXUvwYQxFaKo7wLnwI9TPVU09v2b9kz6YQDBeLZEY
 qw83nJYprPwTs8krao66elkubqmcg==
X-ME-Sender: <xms:UarUXIDkI70Kz8-wyiEJ2hlXP4Dkjse3JKPncoW72lzrxyDUi4bTrw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdduudegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff
 homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu
 rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne
 cuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:UarUXK_gMbNpVPC3PbG1tdC4SXjMKbZv_YB0o56llblgWGx2iM75rg>
 <xmx:UarUXCcnQNrNCFtyuuFohAgGKd8hK3_WF8nWYR4dJArhUVVtGRrDDA>
 <xmx:UarUXFAlhdGnZ0DK23N8YxZWhGGKJJV7hFKb6eJl3ap0aQAkily1JQ>
 <xmx:UarUXG2VDMQYzddfAZ7Ogf0hqWlYoUjlS1KefQXlf06Id6b-AIxDAw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E0CCB80063;
 Thu,  9 May 2019 18:31:43 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Vipin Varghese <vipin.varghese@intel.com>
Cc: dev@dpdk.org, marko.kovacevic@intel.com, john.mcnamara@intel.com,
 wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,
 sanjay.padubidri@intel.com, konstantin.ananyev@intel.com
Date: Fri, 10 May 2019 00:31:42 +0200
Message-ID: <67739198.mN8PHIGBQv@xps>
In-Reply-To: <20190507084112.35296-1-vipin.varghese@intel.com>
References: <20190507084112.35296-1-vipin.varghese@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] doc/testpmd: update compile steps for bpf
	examples
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2019 22:31:46 -0000

07/05/2019 10:41, Vipin Varghese:
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4657,6 +4657,10 @@ To load (not JITed) t1.o at TX queue 0, port 0::
>  
>     testpmd> bpf-load tx 0 0 - ./dpdk.org/examples/bpf/t1.o
>  
> +.. note::
> +
> +   In order to build t2.c and t3.c; pass DPDK target's include and library path as compiler options.

This note should be below the compilation command.
When adding more BPF examples, it will be easily outdated.
We could say "to build other examples, more arguments may be required".
About the compiler options, I suggest to name them: -I, -L?

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id D720DA0096
	for <public@inbox.dpdk.org>; Fri, 10 May 2019 00:31:49 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 37D164C74;
	Fri, 10 May 2019 00:31:48 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2D16849E0
 for <dev@dpdk.org>; Fri, 10 May 2019 00:31:46 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id BA38F2104A;
 Thu,  9 May 2019 18:31:45 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 09 May 2019 18:31:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=+PHXhVeRMAjcmbBMGjmsAilUaNdJ92XM0ao5lcAjFM4=; b=PDodEa3ZDImK
 KMT6ZRJcwDwIeUfyfEydwT/OUbdlB88Exy1EiO/WbwZIhoHhjtza5xh+ldmWu7gA
 v3WpKbqc/Qtm5BU1Jb7rEGJ4PM+AtvAr8/Eb/IyYDGNyZFMUL7rbeDABknhibpV9
 djLV3eMzUjLdBdNBSXdbmKIcp71Q18E=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=+PHXhVeRMAjcmbBMGjmsAilUaNdJ92XM0ao5lcAjF
 M4=; b=QUD2+BpMUUbDLonr9nyQWX346LrChpUFkMaJIuN0f9oyd38Lkq8ytapjE
 U+HmLdgkbCjdAB4IN5SiXvDdQh/jkSBhGJoLMdm50PKKQd3M23SBf51DmyaiYUip
 IMiEMigOKHkvVv5kyLeis71yYl+YR+rxNNjk6waB7zwdRNA7aAI/EHlXBddYEnvW
 8HZgSFW4o8UvL3rgp4kQvg+8vQnpLW2ai2l8UFiqz0Wf8wECh8KAyZQ/cZcfZfp2
 GypVfo2/QsO2uIohrTYNmmhdXUvwYQxFaKo7wLnwI9TPVU09v2b9kz6YQDBeLZEY
 qw83nJYprPwTs8krao66elkubqmcg==
X-ME-Sender: <xms:UarUXIDkI70Kz8-wyiEJ2hlXP4Dkjse3JKPncoW72lzrxyDUi4bTrw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdduudegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff
 homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu
 rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne
 cuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:UarUXK_gMbNpVPC3PbG1tdC4SXjMKbZv_YB0o56llblgWGx2iM75rg>
 <xmx:UarUXCcnQNrNCFtyuuFohAgGKd8hK3_WF8nWYR4dJArhUVVtGRrDDA>
 <xmx:UarUXFAlhdGnZ0DK23N8YxZWhGGKJJV7hFKb6eJl3ap0aQAkily1JQ>
 <xmx:UarUXG2VDMQYzddfAZ7Ogf0hqWlYoUjlS1KefQXlf06Id6b-AIxDAw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E0CCB80063;
 Thu,  9 May 2019 18:31:43 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Vipin Varghese <vipin.varghese@intel.com>
Cc: dev@dpdk.org, marko.kovacevic@intel.com, john.mcnamara@intel.com,
 wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,
 sanjay.padubidri@intel.com, konstantin.ananyev@intel.com
Date: Fri, 10 May 2019 00:31:42 +0200
Message-ID: <67739198.mN8PHIGBQv@xps>
In-Reply-To: <20190507084112.35296-1-vipin.varghese@intel.com>
References: <20190507084112.35296-1-vipin.varghese@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] doc/testpmd: update compile steps for bpf
	examples
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190509223142.4F7zEttk2P_DEZAizhbnJSTt_1Ta4QmMtsH23DtE_y0@z>

07/05/2019 10:41, Vipin Varghese:
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4657,6 +4657,10 @@ To load (not JITed) t1.o at TX queue 0, port 0::
>  
>     testpmd> bpf-load tx 0 0 - ./dpdk.org/examples/bpf/t1.o
>  
> +.. note::
> +
> +   In order to build t2.c and t3.c; pass DPDK target's include and library path as compiler options.

This note should be below the compilation command.
When adding more BPF examples, it will be easily outdated.
We could say "to build other examples, more arguments may be required".
About the compiler options, I suggest to name them: -I, -L?