From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 12A174C94 for ; Tue, 2 Apr 2019 09:12:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B22B622145; Tue, 2 Apr 2019 03:12:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 03:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CAmL7vuLLGtGiqFt/5k/NChYYOFeQLk/RqydHoYaxTM=; b=ILmudrgXLRYx xjPg8JaRhR7Q3cOmD6GXqO3a7bt959hP9UTSdJNP40h2ZB2f0H8JcBOhMGsCfo2W jV7urxd7bdmpsBV8XLPTUYt36+02J3+uzgf/b8g9vh3gjhQVAKzToPmXGvbJLrHY cUSGXFG0kakCmwhMgZriqviU7WI7g4E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CAmL7vuLLGtGiqFt/5k/NChYYOFeQLk/RqydHoYax TM=; b=j3Q5mWwx6Cpju3HLJUp9eoqChz7dq/mc/m5gb0ad5veM1vo2U5dtZ1TCy vey59vM685306VVHnRm8kB/TmE5+K4cHpV5xPp6xrSHmjGeIYIfLsR5I9ufbsLPX T2s/WMxi9VPgY78pTKVvEMKW6FHCfdEOIP2OLMkJkWp+GP3wEMpkAniMm4NsaMIR Yd7/qIgSOmOqzr0/Rc3HZMGIypIgx1gygFw/FHECCx7BkXUUlN4asSD/CZQuZge+ Ol/YebVeIn3O/TAzf2p88q1m9sEB5P1/Htx+wAIk43cBJGjAnFjlNZ7M6R37SVgb 63mM7DQzSPxTts+1BGpOwHFpDbROQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgdduudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehtvghsthdqmhgvshhonhdqsghuihhlughsrdhshhdpughpughkrdhorhhg necukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1CB2310319; Tue, 2 Apr 2019 03:12:08 -0400 (EDT) From: Thomas Monjalon To: "Lu, Wenzhuo" Cc: "Yigit, Ferruh" , "Zhang, Qi Z" , "dev@dpdk.org" , "O'Hare, Cathal" , "Mcnamara, John" , bruce.richardson@intel.com, qian.q.xu@intel.com Date: Tue, 02 Apr 2019 09:12:06 +0200 Message-ID: <6789038.CEtV5r9RId@xps> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909407F954A@shsmsx102.ccr.corp.intel.com> References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <2282021.H7KxSoY9xU@xps> <6A0DE07E22DDAD4C9103DF62FEBC0909407F954A@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 07:12:10 -0000 02/04/2019 03:01, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 01/04/2019 17:12, Ferruh Yigit: > > > On 4/1/2019 2:27 PM, Thomas Monjalon wrote: > > > > 01/04/2019 14:51, Ferruh Yigit: > > > >> On 3/31/2019 4:52 PM, Thomas Monjalon wrote: > > > >>> 26/03/2019 10:50, Ferruh Yigit: > > > >>>>> Wenzhuo Lu (8): > > > >>>>> net/ice: fix Tx function setting > > > >>>>> net/ice: add pointer for queue buffer release > > > >>>>> net/ice: support vector SSE in RX > > > >>>>> net/ice: support Rx scatter SSE vector > > > >>>>> net/ice: support Tx SSE vector > > > >>>>> net/ice: support Rx AVX2 vector > > > >>>>> net/ice: support Rx scatter AVX2 vector > > > >>>>> net/ice: support vector AVX2 in TX > > > >>>> > > > >>>> This version (v7) pulled from next-net-intel to next-net. > > > >>> > > > >>> I assume these patches have been tested, or at least compiled. > > > >>> However, when running devtools/test-meson-builds.sh, there is a > > > >>> compilation error for build-x86-default: > > > >>> > > > >>> In file included from ../drivers/net/ice/ice_ethdev.h:10: > > > >>> rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found > > > >> > > > >> I tested this with meson but not able to catch the issue. Perhaps > > > >> for my case dependencies were build fast enough to cause a problem. > > > > > > > > No, it's not a matter of speed. > > > > > > No it is not, > > > > > > > Are you running devtools/test-meson-builds.sh ? > > > > > > No, I am using with another script but not building 'default' > > > architecture with meson where problem happens, that is why not able to > > > catch this. Will try to catch next time.. > > > > Ferruh, why not using the scripts we are building in devtools? > I have a suggestion. Why not integrating all the compile check here, like http://mails.dpdk.org/archives/test-report/2019-March/077966.html. If it fails, the patch state should be changed to "compile error". It will not be accepted. It can help everyone, especially the committer. > We cannot assume everyone knows everything. To me, have to say not familiar with meson build. Yes it would help to have meson tested in CI. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0F99DA0679 for ; Tue, 2 Apr 2019 09:12:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C36E74C95; Tue, 2 Apr 2019 09:12:10 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 12A174C94 for ; Tue, 2 Apr 2019 09:12:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B22B622145; Tue, 2 Apr 2019 03:12:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 03:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CAmL7vuLLGtGiqFt/5k/NChYYOFeQLk/RqydHoYaxTM=; b=ILmudrgXLRYx xjPg8JaRhR7Q3cOmD6GXqO3a7bt959hP9UTSdJNP40h2ZB2f0H8JcBOhMGsCfo2W jV7urxd7bdmpsBV8XLPTUYt36+02J3+uzgf/b8g9vh3gjhQVAKzToPmXGvbJLrHY cUSGXFG0kakCmwhMgZriqviU7WI7g4E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CAmL7vuLLGtGiqFt/5k/NChYYOFeQLk/RqydHoYax TM=; b=j3Q5mWwx6Cpju3HLJUp9eoqChz7dq/mc/m5gb0ad5veM1vo2U5dtZ1TCy vey59vM685306VVHnRm8kB/TmE5+K4cHpV5xPp6xrSHmjGeIYIfLsR5I9ufbsLPX T2s/WMxi9VPgY78pTKVvEMKW6FHCfdEOIP2OLMkJkWp+GP3wEMpkAniMm4NsaMIR Yd7/qIgSOmOqzr0/Rc3HZMGIypIgx1gygFw/FHECCx7BkXUUlN4asSD/CZQuZge+ Ol/YebVeIn3O/TAzf2p88q1m9sEB5P1/Htx+wAIk43cBJGjAnFjlNZ7M6R37SVgb 63mM7DQzSPxTts+1BGpOwHFpDbROQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgdduudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehtvghsthdqmhgvshhonhdqsghuihhlughsrdhshhdpughpughkrdhorhhg necukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1CB2310319; Tue, 2 Apr 2019 03:12:08 -0400 (EDT) From: Thomas Monjalon To: "Lu, Wenzhuo" Cc: "Yigit, Ferruh" , "Zhang, Qi Z" , "dev@dpdk.org" , "O'Hare, Cathal" , "Mcnamara, John" , bruce.richardson@intel.com, qian.q.xu@intel.com Date: Tue, 02 Apr 2019 09:12:06 +0200 Message-ID: <6789038.CEtV5r9RId@xps> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909407F954A@shsmsx102.ccr.corp.intel.com> References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <2282021.H7KxSoY9xU@xps> <6A0DE07E22DDAD4C9103DF62FEBC0909407F954A@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402071206._KflOxQBKen7yF7vx5D44x5xK1wMrKQ7IqWeVoGRGXs@z> 02/04/2019 03:01, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 01/04/2019 17:12, Ferruh Yigit: > > > On 4/1/2019 2:27 PM, Thomas Monjalon wrote: > > > > 01/04/2019 14:51, Ferruh Yigit: > > > >> On 3/31/2019 4:52 PM, Thomas Monjalon wrote: > > > >>> 26/03/2019 10:50, Ferruh Yigit: > > > >>>>> Wenzhuo Lu (8): > > > >>>>> net/ice: fix Tx function setting > > > >>>>> net/ice: add pointer for queue buffer release > > > >>>>> net/ice: support vector SSE in RX > > > >>>>> net/ice: support Rx scatter SSE vector > > > >>>>> net/ice: support Tx SSE vector > > > >>>>> net/ice: support Rx AVX2 vector > > > >>>>> net/ice: support Rx scatter AVX2 vector > > > >>>>> net/ice: support vector AVX2 in TX > > > >>>> > > > >>>> This version (v7) pulled from next-net-intel to next-net. > > > >>> > > > >>> I assume these patches have been tested, or at least compiled. > > > >>> However, when running devtools/test-meson-builds.sh, there is a > > > >>> compilation error for build-x86-default: > > > >>> > > > >>> In file included from ../drivers/net/ice/ice_ethdev.h:10: > > > >>> rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found > > > >> > > > >> I tested this with meson but not able to catch the issue. Perhaps > > > >> for my case dependencies were build fast enough to cause a problem. > > > > > > > > No, it's not a matter of speed. > > > > > > No it is not, > > > > > > > Are you running devtools/test-meson-builds.sh ? > > > > > > No, I am using with another script but not building 'default' > > > architecture with meson where problem happens, that is why not able to > > > catch this. Will try to catch next time.. > > > > Ferruh, why not using the scripts we are building in devtools? > I have a suggestion. Why not integrating all the compile check here, like http://mails.dpdk.org/archives/test-report/2019-March/077966.html. If it fails, the patch state should be changed to "compile error". It will not be accepted. It can help everyone, especially the committer. > We cannot assume everyone knows everything. To me, have to say not familiar with meson build. Yes it would help to have meson tested in CI.